All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	Christoph Hellwig <hch@lst.de>, Qian Cai <cai@redhat.com>,
	Sumit Saxena <sumit.saxena@broadcom.com>,
	John Garry <john.garry@huawei.com>,
	Kashyap Desai <kashyap.desai@broadcom.com>,
	Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH 3/3] Revert "block: Fix a lockdep complaint triggered by request queue flushing"
Date: Fri, 13 Nov 2020 09:11:18 +0800	[thread overview]
Message-ID: <20201113011118.GC1012796@T590> (raw)
In-Reply-To: <e0392f5e-1de2-d56b-027b-4bb4d041fdcc@acm.org>

On Thu, Nov 12, 2020 at 07:29:13AM -0800, Bart Van Assche wrote:
> On 11/12/20 7:12 AM, Bart Van Assche wrote:
> > On 11/11/20 11:55 PM, Ming Lei wrote:
> >> This reverts commit b3c6a59975415bde29cfd76ff1ab008edbf614a9.
> >>
> >> Now we can avoid nvme-loop lockdep warning of 'lockdep possible recursive
> >> locking' by nvme-loop's lock class, no need to apply dynamically
> >> allocated lock class key, so revert commit b3c6a5997541("block: Fix a
> >> lockdep complaint triggered by request queue flushing").
> >>
> >> This way fixes horrible SCSI probe delay issue on megaraid_sas, and it
> >> is reported the whole probe may take more than half an hour.
> > 
> > The code touched by this patch is compiled out with locked disabled so
> > it is not clear to me how this patch could affect a probe delay for
> > megaraid_sas? Has the megaraid_sas probe issue perhaps not been root
> > caused correctly?
> 
> (replying to my own email)
> 
> I found the answer in the descriptions of the previous patches of this
> series. I think this patch would benefit from a more complete patch
> description.

Hello Bart,

OK, I can add more words to this commit log.

Thanks,
Ming


WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>, Qian Cai <cai@redhat.com>,
	John Garry <john.garry@huawei.com>,
	linux-nvme@lists.infradead.org,
	Kashyap Desai <kashyap.desai@broadcom.com>,
	linux-block@vger.kernel.org,
	Sumit Saxena <sumit.saxena@broadcom.com>,
	Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 3/3] Revert "block: Fix a lockdep complaint triggered by request queue flushing"
Date: Fri, 13 Nov 2020 09:11:18 +0800	[thread overview]
Message-ID: <20201113011118.GC1012796@T590> (raw)
In-Reply-To: <e0392f5e-1de2-d56b-027b-4bb4d041fdcc@acm.org>

On Thu, Nov 12, 2020 at 07:29:13AM -0800, Bart Van Assche wrote:
> On 11/12/20 7:12 AM, Bart Van Assche wrote:
> > On 11/11/20 11:55 PM, Ming Lei wrote:
> >> This reverts commit b3c6a59975415bde29cfd76ff1ab008edbf614a9.
> >>
> >> Now we can avoid nvme-loop lockdep warning of 'lockdep possible recursive
> >> locking' by nvme-loop's lock class, no need to apply dynamically
> >> allocated lock class key, so revert commit b3c6a5997541("block: Fix a
> >> lockdep complaint triggered by request queue flushing").
> >>
> >> This way fixes horrible SCSI probe delay issue on megaraid_sas, and it
> >> is reported the whole probe may take more than half an hour.
> > 
> > The code touched by this patch is compiled out with locked disabled so
> > it is not clear to me how this patch could affect a probe delay for
> > megaraid_sas? Has the megaraid_sas probe issue perhaps not been root
> > caused correctly?
> 
> (replying to my own email)
> 
> I found the answer in the descriptions of the previous patches of this
> series. I think this patch would benefit from a more complete patch
> description.

Hello Bart,

OK, I can add more words to this commit log.

Thanks,
Ming


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-11-13  1:11 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12  7:55 [PATCH 0/3] blk-mq/nvme-loop: use nvme-loop's lock class for addressing lockdep false positive warning Ming Lei
2020-11-12  7:55 ` Ming Lei
2020-11-12  7:55 ` [PATCH 1/3] blk-mq: add new API of blk_mq_hctx_set_fq_lock_class Ming Lei
2020-11-12  7:55   ` Ming Lei
2020-11-16 17:26   ` Christoph Hellwig
2020-11-16 17:26     ` Christoph Hellwig
2020-11-17  1:04     ` Ming Lei
2020-11-17  1:04       ` Ming Lei
2020-11-17  1:16       ` Ming Lei
2020-11-17  1:16         ` Ming Lei
2020-11-17  6:46         ` Kashyap Desai
2020-11-17  6:46           ` Kashyap Desai
2020-11-12  7:55 ` [PATCH 2/3] nvme-loop: use blk_mq_hctx_set_fq_lock_class to set loop's lock class Ming Lei
2020-11-12  7:55   ` Ming Lei
2020-11-16 17:27   ` Christoph Hellwig
2020-11-16 17:27     ` Christoph Hellwig
2020-11-12  7:55 ` [PATCH 3/3] Revert "block: Fix a lockdep complaint triggered by request queue flushing" Ming Lei
2020-11-12  7:55   ` Ming Lei
2020-11-12 15:12   ` Bart Van Assche
2020-11-12 15:12     ` Bart Van Assche
2020-11-12 15:29     ` Bart Van Assche
2020-11-12 15:29       ` Bart Van Assche
2020-11-13  1:11       ` Ming Lei [this message]
2020-11-13  1:11         ` Ming Lei
2020-11-13  1:27   ` [PATCH V2 " Ming Lei
2020-11-13  1:27     ` Ming Lei
2020-11-16 17:27     ` Christoph Hellwig
2020-11-16 17:27       ` Christoph Hellwig
2020-11-25  1:31 ` [PATCH 0/3] blk-mq/nvme-loop: use nvme-loop's lock class for addressing lockdep false positive warning Ming Lei
2020-11-25  1:31   ` Ming Lei
2020-11-30  2:36 ` Ming Lei
2020-11-30  2:36   ` Ming Lei
2020-12-02 19:07   ` Qian Cai
2020-12-02 19:07     ` Qian Cai
2020-12-03  0:50     ` Ming Lei
2020-12-03  0:50       ` Ming Lei
2020-12-03  1:23       ` Qian Cai
2020-12-03  1:23         ` Qian Cai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201113011118.GC1012796@T590 \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=cai@redhat.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=john.garry@huawei.com \
    --cc=kashyap.desai@broadcom.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sumit.saxena@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.