From: Nigel Christian <nigel.l.christian@gmail.com>
To: krzk@kernel.org
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, digetx@gmail.com,
linux-tegra@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] memory: tegra20-emc: remove redundant error message
Date: Sat, 14 Nov 2020 05:12:19 +0000 [thread overview]
Message-ID: <20201114051219.GA4746@fedora-project> (raw)
There is no need for dev_err() since irq already prints an error.
Eliminate unnecessary curly braces for single statement block.
Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
---
drivers/memory/tegra/tegra20-emc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
index 5e10aa97809f..181a360d7d6b 100644
--- a/drivers/memory/tegra/tegra20-emc.c
+++ b/drivers/memory/tegra/tegra20-emc.c
@@ -959,10 +959,8 @@ static int tegra_emc_probe(struct platform_device *pdev)
int irq, err;
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(&pdev->dev, "please update your device tree\n");
+ if (irq < 0)
return irq;
- }
emc = devm_kzalloc(&pdev->dev, sizeof(*emc), GFP_KERNEL);
if (!emc)
--
2.28.0
WARNING: multiple messages have this Message-ID (diff)
From: Nigel Christian <nigel.l.christian@gmail.com>
To: krzk@kernel.org
Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, digetx@gmail.com,
linux-tegra@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] memory: tegra20-emc: remove redundant error message
Date: Sat, 14 Nov 2020 00:12:19 -0500 [thread overview]
Message-ID: <20201114051219.GA4746@fedora-project> (raw)
There is no need for dev_err() since irq already prints an error.
Eliminate unnecessary curly braces for single statement block.
Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
---
drivers/memory/tegra/tegra20-emc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
index 5e10aa97809f..181a360d7d6b 100644
--- a/drivers/memory/tegra/tegra20-emc.c
+++ b/drivers/memory/tegra/tegra20-emc.c
@@ -959,10 +959,8 @@ static int tegra_emc_probe(struct platform_device *pdev)
int irq, err;
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(&pdev->dev, "please update your device tree\n");
+ if (irq < 0)
return irq;
- }
emc = devm_kzalloc(&pdev->dev, sizeof(*emc), GFP_KERNEL);
if (!emc)
--
2.28.0
next reply other threads:[~2020-11-14 5:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 5:12 Nigel Christian [this message]
2020-11-14 5:12 ` [PATCH] memory: tegra20-emc: remove redundant error message Nigel Christian
2020-11-14 5:33 ` Dmitry Osipenko
2020-11-14 5:33 ` Dmitry Osipenko
2020-11-14 5:55 ` Nigel Christian
2020-11-14 5:55 ` Nigel Christian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201114051219.GA4746@fedora-project \
--to=nigel.l.christian@gmail.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.