All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1 1/1] drm/panel: samsumg-ld9040: fix spi id_table
@ 2020-11-14 19:29 Sam Ravnborg
  2020-11-14 19:31 ` Sam Ravnborg
  0 siblings, 1 reply; 2+ messages in thread
From: Sam Ravnborg @ 2020-11-14 19:29 UTC (permalink / raw)
  To: dri-devel, Marek Szyprowski; +Cc: Sam Ravnborg, Thierry Reding, Lee Jones

A W=1 build resulted in the following warning:

    panel-samsung-ld9040.c:377:35: warning: ‘ld9040_ids’ defined but not used

The root cause was a missing assignment to spi_driver.id_table.

Fixes: 6915db346039 ("drm/panel: ld9040: add MODULE_DEVICE_TABLE with SPI IDs")
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v5.7+
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 drivers/gpu/drm/panel/panel-samsung-ld9040.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-samsung-ld9040.c b/drivers/gpu/drm/panel/panel-samsung-ld9040.c
index f484147fc3a6..c4b388850a13 100644
--- a/drivers/gpu/drm/panel/panel-samsung-ld9040.c
+++ b/drivers/gpu/drm/panel/panel-samsung-ld9040.c
@@ -383,6 +383,7 @@ MODULE_DEVICE_TABLE(spi, ld9040_ids);
 static struct spi_driver ld9040_driver = {
 	.probe = ld9040_probe,
 	.remove = ld9040_remove,
+	.id_table = ld9040_ids,
 	.driver = {
 		.name = "panel-samsung-ld9040",
 		.of_match_table = ld9040_of_match,
-- 
2.27.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1 1/1] drm/panel: samsumg-ld9040: fix spi id_table
  2020-11-14 19:29 [PATCH v1 1/1] drm/panel: samsumg-ld9040: fix spi id_table Sam Ravnborg
@ 2020-11-14 19:31 ` Sam Ravnborg
  0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2020-11-14 19:31 UTC (permalink / raw)
  To: dri-devel, Marek Szyprowski; +Cc: Thierry Reding, Lee Jones

Hi myself.

s/samsumg/samsung/ in the subject.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-14 19:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-14 19:29 [PATCH v1 1/1] drm/panel: samsumg-ld9040: fix spi id_table Sam Ravnborg
2020-11-14 19:31 ` Sam Ravnborg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.