All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Thomas Huth <thuth@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	qemu-s390x@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] hw: add compat machines for 6.0
Date: Mon, 16 Nov 2020 11:38:13 +0100	[thread overview]
Message-ID: <20201116113813.619aa510.cohuck@redhat.com> (raw)
In-Reply-To: <20201116112314.3e999cae@bahia.lan>

On Mon, 16 Nov 2020 11:23:14 +0100
Greg Kurz <groug@kaod.org> wrote:

> On Mon,  9 Nov 2020 18:39:28 +0100
> Cornelia Huck <cohuck@redhat.com> wrote:
> 
> > Add 6.0 machine types for arm/i440fx/q35/s390x/spapr.
> > 
> > Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> > ---
> >  hw/arm/virt.c              |  9 ++++++++-
> >  hw/core/machine.c          |  3 +++
> >  hw/i386/pc.c               |  3 +++
> >  hw/i386/pc_piix.c          | 14 +++++++++++++-
> >  hw/i386/pc_q35.c           | 13 ++++++++++++-
> >  hw/ppc/spapr.c             | 15 +++++++++++++--
> >  hw/s390x/s390-virtio-ccw.c | 14 +++++++++++++-
> >  include/hw/boards.h        |  3 +++
> >  include/hw/i386/pc.h       |  3 +++
> >  9 files changed, 71 insertions(+), 6 deletions(-)
> > 

(...)

> > diff --git a/hw/core/machine.c b/hw/core/machine.c
> > index 98b87f76cbbe..c5a6c517bb9d 100644
> > --- a/hw/core/machine.c
> > +++ b/hw/core/machine.c
> > @@ -28,6 +28,9 @@
> >  #include "hw/mem/nvdimm.h"
> >  #include "migration/vmstate.h"
> >  
> > +GlobalProperty hw_compat_5_2[] = {};  
> 
> Maybe worth putting the }; on the next line so that the next
> change has a prettier diff ?

That's mostly because I always copy from the last incarnation of that
patch; but can try to remember to change next time.

> 
> Apart from that,
> 
> Reviewed-by: Greg Kurz <groug@kaod.org>

Thanks!


WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Thomas Huth <thuth@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	qemu-s390x@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] hw: add compat machines for 6.0
Date: Mon, 16 Nov 2020 11:38:13 +0100	[thread overview]
Message-ID: <20201116113813.619aa510.cohuck@redhat.com> (raw)
In-Reply-To: <20201116112314.3e999cae@bahia.lan>

On Mon, 16 Nov 2020 11:23:14 +0100
Greg Kurz <groug@kaod.org> wrote:

> On Mon,  9 Nov 2020 18:39:28 +0100
> Cornelia Huck <cohuck@redhat.com> wrote:
> 
> > Add 6.0 machine types for arm/i440fx/q35/s390x/spapr.
> > 
> > Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> > ---
> >  hw/arm/virt.c              |  9 ++++++++-
> >  hw/core/machine.c          |  3 +++
> >  hw/i386/pc.c               |  3 +++
> >  hw/i386/pc_piix.c          | 14 +++++++++++++-
> >  hw/i386/pc_q35.c           | 13 ++++++++++++-
> >  hw/ppc/spapr.c             | 15 +++++++++++++--
> >  hw/s390x/s390-virtio-ccw.c | 14 +++++++++++++-
> >  include/hw/boards.h        |  3 +++
> >  include/hw/i386/pc.h       |  3 +++
> >  9 files changed, 71 insertions(+), 6 deletions(-)
> > 

(...)

> > diff --git a/hw/core/machine.c b/hw/core/machine.c
> > index 98b87f76cbbe..c5a6c517bb9d 100644
> > --- a/hw/core/machine.c
> > +++ b/hw/core/machine.c
> > @@ -28,6 +28,9 @@
> >  #include "hw/mem/nvdimm.h"
> >  #include "migration/vmstate.h"
> >  
> > +GlobalProperty hw_compat_5_2[] = {};  
> 
> Maybe worth putting the }; on the next line so that the next
> change has a prettier diff ?

That's mostly because I always copy from the last incarnation of that
patch; but can try to remember to change next time.

> 
> Apart from that,
> 
> Reviewed-by: Greg Kurz <groug@kaod.org>

Thanks!



  reply	other threads:[~2020-11-16 10:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09 17:39 [PATCH] hw: add compat machines for 6.0 Cornelia Huck
2020-11-11  6:21 ` David Gibson
2020-11-11  6:21   ` David Gibson
2020-11-15  7:02 ` Michael S. Tsirkin
2020-11-15  7:02   ` Michael S. Tsirkin
2020-11-16 10:23 ` Greg Kurz
2020-11-16 10:23   ` Greg Kurz
2020-11-16 10:38   ` Cornelia Huck [this message]
2020-11-16 10:38     ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201116113813.619aa510.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=ehabkost@redhat.com \
    --cc=groug@kaod.org \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.