All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: kernel test robot <lkp@intel.com>,
	Kashyap Desai <kashyap.desai@broadcom.com>,
	Sumanesh Samanta <sumanesh.samanta@broadcom.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, kbuild-all@lists.01.org,
	clang-built-linux@googlegroups.com,
	Omar Sandoval <osandov@fb.com>,
	"Ewan D . Milne" <emilne@redhat.com>,
	Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH V4 12/12] scsi: replace sdev->device_busy with sbitmap
Date: Wed, 18 Nov 2020 10:35:07 +0800	[thread overview]
Message-ID: <20201118023507.GA92339@T590> (raw)
In-Reply-To: <202011161944.U7XHrbsd-lkp@intel.com>

Hello Kashyap & Sumanesh,

On Mon, Nov 16, 2020 at 07:49:31PM +0800, kernel test robot wrote:
> Hi Ming,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on block/for-next]
> [also build test ERROR on mkp-scsi/for-next scsi/for-next v5.10-rc4 next-20201116]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Ming-Lei/blk-mq-scsi-tracking-device-queue-depth-via-sbitmap/20201116-171449
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
> config: powerpc64-randconfig-r026-20201116 (attached as .config)
> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c044709b8fbea2a9a375e4173a6bd735f6866c0c)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install powerpc64 cross compiling tool for clang build
>         # apt-get install binutils-powerpc64-linux-gnu
>         # https://github.com/0day-ci/linux/commit/cc286ae987be50d7b8e152cc80a5ccaa8682e3ff
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Ming-Lei/blk-mq-scsi-tracking-device-queue-depth-via-sbitmap/20201116-171449
>         git checkout cc286ae987be50d7b8e152cc80a5ccaa8682e3ff
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/scsi/megaraid/megaraid_sas_fusion.c:365:41: error: no member named 'device_busy' in 'struct scsi_device'
>            sdev_busy = atomic_read(&scmd->device->device_busy);

This new reference to sdev->device_busy is added by recent shared host
tag patch, and according to the comment, you may have planed to convert into
one megaraid internal counter.

        /* TBD - if sml remove device_busy in future, driver
         * should track counter in internal structure.
         */

So can you post one patch? And I am happy to fold it into this series.

Thanks,
Ming


WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH V4 12/12] scsi: replace sdev->device_busy with sbitmap
Date: Wed, 18 Nov 2020 10:35:07 +0800	[thread overview]
Message-ID: <20201118023507.GA92339@T590> (raw)
In-Reply-To: <202011161944.U7XHrbsd-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2469 bytes --]

Hello Kashyap & Sumanesh,

On Mon, Nov 16, 2020 at 07:49:31PM +0800, kernel test robot wrote:
> Hi Ming,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on block/for-next]
> [also build test ERROR on mkp-scsi/for-next scsi/for-next v5.10-rc4 next-20201116]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Ming-Lei/blk-mq-scsi-tracking-device-queue-depth-via-sbitmap/20201116-171449
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
> config: powerpc64-randconfig-r026-20201116 (attached as .config)
> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c044709b8fbea2a9a375e4173a6bd735f6866c0c)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install powerpc64 cross compiling tool for clang build
>         # apt-get install binutils-powerpc64-linux-gnu
>         # https://github.com/0day-ci/linux/commit/cc286ae987be50d7b8e152cc80a5ccaa8682e3ff
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Ming-Lei/blk-mq-scsi-tracking-device-queue-depth-via-sbitmap/20201116-171449
>         git checkout cc286ae987be50d7b8e152cc80a5ccaa8682e3ff
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/scsi/megaraid/megaraid_sas_fusion.c:365:41: error: no member named 'device_busy' in 'struct scsi_device'
>            sdev_busy = atomic_read(&scmd->device->device_busy);

This new reference to sdev->device_busy is added by recent shared host
tag patch, and according to the comment, you may have planed to convert into
one megaraid internal counter.

        /* TBD - if sml remove device_busy in future, driver
         * should track counter in internal structure.
         */

So can you post one patch? And I am happy to fold it into this series.

Thanks,
Ming

  reply	other threads:[~2020-11-18  2:35 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-16  9:07 [PATCH V4 00/12] blk-mq/scsi: tracking device queue depth via sbitmap Ming Lei
2020-11-16  9:07 ` [PATCH V4 01/12] sbitmap: remove sbitmap_clear_bit_unlock Ming Lei
2020-11-16  9:07 ` [PATCH V4 02/12] sbitmap: maintain allocation round_robin in sbitmap Ming Lei
2020-11-16  9:07 ` [PATCH V4 03/12] sbitmap: add helpers for updating allocation hint Ming Lei
2020-11-16  9:07 ` [PATCH V4 04/12] sbitmap: move allocation hint into sbitmap Ming Lei
2020-11-16  9:33   ` Hannes Reinecke
2020-11-16  9:07 ` [PATCH V4 05/12] sbitmap: export sbitmap_weight Ming Lei
2020-11-16  9:38   ` Hannes Reinecke
2020-11-17  2:10     ` Ming Lei
2020-11-17  6:57       ` Hannes Reinecke
2020-11-17  7:53         ` Ming Lei
2020-11-17  9:18   ` John Garry
2020-11-16  9:07 ` [PATCH V4 06/12] sbitmap: add helper of sbitmap_calculate_shift Ming Lei
2020-11-16  9:07 ` [PATCH V4 07/12] blk-mq: add callbacks for storing & retrieving budget token Ming Lei
2020-11-16  9:07 ` [PATCH V4 08/12] blk-mq: return budget token from .get_budget callback Ming Lei
2020-11-16  9:45   ` Hannes Reinecke
2020-11-16  9:07 ` [PATCH V4 09/12] scsi: put hot fields of scsi_host_template into one cacheline Ming Lei
2020-11-16  9:07 ` [PATCH V4 10/12] scsi: add scsi_device_busy() to read sdev->device_busy Ming Lei
2020-11-16  9:07 ` [PATCH V4 11/12] scsi: make sure sdev->queue_depth is <= max(shost->can_queue, 1024) Ming Lei
2020-11-16  9:44   ` Hannes Reinecke
2020-11-17  2:18     ` Ming Lei
2020-11-17 16:42       ` Hannes Reinecke
2020-11-16  9:07 ` [PATCH V4 12/12] scsi: replace sdev->device_busy with sbitmap Ming Lei
2020-11-16 11:49   ` kernel test robot
2020-11-16 11:49     ` kernel test robot
2020-11-18  2:35     ` Ming Lei [this message]
2020-11-18  2:35       ` Ming Lei
2020-11-18  7:15       ` Hannes Reinecke
2020-11-18  7:15         ` Hannes Reinecke
2020-11-18  7:44         ` Ming Lei
2020-11-18  7:44           ` Ming Lei
2020-11-18  9:15           ` Hannes Reinecke
2020-11-18  9:15             ` Hannes Reinecke
2020-11-19  6:30             ` Ming Lei
2020-11-19  6:30               ` Ming Lei
2020-11-19  6:29           ` Kashyap Desai
2020-11-19  6:29             ` Kashyap Desai
2020-11-19  6:20       ` Kashyap Desai
2020-11-19  6:20         ` Kashyap Desai
2020-11-19  6:34         ` Ming Lei
2020-11-19  6:34           ` Ming Lei
2020-11-19  7:09           ` Kashyap Desai
2020-11-19  7:09             ` Kashyap Desai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201118023507.GA92339@T590 \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=clang-built-linux@googlegroups.com \
    --cc=emilne@redhat.com \
    --cc=hare@suse.de \
    --cc=kashyap.desai@broadcom.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=martin.petersen@oracle.com \
    --cc=osandov@fb.com \
    --cc=sumanesh.samanta@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.