All of lore.kernel.org
 help / color / mirror / Atom feed
From: "hch@lst.de" <hch@lst.de>
To: "George, Martin" <Martin.George@netapp.com>
Cc: "kbusch@kernel.org" <kbusch@kernel.org>,
	"hch@lst.de" <hch@lst.de>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH] nvme-core: update NS Attr Changed AEN handling for ANA group
Date: Fri, 20 Nov 2020 10:44:32 +0100	[thread overview]
Message-ID: <20201120094432.GA25846@lst.de> (raw)
In-Reply-To: <7fd0b51f3b7bc73abf7132aaa5ee7c493a93aef0.camel@netapp.com>

On Wed, Nov 18, 2020 at 08:09:43PM +0000, George, Martin wrote:
> > How can the namespace reference an ANA group that we haven't been
> > notified about using the NVME_AEN_CFG_ANA_CHANGE AEN before?
> 
> Well, I think that could be possible for a newly created namespace,
> which happens to belong to a new ANA group. To quote the 1.4 spec in
> context of Asymmetric Namespace Access Change under the Asynchronous
> Event Information - Notice (Figure 147):
> 
> "A controller shall not send this event if:
> a) the change is due to the creation of a namespace (refer to section
> 5.20); or
> b) the change is due to the deletion of a namespace (refer to section
> 5.20),
> as the Namespace Attribute Changed event is sent for these changes."
> 
> So it looks the NVME_AEN_CFG_ANA_CHANGE AEN is not required here for
> such cases, but instead the NVME_AEN_CFG_NS_ATTR AEN would do.

For the newly created namespace to beong to a newly created ANA group
the controller first needs to send NVME_AEN_CFG_ANA_CHANGE to announce
the ANA group, it then send NVME_AEN_CFG_NS_ATTR to announce the
new namespaces.  But the new namespace can't reference an ANA group
that didn't exist, that is a separate event.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-11-20  9:44 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201118114859.7985-1-marting@netapp.com>
2020-11-18 16:24 ` [PATCH] nvme-core: update NS Attr Changed AEN handling for ANA group Christoph Hellwig
2020-11-18 20:09   ` George, Martin
2020-11-20  9:44     ` hch [this message]
2020-11-23 14:35       ` Meneghini, John
2020-11-23 15:27         ` Knight, Frederick
2020-11-23 15:54           ` Meneghini, John
2020-12-07 15:25           ` hch
2020-12-08 15:21             ` Knight, Frederick
2020-12-08 17:40               ` Keith Busch
2020-12-08 18:15                 ` Knight, Frederick
2020-12-08 18:34                   ` Keith Busch
2020-12-08 19:13                     ` Knight, Frederick
2020-12-08 21:46                       ` Keith Busch
2020-12-09  0:07                         ` Knight, Frederick
2020-12-09  0:20                           ` Keith Busch
2020-12-09  7:26                             ` Hannes Reinecke
2020-12-09  0:13                         ` Knight, Frederick
2020-12-09  7:28                           ` hch
2020-12-09 15:20                             ` Knight, Frederick
2020-12-09 15:53                               ` Keith Busch
2020-12-09 16:02                                 ` Hannes Reinecke
2020-12-09 16:19                                   ` Keith Busch
2020-12-09 17:04                                     ` Hannes Reinecke
2020-12-09 17:39                                       ` Keith Busch
2020-12-09 17:47                                         ` hch
2020-12-09 20:58                                           ` Knight, Frederick
2020-12-09 21:34                                             ` Keith Busch
2020-12-10  8:51                                               ` hch
2020-12-10  9:13                                                 ` Hannes Reinecke
2020-12-10 13:34                                                   ` Keith Busch
2021-01-14  3:09                                                     ` Sagi Grimberg
2021-01-14 22:59                                                       ` Knight, Frederick
2021-01-14 23:16                                                         ` Keith Busch
2021-01-15  7:15                                                         ` Hannes Reinecke
2020-11-23 17:36       ` Keith Busch
2020-11-23 19:16         ` Sagi Grimberg
2020-11-23 19:29           ` George, Martin
2020-11-23 19:43             ` Keith Busch
2020-11-26 16:16               ` George, Martin
2020-12-04 14:40                 ` Hannes Reinecke
2020-11-18 16:51 ` Sagi Grimberg
2020-11-18 20:16   ` George, Martin
2020-11-20  9:46   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201120094432.GA25846@lst.de \
    --to=hch@lst.de \
    --cc=Martin.George@netapp.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.