From: Kees Cook <keescook@chromium.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Nathan Chancellor <natechancellor@gmail.com>,
Michal Marek <michal.lkml@markovi.net>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, Nick Desaulniers <ndesaulniers@google.com>,
Arvind Sankar <nivedita@alum.mit.edu>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH v2 1/2] kbuild: Hoist '--orphan-handling' into Kconfig
Date: Fri, 20 Nov 2020 16:08:43 -0800 [thread overview]
Message-ID: <202011201607.75FA476@keescook> (raw)
In-Reply-To: <20201119204656.3261686-1-natechancellor@gmail.com>
On Thu, Nov 19, 2020 at 01:46:56PM -0700, Nathan Chancellor wrote:
> Currently, '--orphan-handling=warn' is spread out across four different
> architectures in their respective Makefiles, which makes it a little
> unruly to deal with in case it needs to be disabled for a specific
> linker version (in this case, ld.lld 10.0.1).
>
> To make it easier to control this, hoist this warning into Kconfig and
> the main Makefile so that disabling it is simpler, as the warning will
> only be enabled in a couple places (main Makefile and a couple of
> compressed boot folders that blow away LDFLAGS_vmlinx) and making it
> conditional is easier due to Kconfig syntax. One small additional
> benefit of this is saving a call to ld-option on incremental builds
> because we will have already evaluated it for CONFIG_LD_ORPHAN_WARN.
>
> To keep the list of supported architectures the same, introduce
> CONFIG_ARCH_WANT_LD_ORPHAN_WARN, which an architecture can select to
> gain this automatically after all of the sections are specified and size
> asserted. A special thanks to Kees Cook for the help text on this
> config.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1187
> Acked-by: Kees Cook <keescook@chromium.org>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> Tested-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Masahiro, do you want to take these to get them to Linus for v5.10? I
can send them if you'd prefer.
-Kees
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Michal Marek <michal.lkml@markovi.net>,
linux-kbuild@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
x86@kernel.org, Nick Desaulniers <ndesaulniers@google.com>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Arvind Sankar <nivedita@alum.mit.edu>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
clang-built-linux@googlegroups.com,
Nathan Chancellor <natechancellor@gmail.com>,
Will Deacon <will@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] kbuild: Hoist '--orphan-handling' into Kconfig
Date: Fri, 20 Nov 2020 16:08:43 -0800 [thread overview]
Message-ID: <202011201607.75FA476@keescook> (raw)
In-Reply-To: <20201119204656.3261686-1-natechancellor@gmail.com>
On Thu, Nov 19, 2020 at 01:46:56PM -0700, Nathan Chancellor wrote:
> Currently, '--orphan-handling=warn' is spread out across four different
> architectures in their respective Makefiles, which makes it a little
> unruly to deal with in case it needs to be disabled for a specific
> linker version (in this case, ld.lld 10.0.1).
>
> To make it easier to control this, hoist this warning into Kconfig and
> the main Makefile so that disabling it is simpler, as the warning will
> only be enabled in a couple places (main Makefile and a couple of
> compressed boot folders that blow away LDFLAGS_vmlinx) and making it
> conditional is easier due to Kconfig syntax. One small additional
> benefit of this is saving a call to ld-option on incremental builds
> because we will have already evaluated it for CONFIG_LD_ORPHAN_WARN.
>
> To keep the list of supported architectures the same, introduce
> CONFIG_ARCH_WANT_LD_ORPHAN_WARN, which an architecture can select to
> gain this automatically after all of the sections are specified and size
> asserted. A special thanks to Kees Cook for the help text on this
> config.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1187
> Acked-by: Kees Cook <keescook@chromium.org>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> Tested-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Masahiro, do you want to take these to get them to Linus for v5.10? I
can send them if you'd prefer.
-Kees
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Michal Marek <michal.lkml@markovi.net>,
linux-kbuild@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
x86@kernel.org, Nick Desaulniers <ndesaulniers@google.com>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Arvind Sankar <nivedita@alum.mit.edu>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
clang-built-linux@googlegroups.com,
Michael Ellerman <mpe@ellerman.id.au>,
Nathan Chancellor <natechancellor@gmail.com>,
Will Deacon <will@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] kbuild: Hoist '--orphan-handling' into Kconfig
Date: Fri, 20 Nov 2020 16:08:43 -0800 [thread overview]
Message-ID: <202011201607.75FA476@keescook> (raw)
In-Reply-To: <20201119204656.3261686-1-natechancellor@gmail.com>
On Thu, Nov 19, 2020 at 01:46:56PM -0700, Nathan Chancellor wrote:
> Currently, '--orphan-handling=warn' is spread out across four different
> architectures in their respective Makefiles, which makes it a little
> unruly to deal with in case it needs to be disabled for a specific
> linker version (in this case, ld.lld 10.0.1).
>
> To make it easier to control this, hoist this warning into Kconfig and
> the main Makefile so that disabling it is simpler, as the warning will
> only be enabled in a couple places (main Makefile and a couple of
> compressed boot folders that blow away LDFLAGS_vmlinx) and making it
> conditional is easier due to Kconfig syntax. One small additional
> benefit of this is saving a call to ld-option on incremental builds
> because we will have already evaluated it for CONFIG_LD_ORPHAN_WARN.
>
> To keep the list of supported architectures the same, introduce
> CONFIG_ARCH_WANT_LD_ORPHAN_WARN, which an architecture can select to
> gain this automatically after all of the sections are specified and size
> asserted. A special thanks to Kees Cook for the help text on this
> config.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1187
> Acked-by: Kees Cook <keescook@chromium.org>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> Tested-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Masahiro, do you want to take these to get them to Linus for v5.10? I
can send them if you'd prefer.
-Kees
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-21 0:08 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 19:55 [PATCH 1/2] kbuild: Hoist '--orphan-handling' into Kconfig Nathan Chancellor
2020-11-13 19:55 ` Nathan Chancellor
2020-11-13 19:55 ` Nathan Chancellor
2020-11-13 19:55 ` [PATCH 2/2] kbuild: Disable CONFIG_LD_ORPHAN_WARN for ld.lld 10.0.1 Nathan Chancellor
2020-11-13 19:55 ` Nathan Chancellor
2020-11-13 19:55 ` Nathan Chancellor
2020-11-17 19:41 ` Nick Desaulniers
2020-11-17 19:41 ` Nick Desaulniers
2020-11-17 19:41 ` Nick Desaulniers
2020-11-18 3:12 ` Nathan Chancellor
2020-11-18 3:12 ` Nathan Chancellor
2020-11-18 3:12 ` Nathan Chancellor
2020-11-17 21:51 ` Kees Cook
2020-11-17 21:51 ` Kees Cook
2020-11-17 21:51 ` Kees Cook
2020-11-18 3:12 ` Nathan Chancellor
2020-11-18 3:12 ` Nathan Chancellor
2020-11-18 3:12 ` Nathan Chancellor
2020-11-17 1:41 ` [PATCH 1/2] kbuild: Hoist '--orphan-handling' into Kconfig Nick Desaulniers
2020-11-17 1:41 ` Nick Desaulniers
2020-11-17 1:41 ` Nick Desaulniers
2020-11-17 1:54 ` Nathan Chancellor
2020-11-17 1:54 ` Nathan Chancellor
2020-11-17 1:54 ` Nathan Chancellor
2020-11-17 19:26 ` Nick Desaulniers
2020-11-17 19:26 ` Nick Desaulniers
2020-11-17 19:26 ` Nick Desaulniers
2020-11-17 11:03 ` Michael Ellerman
2020-11-17 11:03 ` Michael Ellerman
2020-11-17 11:03 ` Michael Ellerman
2020-11-17 16:22 ` Nathan Chancellor
2020-11-17 16:22 ` Nathan Chancellor
2020-11-17 16:22 ` Nathan Chancellor
2020-11-17 21:52 ` Kees Cook
2020-11-17 21:52 ` Kees Cook
2020-11-17 21:52 ` Kees Cook
2020-11-19 20:46 ` [PATCH v2 " Nathan Chancellor
2020-11-19 20:46 ` Nathan Chancellor
2020-11-19 20:46 ` Nathan Chancellor
2020-11-21 0:08 ` Kees Cook [this message]
2020-11-21 0:08 ` Kees Cook
2020-11-21 0:08 ` Kees Cook
2020-12-01 13:28 ` Masahiro Yamada
2020-12-01 13:28 ` Masahiro Yamada
2020-12-01 13:28 ` Masahiro Yamada
2020-11-19 20:46 ` [PATCH v2 2/2] kbuild: Disable CONFIG_LD_ORPHAN_WARN for ld.lld 10.0.1 Nathan Chancellor
2020-11-19 20:46 ` Nathan Chancellor
2020-11-19 20:46 ` Nathan Chancellor
2020-11-19 21:13 ` Nick Desaulniers
2020-11-19 21:13 ` Nick Desaulniers
2020-11-19 21:13 ` Nick Desaulniers
2020-11-24 22:22 ` Kees Cook
2020-11-24 22:22 ` Kees Cook
2020-11-24 22:22 ` Kees Cook
2020-12-01 13:31 ` Masahiro Yamada
2020-12-01 13:31 ` Masahiro Yamada
2020-12-01 13:31 ` Masahiro Yamada
2020-12-01 20:56 ` Kees Cook
2020-12-01 20:56 ` Kees Cook
2020-12-01 20:56 ` Kees Cook
2020-12-02 2:37 ` Masahiro Yamada
2020-12-02 2:37 ` Masahiro Yamada
2020-12-02 2:37 ` Masahiro Yamada
2020-12-02 18:56 ` Kees Cook
2020-12-02 18:56 ` Kees Cook
2020-12-02 18:56 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202011201607.75FA476@keescook \
--to=keescook@chromium.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=nivedita@alum.mit.edu \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.