From: Rob Herring <robh@kernel.org>
To: conor.dooley@microchip.com
Cc: devicetree@vger.kernel.org, aou@eecs.berkeley.edu,
lewis.hanly@microchip.com, david.abdurachmanov@gmail.com,
daire.mcnamara@microchip.com, anup.patel@wdc.com,
jassisinghbrar@gmail.com, atish.patra@wdc.com,
robh+dt@kernel.org, palmer@dabbelt.com, paul.walmsley@sifive.com,
cyril.jean@microchip.com, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 5/6] dt-bindings: add bindings for polarfire soc system controller
Date: Fri, 20 Nov 2020 14:53:37 -0600 [thread overview]
Message-ID: <20201120205337.GA1721508@robh.at.kernel.org> (raw)
In-Reply-To: <20201119170958.20984-1-conor.dooley@microchip.com>
On Thu, 19 Nov 2020 17:09:58 +0000, conor.dooley@microchip.com wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Add device tree bindings for the MSS system controller on
> the Microchip PolarFire SoC.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../microchip,mpfs_sys_controller.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/microchip/microchip,mpfs_sys_controller.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/soc/microchip/microchip,mpfs_sys_controller.yaml:23:111: [warning] line too long (113 > 110 characters) (line-length)
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/soc/microchip/microchip,mpfs_sys_controller.example.dts:19.32-25.11: Warning (unit_address_vs_reg): /example-0/syscontroller@37020000: node has a unit name, but no reg or ranges property
See https://patchwork.ozlabs.org/patch/1403156
The base for the patch is generally the last rc1. Any dependencies
should be noted.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: conor.dooley@microchip.com
Cc: linux-riscv@lists.infradead.org, aou@eecs.berkeley.edu,
devicetree@vger.kernel.org, david.abdurachmanov@gmail.com,
lewis.hanly@microchip.com, robh+dt@kernel.org,
cyril.jean@microchip.com, anup.patel@wdc.com,
jassisinghbrar@gmail.com, paul.walmsley@sifive.com,
daire.mcnamara@microchip.com, palmer@dabbelt.com,
atish.patra@wdc.com
Subject: Re: [PATCH 5/6] dt-bindings: add bindings for polarfire soc system controller
Date: Fri, 20 Nov 2020 14:53:37 -0600 [thread overview]
Message-ID: <20201120205337.GA1721508@robh.at.kernel.org> (raw)
In-Reply-To: <20201119170958.20984-1-conor.dooley@microchip.com>
On Thu, 19 Nov 2020 17:09:58 +0000, conor.dooley@microchip.com wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Add device tree bindings for the MSS system controller on
> the Microchip PolarFire SoC.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../microchip,mpfs_sys_controller.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/microchip/microchip,mpfs_sys_controller.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/soc/microchip/microchip,mpfs_sys_controller.yaml:23:111: [warning] line too long (113 > 110 characters) (line-length)
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/soc/microchip/microchip,mpfs_sys_controller.example.dts:19.32-25.11: Warning (unit_address_vs_reg): /example-0/syscontroller@37020000: node has a unit name, but no reg or ranges property
See https://patchwork.ozlabs.org/patch/1403156
The base for the patch is generally the last rc1. Any dependencies
should be noted.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2020-11-20 20:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 17:09 [PATCH 5/6] dt-bindings: add bindings for polarfire soc system controller conor.dooley
2020-11-19 17:09 ` conor.dooley
2020-11-20 20:53 ` Rob Herring [this message]
2020-11-20 20:53 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2020-11-19 17:04 conor.dooley
2020-11-19 17:04 ` conor.dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120205337.GA1721508@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=anup.patel@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=conor.dooley@microchip.com \
--cc=cyril.jean@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=david.abdurachmanov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=lewis.hanly@microchip.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.