* [PATCH] rtc: enable RTC framework on ARCH=um
@ 2020-11-20 20:11 ` Johannes Berg
0 siblings, 0 replies; 8+ messages in thread
From: Johannes Berg @ 2020-11-20 20:11 UTC (permalink / raw)
To: linux-rtc; +Cc: Alessandro Zummo, Alexandre Belloni, linux-um, Johannes Berg
From: Johannes Berg <johannes.berg@intel.com>
There's no real reason it should be disabled, and at least we can
use it for development & testing with the RTC test driver.
However, two devices are missing a HAS_IOMEM dependency, so add
that to avoid build failures from e.g. allyesconfig.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
Would there be objection to taking this through the linux-um tree?
I have a couple of patches that depend on it as well, to add
suspend/resume support with a pseudo-RTC to wake up from it.
---
drivers/rtc/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 48c536acd777..de187b563989 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -13,7 +13,7 @@ config RTC_MC146818_LIB
menuconfig RTC_CLASS
bool "Real Time Clock"
default n
- depends on !S390 && !UML
+ depends on !S390
select RTC_LIB
help
Generic RTC class support. If you say yes here, you will
@@ -1007,6 +1007,7 @@ config RTC_DRV_DS1553
config RTC_DRV_DS1685_FAMILY
tristate "Dallas/Maxim DS1685 Family"
+ depends on HAS_IOMEM
help
If you say yes here you get support for the Dallas/Maxim DS1685
family of real time chips. This family includes the DS1685/DS1687,
@@ -1140,6 +1141,7 @@ config RTC_DRV_STK17TA8
config RTC_DRV_M48T86
tristate "ST M48T86/Dallas DS12887"
+ depends on HAS_IOMEM
help
If you say Y here you will get support for the
ST M48T86 and Dallas DS12887 RTC chips.
--
2.26.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] rtc: enable RTC framework on ARCH=um
@ 2020-11-20 20:11 ` Johannes Berg
0 siblings, 0 replies; 8+ messages in thread
From: Johannes Berg @ 2020-11-20 20:11 UTC (permalink / raw)
To: linux-rtc; +Cc: Alessandro Zummo, Alexandre Belloni, linux-um, Johannes Berg
From: Johannes Berg <johannes.berg@intel.com>
There's no real reason it should be disabled, and at least we can
use it for development & testing with the RTC test driver.
However, two devices are missing a HAS_IOMEM dependency, so add
that to avoid build failures from e.g. allyesconfig.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
Would there be objection to taking this through the linux-um tree?
I have a couple of patches that depend on it as well, to add
suspend/resume support with a pseudo-RTC to wake up from it.
---
drivers/rtc/Kconfig | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 48c536acd777..de187b563989 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -13,7 +13,7 @@ config RTC_MC146818_LIB
menuconfig RTC_CLASS
bool "Real Time Clock"
default n
- depends on !S390 && !UML
+ depends on !S390
select RTC_LIB
help
Generic RTC class support. If you say yes here, you will
@@ -1007,6 +1007,7 @@ config RTC_DRV_DS1553
config RTC_DRV_DS1685_FAMILY
tristate "Dallas/Maxim DS1685 Family"
+ depends on HAS_IOMEM
help
If you say yes here you get support for the Dallas/Maxim DS1685
family of real time chips. This family includes the DS1685/DS1687,
@@ -1140,6 +1141,7 @@ config RTC_DRV_STK17TA8
config RTC_DRV_M48T86
tristate "ST M48T86/Dallas DS12887"
+ depends on HAS_IOMEM
help
If you say Y here you will get support for the
ST M48T86 and Dallas DS12887 RTC chips.
--
2.26.2
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] rtc: enable RTC framework on ARCH=um
2020-11-20 20:11 ` Johannes Berg
@ 2020-11-20 22:39 ` Alexandre Belloni
-1 siblings, 0 replies; 8+ messages in thread
From: Alexandre Belloni @ 2020-11-20 22:39 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-rtc, Alessandro Zummo, linux-um, Johannes Berg
On 20/11/2020 21:11:06+0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> There's no real reason it should be disabled, and at least we can
> use it for development & testing with the RTC test driver.
>
> However, two devices are missing a HAS_IOMEM dependency, so add
> that to avoid build failures from e.g. allyesconfig.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> Would there be objection to taking this through the linux-um tree?
> I have a couple of patches that depend on it as well, to add
> suspend/resume support with a pseudo-RTC to wake up from it.
I'm fine with that.
> ---
> drivers/rtc/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 48c536acd777..de187b563989 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -13,7 +13,7 @@ config RTC_MC146818_LIB
> menuconfig RTC_CLASS
> bool "Real Time Clock"
> default n
> - depends on !S390 && !UML
> + depends on !S390
> select RTC_LIB
> help
> Generic RTC class support. If you say yes here, you will
> @@ -1007,6 +1007,7 @@ config RTC_DRV_DS1553
>
> config RTC_DRV_DS1685_FAMILY
> tristate "Dallas/Maxim DS1685 Family"
> + depends on HAS_IOMEM
> help
> If you say yes here you get support for the Dallas/Maxim DS1685
> family of real time chips. This family includes the DS1685/DS1687,
> @@ -1140,6 +1141,7 @@ config RTC_DRV_STK17TA8
>
> config RTC_DRV_M48T86
> tristate "ST M48T86/Dallas DS12887"
> + depends on HAS_IOMEM
> help
> If you say Y here you will get support for the
> ST M48T86 and Dallas DS12887 RTC chips.
> --
> 2.26.2
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] rtc: enable RTC framework on ARCH=um
@ 2020-11-20 22:39 ` Alexandre Belloni
0 siblings, 0 replies; 8+ messages in thread
From: Alexandre Belloni @ 2020-11-20 22:39 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-rtc, Alessandro Zummo, linux-um, Johannes Berg
On 20/11/2020 21:11:06+0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> There's no real reason it should be disabled, and at least we can
> use it for development & testing with the RTC test driver.
>
> However, two devices are missing a HAS_IOMEM dependency, so add
> that to avoid build failures from e.g. allyesconfig.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> Would there be objection to taking this through the linux-um tree?
> I have a couple of patches that depend on it as well, to add
> suspend/resume support with a pseudo-RTC to wake up from it.
I'm fine with that.
> ---
> drivers/rtc/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 48c536acd777..de187b563989 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -13,7 +13,7 @@ config RTC_MC146818_LIB
> menuconfig RTC_CLASS
> bool "Real Time Clock"
> default n
> - depends on !S390 && !UML
> + depends on !S390
> select RTC_LIB
> help
> Generic RTC class support. If you say yes here, you will
> @@ -1007,6 +1007,7 @@ config RTC_DRV_DS1553
>
> config RTC_DRV_DS1685_FAMILY
> tristate "Dallas/Maxim DS1685 Family"
> + depends on HAS_IOMEM
> help
> If you say yes here you get support for the Dallas/Maxim DS1685
> family of real time chips. This family includes the DS1685/DS1687,
> @@ -1140,6 +1141,7 @@ config RTC_DRV_STK17TA8
>
> config RTC_DRV_M48T86
> tristate "ST M48T86/Dallas DS12887"
> + depends on HAS_IOMEM
> help
> If you say Y here you will get support for the
> ST M48T86 and Dallas DS12887 RTC chips.
> --
> 2.26.2
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] rtc: enable RTC framework on ARCH=um
2020-11-20 22:39 ` Alexandre Belloni
@ 2020-11-21 9:51 ` Johannes Berg
-1 siblings, 0 replies; 8+ messages in thread
From: Johannes Berg @ 2020-11-21 9:51 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: linux-rtc, Alessandro Zummo, linux-um
On Fri, 2020-11-20 at 23:39 +0100, Alexandre Belloni wrote:
> On 20/11/2020 21:11:06+0100, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > There's no real reason it should be disabled, and at least we can
> > use it for development & testing with the RTC test driver.
> >
> > However, two devices are missing a HAS_IOMEM dependency, so add
> > that to avoid build failures from e.g. allyesconfig.
> >
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
>
> > ---
> > Would there be objection to taking this through the linux-um tree?
> > I have a couple of patches that depend on it as well, to add
> > suspend/resume support with a pseudo-RTC to wake up from it.
>
> I'm fine with that.
Thanks. I think I spoke too quickly here though; I realize now that it's
probably better if you just merge it through whatever RTC tree you have.
Some of the code I was working on has "depends on RTC_CLASS", but then
it obviously doesn't matter what tree it goes through, it doesn't have
any conflicts, and things will just fall into place whenever all patches
are merged, regardless through which tree.
For my local experimentation etc. it doesn't matter, I can just carry
this.
I apologize for not thinking this through properly yesterday, but now
think it's better if it just goes through the normal route.
Thanks,
johannes
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] rtc: enable RTC framework on ARCH=um
@ 2020-11-21 9:51 ` Johannes Berg
0 siblings, 0 replies; 8+ messages in thread
From: Johannes Berg @ 2020-11-21 9:51 UTC (permalink / raw)
To: Alexandre Belloni; +Cc: linux-rtc, Alessandro Zummo, linux-um
On Fri, 2020-11-20 at 23:39 +0100, Alexandre Belloni wrote:
> On 20/11/2020 21:11:06+0100, Johannes Berg wrote:
> > From: Johannes Berg <johannes.berg@intel.com>
> >
> > There's no real reason it should be disabled, and at least we can
> > use it for development & testing with the RTC test driver.
> >
> > However, two devices are missing a HAS_IOMEM dependency, so add
> > that to avoid build failures from e.g. allyesconfig.
> >
> > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
>
> > ---
> > Would there be objection to taking this through the linux-um tree?
> > I have a couple of patches that depend on it as well, to add
> > suspend/resume support with a pseudo-RTC to wake up from it.
>
> I'm fine with that.
Thanks. I think I spoke too quickly here though; I realize now that it's
probably better if you just merge it through whatever RTC tree you have.
Some of the code I was working on has "depends on RTC_CLASS", but then
it obviously doesn't matter what tree it goes through, it doesn't have
any conflicts, and things will just fall into place whenever all patches
are merged, regardless through which tree.
For my local experimentation etc. it doesn't matter, I can just carry
this.
I apologize for not thinking this through properly yesterday, but now
think it's better if it just goes through the normal route.
Thanks,
johannes
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] rtc: enable RTC framework on ARCH=um
2020-11-20 20:11 ` Johannes Berg
@ 2020-12-03 22:41 ` Alexandre Belloni
-1 siblings, 0 replies; 8+ messages in thread
From: Alexandre Belloni @ 2020-12-03 22:41 UTC (permalink / raw)
To: Johannes Berg, linux-rtc
Cc: Alexandre Belloni, Alessandro Zummo, Johannes Berg, linux-um
On Fri, 20 Nov 2020 21:11:06 +0100, Johannes Berg wrote:
> There's no real reason it should be disabled, and at least we can
> use it for development & testing with the RTC test driver.
>
> However, two devices are missing a HAS_IOMEM dependency, so add
> that to avoid build failures from e.g. allyesconfig.
Applied, thanks!
[1/1] rtc: enable RTC framework on ARCH=um
commit: 9c7957991e56291c59803cf0412127ae7177beac
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] rtc: enable RTC framework on ARCH=um
@ 2020-12-03 22:41 ` Alexandre Belloni
0 siblings, 0 replies; 8+ messages in thread
From: Alexandre Belloni @ 2020-12-03 22:41 UTC (permalink / raw)
To: Johannes Berg, linux-rtc
Cc: Alessandro Zummo, Alexandre Belloni, linux-um, Johannes Berg
On Fri, 20 Nov 2020 21:11:06 +0100, Johannes Berg wrote:
> There's no real reason it should be disabled, and at least we can
> use it for development & testing with the RTC test driver.
>
> However, two devices are missing a HAS_IOMEM dependency, so add
> that to avoid build failures from e.g. allyesconfig.
Applied, thanks!
[1/1] rtc: enable RTC framework on ARCH=um
commit: 9c7957991e56291c59803cf0412127ae7177beac
Best regards,
--
Alexandre Belloni <alexandre.belloni@bootlin.com>
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-12-03 22:42 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-20 20:11 [PATCH] rtc: enable RTC framework on ARCH=um Johannes Berg
2020-11-20 20:11 ` Johannes Berg
2020-11-20 22:39 ` Alexandre Belloni
2020-11-20 22:39 ` Alexandre Belloni
2020-11-21 9:51 ` Johannes Berg
2020-11-21 9:51 ` Johannes Berg
2020-12-03 22:41 ` Alexandre Belloni
2020-12-03 22:41 ` Alexandre Belloni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.