All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: James Smart <james.smart@broadcom.com>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	linux-scsi@vger.kernel.org,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Dick Kennedy <dick.kennedy@broadcom.com>
Subject: [scsi:misc 126/138] drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: no previous prototype for function 'lpfc_nvmet_prep_abort_wqe'
Date: Sun, 22 Nov 2020 02:44:12 +0800	[thread overview]
Message-ID: <202011220208.c1BSntJB-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3579 bytes --]

Hi James,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc
head:   cf4d4d8ebdb838ee996e09e3ee18deb9a7737dea
commit: db7531d2b3775c662466e4eeda774986472c6d18 [126/138] scsi: lpfc: Convert abort handling to SLI-3 and SLI-4 handlers
config: powerpc64-randconfig-r032-20201121 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bec968cbb367dd03439c89c1d4ef968ef662d7c0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc64 cross compiling tool for clang build
        # apt-get install binutils-powerpc64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git/commit/?id=db7531d2b3775c662466e4eeda774986472c6d18
        git remote add scsi https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git
        git fetch --no-tags scsi misc
        git checkout db7531d2b3775c662466e4eeda774986472c6d18
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: no previous prototype for function 'lpfc_nvmet_prep_abort_wqe' [-Wmissing-prototypes]
   lpfc_nvmet_prep_abort_wqe(struct lpfc_iocbq *pwqeq, u16 xritag, u8 opt)
   ^
   drivers/scsi/lpfc/lpfc_nvmet.c:3339:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void
   ^
   static 
   1 warning generated.

vim +/lpfc_nvmet_prep_abort_wqe +3340 drivers/scsi/lpfc/lpfc_nvmet.c

  3329	
  3330	/**
  3331	 * lpfc_nvmet_prep_abort_wqe - set up 'abort' work queue entry.
  3332	 * @pwqeq: Pointer to command iocb.
  3333	 * @xritag: Tag that  uniqely identifies the local exchange resource.
  3334	 * @opt: Option bits -
  3335	 *		bit 0 = inhibit sending abts on the link
  3336	 *
  3337	 * This function is called with hbalock held.
  3338	 **/
  3339	void
> 3340	lpfc_nvmet_prep_abort_wqe(struct lpfc_iocbq *pwqeq, u16 xritag, u8 opt)
  3341	{
  3342		union lpfc_wqe128 *wqe = &pwqeq->wqe;
  3343	
  3344		/* WQEs are reused.  Clear stale data and set key fields to
  3345		 * zero like ia, iaab, iaar, xri_tag, and ctxt_tag.
  3346		 */
  3347		memset(wqe, 0, sizeof(*wqe));
  3348	
  3349		if (opt & INHIBIT_ABORT)
  3350			bf_set(abort_cmd_ia, &wqe->abort_cmd, 1);
  3351		/* Abort specified xri tag, with the mask deliberately zeroed */
  3352		bf_set(abort_cmd_criteria, &wqe->abort_cmd, T_XRI_TAG);
  3353	
  3354		bf_set(wqe_cmnd, &wqe->abort_cmd.wqe_com, CMD_ABORT_XRI_CX);
  3355	
  3356		/* Abort the I/O associated with this outstanding exchange ID. */
  3357		wqe->abort_cmd.wqe_com.abort_tag = xritag;
  3358	
  3359		/* iotag for the wqe completion. */
  3360		bf_set(wqe_reqtag, &wqe->abort_cmd.wqe_com, pwqeq->iotag);
  3361	
  3362		bf_set(wqe_qosd, &wqe->abort_cmd.wqe_com, 1);
  3363		bf_set(wqe_lenloc, &wqe->abort_cmd.wqe_com, LPFC_WQE_LENLOC_NONE);
  3364	
  3365		bf_set(wqe_cmd_type, &wqe->abort_cmd.wqe_com, OTHER_COMMAND);
  3366		bf_set(wqe_wqec, &wqe->abort_cmd.wqe_com, 1);
  3367		bf_set(wqe_cqid, &wqe->abort_cmd.wqe_com, LPFC_WQE_CQ_ID_DEFAULT);
  3368	}
  3369	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36986 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [scsi:misc 126/138] drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: no previous prototype for function 'lpfc_nvmet_prep_abort_wqe'
Date: Sun, 22 Nov 2020 02:44:12 +0800	[thread overview]
Message-ID: <202011220208.c1BSntJB-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 3663 bytes --]

Hi James,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc
head:   cf4d4d8ebdb838ee996e09e3ee18deb9a7737dea
commit: db7531d2b3775c662466e4eeda774986472c6d18 [126/138] scsi: lpfc: Convert abort handling to SLI-3 and SLI-4 handlers
config: powerpc64-randconfig-r032-20201121 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bec968cbb367dd03439c89c1d4ef968ef662d7c0)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc64 cross compiling tool for clang build
        # apt-get install binutils-powerpc64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git/commit/?id=db7531d2b3775c662466e4eeda774986472c6d18
        git remote add scsi https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git
        git fetch --no-tags scsi misc
        git checkout db7531d2b3775c662466e4eeda774986472c6d18
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: no previous prototype for function 'lpfc_nvmet_prep_abort_wqe' [-Wmissing-prototypes]
   lpfc_nvmet_prep_abort_wqe(struct lpfc_iocbq *pwqeq, u16 xritag, u8 opt)
   ^
   drivers/scsi/lpfc/lpfc_nvmet.c:3339:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void
   ^
   static 
   1 warning generated.

vim +/lpfc_nvmet_prep_abort_wqe +3340 drivers/scsi/lpfc/lpfc_nvmet.c

  3329	
  3330	/**
  3331	 * lpfc_nvmet_prep_abort_wqe - set up 'abort' work queue entry.
  3332	 * @pwqeq: Pointer to command iocb.
  3333	 * @xritag: Tag that  uniqely identifies the local exchange resource.
  3334	 * @opt: Option bits -
  3335	 *		bit 0 = inhibit sending abts on the link
  3336	 *
  3337	 * This function is called with hbalock held.
  3338	 **/
  3339	void
> 3340	lpfc_nvmet_prep_abort_wqe(struct lpfc_iocbq *pwqeq, u16 xritag, u8 opt)
  3341	{
  3342		union lpfc_wqe128 *wqe = &pwqeq->wqe;
  3343	
  3344		/* WQEs are reused.  Clear stale data and set key fields to
  3345		 * zero like ia, iaab, iaar, xri_tag, and ctxt_tag.
  3346		 */
  3347		memset(wqe, 0, sizeof(*wqe));
  3348	
  3349		if (opt & INHIBIT_ABORT)
  3350			bf_set(abort_cmd_ia, &wqe->abort_cmd, 1);
  3351		/* Abort specified xri tag, with the mask deliberately zeroed */
  3352		bf_set(abort_cmd_criteria, &wqe->abort_cmd, T_XRI_TAG);
  3353	
  3354		bf_set(wqe_cmnd, &wqe->abort_cmd.wqe_com, CMD_ABORT_XRI_CX);
  3355	
  3356		/* Abort the I/O associated with this outstanding exchange ID. */
  3357		wqe->abort_cmd.wqe_com.abort_tag = xritag;
  3358	
  3359		/* iotag for the wqe completion. */
  3360		bf_set(wqe_reqtag, &wqe->abort_cmd.wqe_com, pwqeq->iotag);
  3361	
  3362		bf_set(wqe_qosd, &wqe->abort_cmd.wqe_com, 1);
  3363		bf_set(wqe_lenloc, &wqe->abort_cmd.wqe_com, LPFC_WQE_LENLOC_NONE);
  3364	
  3365		bf_set(wqe_cmd_type, &wqe->abort_cmd.wqe_com, OTHER_COMMAND);
  3366		bf_set(wqe_wqec, &wqe->abort_cmd.wqe_com, 1);
  3367		bf_set(wqe_cqid, &wqe->abort_cmd.wqe_com, LPFC_WQE_CQ_ID_DEFAULT);
  3368	}
  3369	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36986 bytes --]

             reply	other threads:[~2020-11-21 18:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-21 18:44 kernel test robot [this message]
2020-11-21 18:44 ` [scsi:misc 126/138] drivers/scsi/lpfc/lpfc_nvmet.c:3340:1: warning: no previous prototype for function 'lpfc_nvmet_prep_abort_wqe' kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202011220208.c1BSntJB-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=dick.kennedy@broadcom.com \
    --cc=james.smart@broadcom.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.