All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: 廖威雄 <gmpy.liaowx@gmail.com>
Cc: Tony Luck <tony.luck@intel.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	linux-kernel@vger.kernel.org,
	WeiXiong Liao <liaoweixiong@allwinnertech.com>,
	linux-mtd@lists.infradead.org, Colin Cross <ccross@android.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 8/9] pstore/blk: use the normal block device I/O path
Date: Mon, 23 Nov 2020 15:49:14 +0100	[thread overview]
Message-ID: <20201123144914.GA667@lst.de> (raw)
In-Reply-To: <CAL3PxMpk_HV40EozhWMDZgc85vvLvosJ-e9CKWyZ+tRBB27hDA@mail.gmail.com>

On Sun, Nov 08, 2020 at 10:43:29PM +0800, 廖威雄 wrote:
> > +       const char devname[] = "/dev/pstore-blk";
> > +       dev_t dev = name_to_dev_t(blkdev);
> > +
> > +       if (!dev)
> > +               return;
> > +       init_unlink(devname);
> > +       init_mknod(devname, S_IFBLK | 0600, new_encode_dev(dev));
> > +       __pstore_blk_init(devname);
> 
> How about pstore/blk making /dev/pstore-blk node no matter build-in
> or module. Then pstore/blk always opens /dev/pstore-blk. By this way,
> blkdev can also be a device number if pstore/blk built as a module.

Please read the comment above blkdev_get_by_dev on why no one should
add new interfaces based on the device number.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: 廖威雄 <gmpy.liaowx@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	WeiXiong Liao <liaoweixiong@allwinnertech.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/9] pstore/blk: use the normal block device I/O path
Date: Mon, 23 Nov 2020 15:49:14 +0100	[thread overview]
Message-ID: <20201123144914.GA667@lst.de> (raw)
In-Reply-To: <CAL3PxMpk_HV40EozhWMDZgc85vvLvosJ-e9CKWyZ+tRBB27hDA@mail.gmail.com>

On Sun, Nov 08, 2020 at 10:43:29PM +0800, 廖威雄 wrote:
> > +       const char devname[] = "/dev/pstore-blk";
> > +       dev_t dev = name_to_dev_t(blkdev);
> > +
> > +       if (!dev)
> > +               return;
> > +       init_unlink(devname);
> > +       init_mknod(devname, S_IFBLK | 0600, new_encode_dev(dev));
> > +       __pstore_blk_init(devname);
> 
> How about pstore/blk making /dev/pstore-blk node no matter build-in
> or module. Then pstore/blk always opens /dev/pstore-blk. By this way,
> blkdev can also be a device number if pstore/blk built as a module.

Please read the comment above blkdev_get_by_dev on why no one should
add new interfaces based on the device number.

  reply	other threads:[~2020-11-23 14:49 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16 13:20 simplify pstore-blk Christoph Hellwig
2020-10-16 13:20 ` Christoph Hellwig
2020-10-16 13:20 ` [PATCH 1/9] pstore/zone: cap the maximum device size Christoph Hellwig
2020-10-16 13:20   ` Christoph Hellwig
2020-11-08 14:05   ` 廖威雄
2020-11-08 14:05     ` 廖威雄
2020-12-01 19:08   ` Kees Cook
2020-12-01 19:08     ` Kees Cook
2020-12-01 21:11   ` Kees Cook
2020-12-01 21:11     ` Kees Cook
2020-10-16 13:20 ` [PATCH 2/9] pstore/blk: update the command line example Christoph Hellwig
2020-10-16 13:20   ` Christoph Hellwig
2020-11-08 14:05   ` 廖威雄
2020-11-08 14:05     ` 廖威雄
2020-12-01 19:10   ` Kees Cook
2020-12-01 19:10     ` Kees Cook
2020-10-16 13:20 ` [PATCH 3/9] pstore/blk: remove {un,}register_pstore_blk Christoph Hellwig
2020-10-16 13:20   ` Christoph Hellwig
2020-12-01 19:29   ` Kees Cook
2020-12-01 19:29     ` Kees Cook
2020-10-16 13:20 ` [PATCH 4/9] pstore/blk: remove __unregister_pstore_blk Christoph Hellwig
2020-10-16 13:20   ` Christoph Hellwig
2020-12-01 19:20   ` Kees Cook
2020-12-01 19:20     ` Kees Cook
2020-10-16 13:20 ` [PATCH 5/9] pstore/blk: simplify the block device open / close path Christoph Hellwig
2020-10-16 13:20   ` Christoph Hellwig
2020-12-01 19:40   ` Kees Cook
2020-12-01 19:40     ` Kees Cook
2020-10-16 13:20 ` [PATCH 6/9] pstore/zone: split struct pstore_zone_info Christoph Hellwig
2020-10-16 13:20   ` Christoph Hellwig
2020-12-01 19:42   ` Kees Cook
2020-12-01 19:42     ` Kees Cook
2020-10-16 13:20 ` [PATCH 7/9] pstore/blk: remove struct pstore_device_info Christoph Hellwig
2020-10-16 13:20   ` Christoph Hellwig
2020-12-01 19:44   ` Kees Cook
2020-12-01 19:44     ` Kees Cook
2020-10-16 13:20 ` [PATCH 8/9] pstore/blk: use the normal block device I/O path Christoph Hellwig
2020-10-16 13:20   ` Christoph Hellwig
2020-11-08 14:43   ` 廖威雄
2020-11-08 14:43     ` 廖威雄
2020-11-23 14:49     ` Christoph Hellwig [this message]
2020-11-23 14:49       ` Christoph Hellwig
2020-12-01 19:52   ` Kees Cook
2020-12-01 19:52     ` Kees Cook
2020-10-16 13:20 ` [PATCH 9/9] pstore/blk: don't depend on CONFIG_BLOCK Christoph Hellwig
2020-10-16 13:20   ` Christoph Hellwig
2020-10-16 19:36   ` kernel test robot
2020-12-01 19:53   ` Kees Cook
2020-12-01 19:53     ` Kees Cook
2020-10-16 22:54 ` simplify pstore-blk Kees Cook
2020-10-16 22:54   ` Kees Cook
2020-11-23 14:53   ` Christoph Hellwig
2020-11-23 14:53     ` Christoph Hellwig
2020-11-24 22:53     ` Kees Cook
2020-11-24 22:53       ` Kees Cook
2020-11-08 14:34 ` 廖威雄
2020-11-08 14:34   ` 廖威雄

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201123144914.GA667@lst.de \
    --to=hch@lst.de \
    --cc=anton@enomsg.org \
    --cc=ccross@android.com \
    --cc=gmpy.liaowx@gmail.com \
    --cc=keescook@chromium.org \
    --cc=liaoweixiong@allwinnertech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.