From: krzk@kernel.org
To: linux-nfc@lists.01.org
Subject: [linux-nfc] Re: [PATCH net-next 1/2] dt-bindings: net: nfc: s3fwrn5: Support a UART interface
Date: Tue, 24 Nov 2020 12:41:51 +0100 [thread overview]
Message-ID: <20201124114151.GA32873@kozik-lap> (raw)
In-Reply-To: CACwDmQBh77pqivk=bBv3SJ14HLucY42jZyEaKAX+n=yS3TSqFw@mail.gmail.com
[-- Attachment #1: Type: text/plain, Size: 945 bytes --]
On Tue, Nov 24, 2020@08:39:40PM +0900, Bongsu Jeon wrote:
> On Mon, Nov 23, 2020@5:02 PM krzk@kernel.org <krzk@kernel.org> wrote:
> >
> > On Mon, Nov 23, 2020@04:55:26PM +0900, Bongsu Jeon wrote:
> > examples:
> > > - |
> > > #include <dt-bindings/gpio/gpio.h>
> > > @@ -71,3 +81,17 @@ examples:
> > > wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
> > > };
> > > };
> > > + # UART example on Raspberry Pi
> > > + - |
> > > + &uart0 {
> > > + status = "okay";
> > > +
> > > + s3fwrn82_uart {
> >
> > Just "bluetooth" to follow Devicetree specification.
> Sorry. I don't understand this comment.
> Could you explain it?
> Does it mean i need to refer to the net/broadcom-bluetooth.txt?
The node name should be "bluetooth", not "s3fwrn82_uart", because of
Devicetree naming convention - node names should represent generic class
of a device.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: krzk@kernel.org
To: linux-nfc@lists.01.org
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: nfc: s3fwrn5: Support a UART interface
Date: Tue, 24 Nov 2020 12:41:51 +0100 [thread overview]
Message-ID: <20201124114151.GA32873@kozik-lap> (raw)
In-Reply-To: <CACwDmQBh77pqivk=bBv3SJ14HLucY42jZyEaKAX+n=yS3TSqFw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
On Tue, Nov 24, 2020 at 08:39:40PM +0900, Bongsu Jeon wrote:
> On Mon, Nov 23, 2020 at 5:02 PM krzk(a)kernel.org <krzk@kernel.org> wrote:
> >
> > On Mon, Nov 23, 2020 at 04:55:26PM +0900, Bongsu Jeon wrote:
> > examples:
> > > - |
> > > #include <dt-bindings/gpio/gpio.h>
> > > @@ -71,3 +81,17 @@ examples:
> > > wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
> > > };
> > > };
> > > + # UART example on Raspberry Pi
> > > + - |
> > > + &uart0 {
> > > + status = "okay";
> > > +
> > > + s3fwrn82_uart {
> >
> > Just "bluetooth" to follow Devicetree specification.
> Sorry. I don't understand this comment.
> Could you explain it?
> Does it mean i need to refer to the net/broadcom-bluetooth.txt?
The node name should be "bluetooth", not "s3fwrn82_uart", because of
Devicetree naming convention - node names should represent generic class
of a device.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: "krzk@kernel.org" <krzk@kernel.org>
To: Bongsu Jeon <bongsu.jeon2@gmail.com>
Cc: Bongsu Jeon <bongsu.jeon@samsung.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"linux-nfc@lists.01.org" <linux-nfc@lists.01.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: nfc: s3fwrn5: Support a UART interface
Date: Tue, 24 Nov 2020 12:41:51 +0100 [thread overview]
Message-ID: <20201124114151.GA32873@kozik-lap> (raw)
In-Reply-To: <CACwDmQBh77pqivk=bBv3SJ14HLucY42jZyEaKAX+n=yS3TSqFw@mail.gmail.com>
On Tue, Nov 24, 2020 at 08:39:40PM +0900, Bongsu Jeon wrote:
> On Mon, Nov 23, 2020 at 5:02 PM krzk@kernel.org <krzk@kernel.org> wrote:
> >
> > On Mon, Nov 23, 2020 at 04:55:26PM +0900, Bongsu Jeon wrote:
> > examples:
> > > - |
> > > #include <dt-bindings/gpio/gpio.h>
> > > @@ -71,3 +81,17 @@ examples:
> > > wake-gpios = <&gpj0 2 GPIO_ACTIVE_HIGH>;
> > > };
> > > };
> > > + # UART example on Raspberry Pi
> > > + - |
> > > + &uart0 {
> > > + status = "okay";
> > > +
> > > + s3fwrn82_uart {
> >
> > Just "bluetooth" to follow Devicetree specification.
> Sorry. I don't understand this comment.
> Could you explain it?
> Does it mean i need to refer to the net/broadcom-bluetooth.txt?
The node name should be "bluetooth", not "s3fwrn82_uart", because of
Devicetree naming convention - node names should represent generic class
of a device.
Best regards,
Krzysztof
next reply other threads:[~2020-11-24 11:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 11:41 krzk [this message]
2020-11-24 11:41 ` [PATCH net-next 1/2] dt-bindings: net: nfc: s3fwrn5: Support a UART interface krzk
2020-11-24 11:41 ` krzk
-- strict thread matches above, loose matches on Subject: below --
2020-11-25 7:37 [linux-nfc] " Krzysztof Kozlowski
2020-11-25 7:37 ` Krzysztof Kozlowski
2020-11-25 7:37 ` Krzysztof Kozlowski
2020-11-25 3:08 [linux-nfc] " Bongsu Jeon
2020-11-25 3:08 ` Bongsu Jeon
2020-11-25 3:08 ` Bongsu Jeon
2020-11-24 11:39 [linux-nfc] " Bongsu Jeon
2020-11-24 11:39 ` Bongsu Jeon
2020-11-24 11:39 ` Bongsu Jeon
2020-11-23 8:01 [linux-nfc] " krzk
2020-11-23 8:01 ` krzk
2020-11-23 8:01 ` krzk
2020-11-23 7:55 [linux-nfc] " Bongsu Jeon
2020-11-23 7:55 ` Bongsu Jeon
2020-11-23 7:55 ` Bongsu Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124114151.GA32873@kozik-lap \
--to=krzk@kernel.org \
--cc=linux-nfc@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.