* [PATCH] Create.c: close mdfd and generate uevent
@ 2020-11-24 12:39 Mariusz Tkaczyk
2020-11-25 23:06 ` Jes Sorensen
0 siblings, 1 reply; 2+ messages in thread
From: Mariusz Tkaczyk @ 2020-11-24 12:39 UTC (permalink / raw)
To: jes; +Cc: linux-raid
During mdfd closing change event is not generated because open() is
called before start watching mddevice by udev.
Device is ready at this stage. Unblock device, close fd and
generate event to give a chance next layers to work.
Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
---
Create.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/Create.c b/Create.c
index 0efa19c..51f8826 100644
--- a/Create.c
+++ b/Create.c
@@ -1083,12 +1083,9 @@ int Create(struct supertype *st, char *mddev,
} else {
pr_err("not starting array - not enough devices.\n");
}
- close(mdfd);
- /* Give udev a moment to process the Change event caused
- * by the close.
- */
- usleep(100*1000);
udev_unblock();
+ close(mdfd);
+ sysfs_uevent(&info, "change");
return 0;
abort:
--
2.25.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Create.c: close mdfd and generate uevent
2020-11-24 12:39 [PATCH] Create.c: close mdfd and generate uevent Mariusz Tkaczyk
@ 2020-11-25 23:06 ` Jes Sorensen
0 siblings, 0 replies; 2+ messages in thread
From: Jes Sorensen @ 2020-11-25 23:06 UTC (permalink / raw)
To: Mariusz Tkaczyk; +Cc: linux-raid
On 11/24/20 7:39 AM, Mariusz Tkaczyk wrote:
> During mdfd closing change event is not generated because open() is
> called before start watching mddevice by udev.
> Device is ready at this stage. Unblock device, close fd and
> generate event to give a chance next layers to work.
>
> Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
> ---
> Create.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
Applied!
Thanks,
Jes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-25 23:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-24 12:39 [PATCH] Create.c: close mdfd and generate uevent Mariusz Tkaczyk
2020-11-25 23:06 ` Jes Sorensen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.