* Re: [peterz-queue:sched/core-sched 4/12] kernel/sched/core.c:123:6: warning: no previous prototype for 'sched_core_get'
[not found] <202011250343.EPLZDqfG-lkp@intel.com>
@ 2020-11-24 20:43 ` Joel Fernandes
2020-11-24 20:52 ` Joel Fernandes
0 siblings, 1 reply; 4+ messages in thread
From: Joel Fernandes @ 2020-11-24 20:43 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2103 bytes --]
On Wed, Nov 25, 2020 at 03:22:48AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core-sched
> head: 7b55b5ef19fbadf111b8d60d320437bfc0467a79
> commit: 636f9841873bff3684ee81155804b796d58408a4 [4/12] sched: Core-wide rq->lock
> config: powerpc-allyesconfig (attached as .config)
> compiler: powerpc64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?id=636f9841873bff3684ee81155804b796d58408a4
> git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
> git fetch --no-tags peterz-queue sched/core-sched
> git checkout 636f9841873bff3684ee81155804b796d58408a4
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> kernel/sched/core.c:123:6: warning: no previous prototype for 'sched_core_get' [-Wmissing-prototypes]
> 123 | void sched_core_get(void)
> | ^~~~~~~~~~~~~~
> >> kernel/sched/core.c:131:6: warning: no previous prototype for 'sched_core_put' [-Wmissing-prototypes]
> 131 | void sched_core_put(void)
> | ^~~~~~~~~~~~~~
> kernel/sched/core.c:2900:6: warning: no previous prototype for 'sched_set_stop_task' [-Wmissing-prototypes]
> 2900 | void sched_set_stop_task(int cpu, struct task_struct *stop)
> | ^~~~~~~~~~~~~~~~~~~
At least this sched_set_stop_task one is not a recently introduced warning.
This prototype warning does seem bogus though. Do we fix it? Obvious quick
fix is the declar sched_core_{get,put}() in sched.h to pacify the compiler.
thanks,
- Joel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [peterz-queue:sched/core-sched 4/12] kernel/sched/core.c:123:6: warning: no previous prototype for 'sched_core_get'
2020-11-24 20:43 ` [peterz-queue:sched/core-sched 4/12] kernel/sched/core.c:123:6: warning: no previous prototype for 'sched_core_get' Joel Fernandes
@ 2020-11-24 20:52 ` Joel Fernandes
0 siblings, 0 replies; 4+ messages in thread
From: Joel Fernandes @ 2020-11-24 20:52 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2569 bytes --]
On Tue, Nov 24, 2020 at 03:43:02PM -0500, Joel Fernandes wrote:
> On Wed, Nov 25, 2020 at 03:22:48AM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core-sched
> > head: 7b55b5ef19fbadf111b8d60d320437bfc0467a79
> > commit: 636f9841873bff3684ee81155804b796d58408a4 [4/12] sched: Core-wide rq->lock
> > config: powerpc-allyesconfig (attached as .config)
> > compiler: powerpc64-linux-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?id=636f9841873bff3684ee81155804b796d58408a4
> > git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
> > git fetch --no-tags peterz-queue sched/core-sched
> > git checkout 636f9841873bff3684ee81155804b796d58408a4
> > # save the attached .config to linux build tree
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> kernel/sched/core.c:123:6: warning: no previous prototype for 'sched_core_get' [-Wmissing-prototypes]
> > 123 | void sched_core_get(void)
> > | ^~~~~~~~~~~~~~
> > >> kernel/sched/core.c:131:6: warning: no previous prototype for 'sched_core_put' [-Wmissing-prototypes]
> > 131 | void sched_core_put(void)
> > | ^~~~~~~~~~~~~~
> > kernel/sched/core.c:2900:6: warning: no previous prototype for 'sched_set_stop_task' [-Wmissing-prototypes]
> > 2900 | void sched_set_stop_task(int cpu, struct task_struct *stop)
> > | ^~~~~~~~~~~~~~~~~~~
>
> At least this sched_set_stop_task one is not a recently introduced warning.
>
> This prototype warning does seem bogus though. Do we fix it? Obvious quick
> fix is the declar sched_core_{get,put}() in sched.h to pacify the compiler.
BTW, I did add it to my tree already in:
93de21e503a3 ("sched: Move core-scheduler interfacing code to a new file")
https://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git/log/?h=coresched
Until the interface patches are in, we could define sched_core_get/put with
"__maybe_unused static" to silence the warnings.
thanks,
- Joel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [peterz-queue:sched/core-sched 4/12] kernel/sched/core.c:123:6: warning: no previous prototype for 'sched_core_get'
@ 2020-11-26 20:29 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2020-11-26 20:29 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2537 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core-sched
head: e89398c9ec3b7332dff54f4a6af649372a8f3469
commit: 7161b01c130dd94a47b77edb340ca36f104a0853 [4/12] sched: Core-wide rq->lock
config: ia64-randconfig-r001-20201127 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?id=7161b01c130dd94a47b77edb340ca36f104a0853
git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
git fetch --no-tags peterz-queue sched/core-sched
git checkout 7161b01c130dd94a47b77edb340ca36f104a0853
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> kernel/sched/core.c:123:6: warning: no previous prototype for 'sched_core_get' [-Wmissing-prototypes]
123 | void sched_core_get(void)
| ^~~~~~~~~~~~~~
>> kernel/sched/core.c:131:6: warning: no previous prototype for 'sched_core_put' [-Wmissing-prototypes]
131 | void sched_core_put(void)
| ^~~~~~~~~~~~~~
kernel/sched/core.c:2892:6: warning: no previous prototype for 'sched_set_stop_task' [-Wmissing-prototypes]
2892 | void sched_set_stop_task(int cpu, struct task_struct *stop)
| ^~~~~~~~~~~~~~~~~~~
kernel/sched/core.c: In function 'schedule_tail':
kernel/sched/core.c:4286:13: warning: variable 'rq' set but not used [-Wunused-but-set-variable]
4286 | struct rq *rq;
| ^~
vim +/sched_core_get +123 kernel/sched/core.c
122
> 123 void sched_core_get(void)
124 {
125 mutex_lock(&sched_core_mutex);
126 if (!sched_core_count++)
127 __sched_core_enable();
128 mutex_unlock(&sched_core_mutex);
129 }
130
> 131 void sched_core_put(void)
132 {
133 mutex_lock(&sched_core_mutex);
134 if (!--sched_core_count)
135 __sched_core_disable();
136 mutex_unlock(&sched_core_mutex);
137 }
138
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32415 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [peterz-queue:sched/core-sched 4/12] kernel/sched/core.c:123:6: warning: no previous prototype for 'sched_core_get'
@ 2021-01-26 17:02 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-01-26 17:02 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2539 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core-sched
head: 505afdadb6345844c2db4c74cf2f65504013e8a7
commit: bfc18d532566b96a1c7ac0989d2927f622e7d94c [4/12] sched: Core-wide rq->lock
config: ia64-randconfig-r005-20210126 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?id=bfc18d532566b96a1c7ac0989d2927f622e7d94c
git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
git fetch --no-tags peterz-queue sched/core-sched
git checkout bfc18d532566b96a1c7ac0989d2927f622e7d94c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> kernel/sched/core.c:123:6: warning: no previous prototype for 'sched_core_get' [-Wmissing-prototypes]
123 | void sched_core_get(void)
| ^~~~~~~~~~~~~~
>> kernel/sched/core.c:131:6: warning: no previous prototype for 'sched_core_put' [-Wmissing-prototypes]
131 | void sched_core_put(void)
| ^~~~~~~~~~~~~~
kernel/sched/core.c:2899:6: warning: no previous prototype for 'sched_set_stop_task' [-Wmissing-prototypes]
2899 | void sched_set_stop_task(int cpu, struct task_struct *stop)
| ^~~~~~~~~~~~~~~~~~~
kernel/sched/core.c: In function 'schedule_tail':
kernel/sched/core.c:4316:13: warning: variable 'rq' set but not used [-Wunused-but-set-variable]
4316 | struct rq *rq;
| ^~
vim +/sched_core_get +123 kernel/sched/core.c
122
> 123 void sched_core_get(void)
124 {
125 mutex_lock(&sched_core_mutex);
126 if (!sched_core_count++)
127 __sched_core_enable();
128 mutex_unlock(&sched_core_mutex);
129 }
130
> 131 void sched_core_put(void)
132 {
133 mutex_lock(&sched_core_mutex);
134 if (!--sched_core_count)
135 __sched_core_disable();
136 mutex_unlock(&sched_core_mutex);
137 }
138
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31287 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-26 17:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <202011250343.EPLZDqfG-lkp@intel.com>
2020-11-24 20:43 ` [peterz-queue:sched/core-sched 4/12] kernel/sched/core.c:123:6: warning: no previous prototype for 'sched_core_get' Joel Fernandes
2020-11-24 20:52 ` Joel Fernandes
2020-11-26 20:29 kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2021-01-26 17:02 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.