From: Michael Klein <michael@fossekall.de>
To: Maxime Ripard <maxime@cerno.tech>
Cc: devicetree@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ARM: dts: sun8i-h2-plus-bananapi-m2-zero: add poweroff node to DT
Date: Tue, 24 Nov 2020 23:31:59 +0100 [thread overview]
Message-ID: <20201124223159.GA2865084@a98shuttle.de> (raw)
In-Reply-To: <20201124142656.wz6ipwa2xayn433x@gilmour>
On Tue, Nov 24, 2020 at 03:26:56PM +0100, Maxime Ripard wrote:
>On Tue, Nov 24, 2020 at 02:36:33PM +0100, Michael Klein wrote:
>> Add poweroff node to allow the board to power itself off after shutdown
>> by disabling the SYSTEM and CPUX regulators (U5 resp. U6). The RST
>> button can be used to restart the board.
>>
>> Signed-off-by: Michael Klein <michael@fossekall.de>
>> ---
>> arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts | 5 +++++
>> 1 file changed, 5 insertions(+)
>
>You should have a summary of the changes between versions here
>
>> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> index 4c6704e4c57e..ea2fa48a1647 100644
>> --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> @@ -46,6 +46,11 @@ sw4 {
>> };
>> };
>>
>> + poweroff {
>> + compatible = "gpio-poweroff";
>> + gpios = <&r_pio 0 8 GPIO_ACTIVE_LOW>; /* PL8 */
>> + };
>> +
>
>Like I said in the previous version, this should really be modelled as a
>regulator instead of just a GPIO
Please excuse my ignorance, do you mean something like this?
reg_vdd_sys: vdd-sys {
compatible = "regulator-fixed";
regulator-name = "vdd-sys";
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <1200000>;
regulator-always-on;
regulator-boot-on;
enable-active-high;
gpio = <&r_pio 0 8 GPIO_ACTIVE_HIGH>; /* PL8 */
vin-supply = <®_vcc5v0>;
};
With this, the board still draws 60mA (cheap USB ampere meter) after
shutdown, presumably because of "regulator-always-on". Without this
property the board powers off shortly after booting up.
Michael
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Michael Klein <michael@fossekall.de>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: dts: sun8i-h2-plus-bananapi-m2-zero: add poweroff node to DT
Date: Tue, 24 Nov 2020 23:31:59 +0100 [thread overview]
Message-ID: <20201124223159.GA2865084@a98shuttle.de> (raw)
In-Reply-To: <20201124142656.wz6ipwa2xayn433x@gilmour>
On Tue, Nov 24, 2020 at 03:26:56PM +0100, Maxime Ripard wrote:
>On Tue, Nov 24, 2020 at 02:36:33PM +0100, Michael Klein wrote:
>> Add poweroff node to allow the board to power itself off after shutdown
>> by disabling the SYSTEM and CPUX regulators (U5 resp. U6). The RST
>> button can be used to restart the board.
>>
>> Signed-off-by: Michael Klein <michael@fossekall.de>
>> ---
>> arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts | 5 +++++
>> 1 file changed, 5 insertions(+)
>
>You should have a summary of the changes between versions here
>
>> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> index 4c6704e4c57e..ea2fa48a1647 100644
>> --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> @@ -46,6 +46,11 @@ sw4 {
>> };
>> };
>>
>> + poweroff {
>> + compatible = "gpio-poweroff";
>> + gpios = <&r_pio 0 8 GPIO_ACTIVE_LOW>; /* PL8 */
>> + };
>> +
>
>Like I said in the previous version, this should really be modelled as a
>regulator instead of just a GPIO
Please excuse my ignorance, do you mean something like this?
reg_vdd_sys: vdd-sys {
compatible = "regulator-fixed";
regulator-name = "vdd-sys";
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <1200000>;
regulator-always-on;
regulator-boot-on;
enable-active-high;
gpio = <&r_pio 0 8 GPIO_ACTIVE_HIGH>; /* PL8 */
vin-supply = <®_vcc5v0>;
};
With this, the board still draws 60mA (cheap USB ampere meter) after
shutdown, presumably because of "regulator-always-on". Without this
property the board powers off shortly after booting up.
Michael
next prev parent reply other threads:[~2020-11-24 22:32 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 16:10 [PATCH] ARM: dts: sun8i-h2-plus-bananapi-m2-zero: add gpio-poweroff to DT Michael Klein
2020-11-23 16:10 ` Michael Klein
2020-11-24 4:14 ` Samuel Holland
2020-11-24 4:14 ` Samuel Holland
2020-11-24 4:41 ` Chen-Yu Tsai
2020-11-24 4:41 ` Chen-Yu Tsai
2020-11-24 13:21 ` Maxime Ripard
2020-11-24 13:21 ` Maxime Ripard
2020-11-24 13:19 ` Maxime Ripard
2020-11-24 13:19 ` Maxime Ripard
2020-11-24 13:36 ` [PATCH v2] ARM: dts: sun8i-h2-plus-bananapi-m2-zero: add poweroff node " Michael Klein
2020-11-24 13:36 ` Michael Klein
2020-11-24 14:26 ` Maxime Ripard
2020-11-24 14:26 ` Maxime Ripard
2020-11-24 22:31 ` Michael Klein [this message]
2020-11-24 22:31 ` Michael Klein
2020-11-28 10:39 ` Maxime Ripard
2020-11-28 10:39 ` Maxime Ripard
2020-12-07 14:27 ` [PATCH v3 0/3] BPi M2 Zero poweroff support via new regulator-poweroff driver Michael Klein
2020-12-07 14:27 ` Michael Klein
2020-12-07 14:27 ` [PATCH v3 1/3] power: reset: new driver regulator-poweroff Michael Klein
2020-12-07 14:27 ` Michael Klein
2020-12-08 10:10 ` Maxime Ripard
2020-12-08 10:10 ` Maxime Ripard
2020-12-09 20:34 ` Michael Klein
2020-12-09 20:34 ` Michael Klein
2020-12-07 14:27 ` [PATCH v3 2/3] Documentation: DT: binding documentation for regulator-poweroff Michael Klein
2020-12-07 14:27 ` Michael Klein
2020-12-08 10:13 ` Maxime Ripard
2020-12-08 10:13 ` Maxime Ripard
2020-12-08 12:52 ` Michael Klein
2020-12-08 12:52 ` Michael Klein
2020-12-10 14:30 ` Maxime Ripard
2020-12-10 14:30 ` Maxime Ripard
2020-12-08 15:21 ` Rob Herring
2020-12-08 15:21 ` Rob Herring
2020-12-08 15:39 ` Rob Herring
2020-12-08 15:39 ` Rob Herring
2020-12-07 14:27 ` [PATCH v3 3/3] ARM: dts: sun8i-h2-plus-bananapi-m2-zero: add poweroff node Michael Klein
2020-12-07 14:27 ` Michael Klein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124223159.GA2865084@a98shuttle.de \
--to=michael@fossekall.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.