Re: [Intel-gfx] [PATCH] drm/i915/display: Record the plane update times for debugging

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3430 bytes --]

Hi Chris,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip v5.10-rc5 next-20201126]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-display-Record-the-plane-update-times-for-debugging/20201127-052128
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/7507dad86ddaa800a17665609a0171e9b958b451
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Chris-Wilson/drm-i915-display-Record-the-plane-update-times-for-debugging/20201127-052128
        git checkout 7507dad86ddaa800a17665609a0171e9b958b451
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/drm/drm_mm.h:49,
                    from include/drm/drm_vma_manager.h:26,
                    from include/drm/drm_gem.h:40,
                    from drivers/gpu/drm/i915/i915_drv.h:55,
                    from drivers/gpu/drm/i915/display/intel_sprite.c:42:
   drivers/gpu/drm/i915/display/intel_sprite.c: In function 'dbg_vblank_evade':
   include/drm/drm_print.h:450:19: error: request for member 'dev' in something not a structure or union
     450 |  drm_dev_dbg((drm)->dev, DRM_UT_KMS, fmt, ##__VA_ARGS__)
         |                   ^~
   drivers/gpu/drm/i915/display/intel_sprite.c:201:3: note: in expansion of macro 'drm_dbg_kms'
     201 |   drm_dbg_kms("Atomic update on pipe (%c) took %lld us, max time under evasion is %u us\n",
         |   ^~~~~~~~~~~
>> drivers/gpu/drm/i915/display/intel_display.h:96:27: warning: passing argument 3 of 'drm_dev_dbg' makes pointer from integer without a cast [-Wint-conversion]
      96 | #define pipe_name(p) ((p) + 'A')
         |                      ~~~~~^~~~~~
         |                           |
         |                           int
   include/drm/drm_print.h:450:38: note: in definition of macro 'drm_dbg_kms'
     450 |  drm_dev_dbg((drm)->dev, DRM_UT_KMS, fmt, ##__VA_ARGS__)
         |                                      ^~~
   drivers/gpu/drm/i915/display/intel_sprite.c:202:8: note: in expansion of macro 'pipe_name'
     202 |        pipe_name(crtc->pipe),
         |        ^~~~~~~~~
   include/drm/drm_print.h:338:16: note: expected 'const char *' but argument is of type 'int'
     338 |    const char *format, ...);
         |    ~~~~~~~~~~~~^~~~~~

vim +/drm_dev_dbg +96 drivers/gpu/drm/i915/display/intel_display.h

09a28bd9e8024d1 drivers/gpu/drm/i915/intel_display.h Michal Wajdeczko 2017-12-21  95  
09a28bd9e8024d1 drivers/gpu/drm/i915/intel_display.h Michal Wajdeczko 2017-12-21 @96  #define pipe_name(p) ((p) + 'A')
09a28bd9e8024d1 drivers/gpu/drm/i915/intel_display.h Michal Wajdeczko 2017-12-21  97  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 76989 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx