[PATCH 0/2] Fix spelling of "regulator"

[PATCH 0/2] Fix spelling of "regulator"

[Michael Klein]

Michael Klein (2):
  Documentation: mcp16502-regulator: fix spelling mistake
  mfd: fix spelling mistakes

 .../devicetree/bindings/regulator/mcp16502-regulator.txt      | 2 +-
 drivers/regulator/da9055-regulator.c                          | 4 ++--
 include/linux/mfd/da9055/reg.h                                | 4 ++--
 include/linux/mfd/si476x-core.h                               | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

-- 
2.29.2

[PATCH 1/2] Documentation: mcp16502-regulator: fix spelling mistake

[Michael Klein]

Signed-off-by: Michael Klein <michael@fossekall.de>
---
 .../devicetree/bindings/regulator/mcp16502-regulator.txt        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/regulator/mcp16502-regulator.txt b/Documentation/devicetree/bindings/regulator/mcp16502-regulator.txt
index b8f843fa6092..d86584ed4d93 100644
--- a/Documentation/devicetree/bindings/regulator/mcp16502-regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/mcp16502-regulator.txt
@@ -10,7 +10,7 @@ Required properties:
               name. The content of each sub-node is defined by the
               standard binding for regulators; see regulator.txt.
 
-Regualtors of MCP16502 PMIC:
+Regulators of MCP16502 PMIC:
 1) VDD_IO	- Buck (1.2 - 3.7 V)
 2) VDD_DDR	- Buck (0.6 - 1.85 V)
 3) VDD_CORE	- Buck (0.6 - 1.85 V)
-- 
2.29.2

[PATCH 2/2] mfd: fix spelling mistakes

[Michael Klein]

Signed-off-by: Michael Klein <michael@fossekall.de>
---
 drivers/regulator/da9055-regulator.c | 4 ++--
 include/linux/mfd/da9055/reg.h       | 4 ++--
 include/linux/mfd/si476x-core.h      | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/regulator/da9055-regulator.c b/drivers/regulator/da9055-regulator.c
index 73ff5fc7d8d7..c0394ac5e60a 100644
--- a/drivers/regulator/da9055-regulator.c
+++ b/drivers/regulator/da9055-regulator.c
@@ -184,7 +184,7 @@ static int da9055_regulator_get_voltage_sel(struct regulator_dev *rdev)
 	ret &= info->conf.sel_mask;
 
 	/* Get the voltage for the active register set A/B */
-	if (ret == DA9055_REGUALTOR_SET_A)
+	if (ret == DA9055_REGULATOR_SET_A)
 		ret = da9055_reg_read(regulator->da9055, volt.reg_a);
 	else
 		ret = da9055_reg_read(regulator->da9055, volt.reg_b);
@@ -231,7 +231,7 @@ static int da9055_regulator_set_voltage_sel(struct regulator_dev *rdev,
 	ret &= info->conf.sel_mask;
 
 	/* Set the voltage */
-	if (ret == DA9055_REGUALTOR_SET_A)
+	if (ret == DA9055_REGULATOR_SET_A)
 		return da9055_reg_update(regulator->da9055, info->volt.reg_a,
 					 info->volt.v_mask, selector);
 	else
diff --git a/include/linux/mfd/da9055/reg.h b/include/linux/mfd/da9055/reg.h
index 54a717b6c3de..1204e6b152d5 100644
--- a/include/linux/mfd/da9055/reg.h
+++ b/include/linux/mfd/da9055/reg.h
@@ -344,8 +344,8 @@
 #define	DA9055_VLDO_GPI_MASK		0x60
 #define	DA9055_LDO_CONF_SHIFT		0x07
 #define	DA9055_LDO_CONF_MASK		0x80
-#define	DA9055_REGUALTOR_SET_A		0x00
-#define	DA9055_REGUALTOR_SET_B		0x10
+#define	DA9055_REGULATOR_SET_A		0x00
+#define	DA9055_REGULATOR_SET_B		0x10
 
 /* DA9055_REG_ADC_MAN (addr=0x1B) */
 #define	DA9055_ADC_MUX_SHIFT		0
diff --git a/include/linux/mfd/si476x-core.h b/include/linux/mfd/si476x-core.h
index 4708c2b8512a..dd95c37ca134 100644
--- a/include/linux/mfd/si476x-core.h
+++ b/include/linux/mfd/si476x-core.h
@@ -57,7 +57,7 @@ enum si476x_mfd_cells {
  * @SI476X_POWER_DOWN: In this state all regulators are turned off
  * and the reset line is pulled low. The device is completely
  * inactive.
- * @SI476X_POWER_UP_FULL: In this state all the power regualtors are
+ * @SI476X_POWER_UP_FULL: In this state all the power regulators are
  * turned on, reset line pulled high, IRQ line is enabled(polling is
  * active for polling use scenario) and device is turned on with
  * POWER_UP command. The device is ready to be used.
-- 
2.29.2

Re: [PATCH 2/2] mfd: fix spelling mistakes

[Lee Jones]

On Tue, 24 Nov 2020, Michael Klein wrote:

The subject line needs to be more forthcoming.

What spelling mistakes are you fixing?

Which files are being changed?

> Signed-off-by: Michael Klein <michael@fossekall.de>
> ---
>  drivers/regulator/da9055-regulator.c | 4 ++--
>  include/linux/mfd/da9055/reg.h       | 4 ++--
>  include/linux/mfd/si476x-core.h      | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)

Let's have a patch for each of these, with proper subject lines.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

[PATCH v2 1/3] Documentation: mcp16502-regulator: fix spelling mistake

[Michael Klein]

Signed-off-by: Michael Klein <michael@fossekall.de>
---
  No changes in v2

 .../devicetree/bindings/regulator/mcp16502-regulator.txt        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/regulator/mcp16502-regulator.txt b/Documentation/devicetree/bindings/regulator/mcp16502-regulator.txt
index b8f843fa6092..d86584ed4d93 100644
--- a/Documentation/devicetree/bindings/regulator/mcp16502-regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/mcp16502-regulator.txt
@@ -10,7 +10,7 @@ Required properties:
               name. The content of each sub-node is defined by the
               standard binding for regulators; see regulator.txt.
 
-Regualtors of MCP16502 PMIC:
+Regulators of MCP16502 PMIC:
 1) VDD_IO	- Buck (1.2 - 3.7 V)
 2) VDD_DDR	- Buck (0.6 - 1.85 V)
 3) VDD_CORE	- Buck (0.6 - 1.85 V)
-- 
2.29.2

[PATCH v2 2/3] mfd: si476x-core.h: fix "regulator" spelling in comment

[Michael Klein]

"regualtor" -> "regulator"

Signed-off-by: Michael Klein <michael@fossekall.de>
---
Changes in v2:
  - split patch
  - make subject line more forthcoming

 include/linux/mfd/si476x-core.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mfd/si476x-core.h b/include/linux/mfd/si476x-core.h
index 4708c2b8512a..dd95c37ca134 100644
--- a/include/linux/mfd/si476x-core.h
+++ b/include/linux/mfd/si476x-core.h
@@ -57,7 +57,7 @@ enum si476x_mfd_cells {
  * @SI476X_POWER_DOWN: In this state all regulators are turned off
  * and the reset line is pulled low. The device is completely
  * inactive.
- * @SI476X_POWER_UP_FULL: In this state all the power regualtors are
+ * @SI476X_POWER_UP_FULL: In this state all the power regulators are
  * turned on, reset line pulled high, IRQ line is enabled(polling is
  * active for polling use scenario) and device is turned on with
  * POWER_UP command. The device is ready to be used.
-- 
2.29.2

Re: [PATCH v2 2/3] mfd: si476x-core.h: fix "regulator" spelling in comment

[Lee Jones]

On Fri, 27 Nov 2020, Michael Klein wrote:

> "regualtor" -> "regulator"
> 
> Signed-off-by: Michael Klein <michael@fossekall.de>
> ---
> Changes in v2:
>   - split patch
>   - make subject line more forthcoming
> 
>  include/linux/mfd/si476x-core.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

[PATCH v2 3/3] mfd: da9055: fix "REGULATOR" spelling in register content macro

[Michael Klein]

"REGUALTOR" -> "REGULATOR"

Signed-off-by: Michael Klein <michael@fossekall.de>
---
Changes in v2:
  - split patch
  - make subject line more forthcoming

 drivers/regulator/da9055-regulator.c | 4 ++--
 include/linux/mfd/da9055/reg.h       | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/da9055-regulator.c b/drivers/regulator/da9055-regulator.c
index 73ff5fc7d8d7..c0394ac5e60a 100644
--- a/drivers/regulator/da9055-regulator.c
+++ b/drivers/regulator/da9055-regulator.c
@@ -184,7 +184,7 @@ static int da9055_regulator_get_voltage_sel(struct regulator_dev *rdev)
 	ret &= info->conf.sel_mask;
 
 	/* Get the voltage for the active register set A/B */
-	if (ret == DA9055_REGUALTOR_SET_A)
+	if (ret == DA9055_REGULATOR_SET_A)
 		ret = da9055_reg_read(regulator->da9055, volt.reg_a);
 	else
 		ret = da9055_reg_read(regulator->da9055, volt.reg_b);
@@ -231,7 +231,7 @@ static int da9055_regulator_set_voltage_sel(struct regulator_dev *rdev,
 	ret &= info->conf.sel_mask;
 
 	/* Set the voltage */
-	if (ret == DA9055_REGUALTOR_SET_A)
+	if (ret == DA9055_REGULATOR_SET_A)
 		return da9055_reg_update(regulator->da9055, info->volt.reg_a,
 					 info->volt.v_mask, selector);
 	else
diff --git a/include/linux/mfd/da9055/reg.h b/include/linux/mfd/da9055/reg.h
index 54a717b6c3de..1204e6b152d5 100644
--- a/include/linux/mfd/da9055/reg.h
+++ b/include/linux/mfd/da9055/reg.h
@@ -344,8 +344,8 @@
 #define	DA9055_VLDO_GPI_MASK		0x60
 #define	DA9055_LDO_CONF_SHIFT		0x07
 #define	DA9055_LDO_CONF_MASK		0x80
-#define	DA9055_REGUALTOR_SET_A		0x00
-#define	DA9055_REGUALTOR_SET_B		0x10
+#define	DA9055_REGULATOR_SET_A		0x00
+#define	DA9055_REGULATOR_SET_B		0x10
 
 /* DA9055_REG_ADC_MAN (addr=0x1B) */
 #define	DA9055_ADC_MUX_SHIFT		0
-- 
2.29.2

RE: [PATCH v2 3/3] mfd: da9055: fix "REGULATOR" spelling in register content macro

[Adam Thomson]

On 27 November 2020 12:52, Michael Klein wrote:

> "REGUALTOR" -> "REGULATOR"
> 
> Signed-off-by: Michael Klein <michael@fossekall.de>

Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

Re: [PATCH v2 3/3] mfd: da9055: fix "REGULATOR" spelling in register content macro

[Lee Jones]

On Fri, 27 Nov 2020, Michael Klein wrote:

> "REGUALTOR" -> "REGULATOR"
> 
> Signed-off-by: Michael Klein <michael@fossekall.de>
> ---
> Changes in v2:
>   - split patch
>   - make subject line more forthcoming
> 
>  drivers/regulator/da9055-regulator.c | 4 ++--
>  include/linux/mfd/da9055/reg.h       | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)

Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v2 1/3] Documentation: mcp16502-regulator: fix spelling mistake

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

On Fri, Nov 27, 2020 at 01:52:00PM +0100, Michael Klein wrote:
> Signed-off-by: Michael Klein <michael@fossekall.de>
> ---
>   No changes in v2

Please do not submit new versions of already applied patches, please
submit incremental updates to the existing code.  Modifying existing
commits creates problems for other users building on top of those
commits so it's best practice to only change pubished git commits if
absolutely essential.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 0/2] Fix spelling of "regulator"

[Mark Brown]

On Tue, 24 Nov 2020 19:37:28 +0100, Michael Klein wrote:
> Michael Klein (2):
>   Documentation: mcp16502-regulator: fix spelling mistake
>   mfd: fix spelling mistakes
> 
>  .../devicetree/bindings/regulator/mcp16502-regulator.txt      | 2 +-
>  drivers/regulator/da9055-regulator.c                          | 4 ++--
>  include/linux/mfd/da9055/reg.h                                | 4 ++--
>  include/linux/mfd/si476x-core.h                               | 2 +-
>  4 files changed, 6 insertions(+), 6 deletions(-)

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: mcp16502-regulator: fix spelling mistake
      commit: 33f369efbce15e034db4faabeec8502d7d236859

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark