Re: [PATCH 1/2] iio: adc: Add driver for Texas Instruments ADS131E0x ADC family

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2782 bytes --]

Hi,

I love your patch! Yet something to improve:

[auto build test ERROR on iio/togreg]
[also build test ERROR on linus/master v5.10-rc5 next-20201127]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/tomislav-denis-avl-com/iio-adc-Add-driver-for-Texas-Instruments-ADS131E0x-ADC-family/20201129-062610
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9a70466cfd655dcd40e9b57ff7deb4a7bf2b0110
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review tomislav-denis-avl-com/iio-adc-Add-driver-for-Texas-Instruments-ADS131E0x-ADC-family/20201129-062610
        git checkout 9a70466cfd655dcd40e9b57ff7deb4a7bf2b0110
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from drivers/iio/adc/ti-ads131e08.c:11:
>> drivers/iio/adc/ti-ads131e08.c:804:25: error: 'ads131e08_matches' undeclared here (not in a function); did you mean 'ads131e08_of_match'?
     804 | MODULE_DEVICE_TABLE(of, ads131e08_matches);
         |                         ^~~~~~~~~~~~~~~~~
   include/linux/module.h:240:15: note: in definition of macro 'MODULE_DEVICE_TABLE'
     240 | extern typeof(name) __mod_##type##__##name##_device_table  \
         |               ^~~~
>> include/linux/module.h:240:21: error: '__mod_of__ads131e08_matches_device_table' aliased to undefined symbol 'ads131e08_matches'
     240 | extern typeof(name) __mod_##type##__##name##_device_table  \
         |                     ^~~~~~
   drivers/iio/adc/ti-ads131e08.c:804:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
     804 | MODULE_DEVICE_TABLE(of, ads131e08_matches);
         | ^~~~~~~~~~~~~~~~~~~

vim +804 drivers/iio/adc/ti-ads131e08.c

   798	
   799	static const struct of_device_id ads131e08_of_match[] = {
   800		{ .compatible = "ti,ads131e04", },
   801		{ .compatible = "ti,ads131e08", },
   802		{}
   803	};
 > 804	MODULE_DEVICE_TABLE(of, ads131e08_matches);
   805	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52871 bytes --]