From: Rob Herring <robh@kernel.org>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
Sean Anderson <seanga2@gmail.com>,
linux-clk@vger.kernel.org, Philipp Zabel <p.zabel@pengutronix.de>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 09/21] dt-bindings: Document canaan,k210-fpioa bindings
Date: Mon, 30 Nov 2020 09:39:15 -0700 [thread overview]
Message-ID: <20201130163915.GA2593105@robh.at.kernel.org> (raw)
In-Reply-To: <20201124043728.199852-10-damien.lemoal@wdc.com>
On Tue, 24 Nov 2020 13:37:16 +0900, Damien Le Moal wrote:
> Document the device tree bindings for the Canaan Kendryte K210 SoC
> Fully Programmable IO Array (FPIOA) pinctrl driver in
> Documentation/devicetree/bindings/pinctrl/canaan,k210-fpioa.yaml. The
> new header file include/dt-bindings/pinctrl/k210-fpioa.h is added to
> define all 256 possible pin functions of the SoC IO pins, as well as
> macros simplifying the definition of pin functions in a device tree.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
> .../bindings/pinctrl/canaan,k210-fpioa.yaml | 165 +++++++++++
> include/dt-bindings/pinctrl/k210-fpioa.h | 276 ++++++++++++++++++
> 2 files changed, 441 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/canaan,k210-fpioa.yaml
> create mode 100644 include/dt-bindings/pinctrl/k210-fpioa.h
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/pinctrl/canaan,k210-fpioa.yaml:59:1: [error] syntax error: found character '\t' that cannot start any token (syntax)
dtschema/dtc warnings/errors:
Traceback (most recent call last):
File "/usr/local/bin/dt-extract-example", line 45, in <module>
binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 343, in load
return constructor.get_single_data()
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 111, in get_single_data
node = self.composer.get_single_node()
File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node
File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 731, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event
ruamel.yaml.scanner.ScannerError: while scanning a plain scalar
in "<unicode string>", line 58, column 11
found a tab character that violates indentation
in "<unicode string>", line 59, column 1
make[1]: *** [Documentation/devicetree/bindings/Makefile:20: Documentation/devicetree/bindings/pinctrl/canaan,k210-fpioa.example.dts] Error 1
make[1]: *** Deleting file 'Documentation/devicetree/bindings/pinctrl/canaan,k210-fpioa.example.dts'
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [Documentation/devicetree/bindings/Makefile:59: Documentation/devicetree/bindings/processed-schema-examples.json] Error 123
make: *** [Makefile:1364: dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1405241
The base for the patch is generally the last rc1. Any dependencies
should be noted.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: devicetree@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Sean Anderson <seanga2@gmail.com>,
linux-gpio@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 09/21] dt-bindings: Document canaan, k210-fpioa bindings
Date: Mon, 30 Nov 2020 09:39:15 -0700 [thread overview]
Message-ID: <20201130163915.GA2593105@robh.at.kernel.org> (raw)
In-Reply-To: <20201124043728.199852-10-damien.lemoal@wdc.com>
On Tue, 24 Nov 2020 13:37:16 +0900, Damien Le Moal wrote:
> Document the device tree bindings for the Canaan Kendryte K210 SoC
> Fully Programmable IO Array (FPIOA) pinctrl driver in
> Documentation/devicetree/bindings/pinctrl/canaan,k210-fpioa.yaml. The
> new header file include/dt-bindings/pinctrl/k210-fpioa.h is added to
> define all 256 possible pin functions of the SoC IO pins, as well as
> macros simplifying the definition of pin functions in a device tree.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
> .../bindings/pinctrl/canaan,k210-fpioa.yaml | 165 +++++++++++
> include/dt-bindings/pinctrl/k210-fpioa.h | 276 ++++++++++++++++++
> 2 files changed, 441 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/canaan,k210-fpioa.yaml
> create mode 100644 include/dt-bindings/pinctrl/k210-fpioa.h
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/pinctrl/canaan,k210-fpioa.yaml:59:1: [error] syntax error: found character '\t' that cannot start any token (syntax)
dtschema/dtc warnings/errors:
Traceback (most recent call last):
File "/usr/local/bin/dt-extract-example", line 45, in <module>
binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 343, in load
return constructor.get_single_data()
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 111, in get_single_data
node = self.composer.get_single_node()
File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node
File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 731, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event
ruamel.yaml.scanner.ScannerError: while scanning a plain scalar
in "<unicode string>", line 58, column 11
found a tab character that violates indentation
in "<unicode string>", line 59, column 1
make[1]: *** [Documentation/devicetree/bindings/Makefile:20: Documentation/devicetree/bindings/pinctrl/canaan,k210-fpioa.example.dts] Error 1
make[1]: *** Deleting file 'Documentation/devicetree/bindings/pinctrl/canaan,k210-fpioa.example.dts'
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [Documentation/devicetree/bindings/Makefile:59: Documentation/devicetree/bindings/processed-schema-examples.json] Error 123
make: *** [Makefile:1364: dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1405241
The base for the patch is generally the last rc1. Any dependencies
should be noted.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2020-11-30 16:40 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 4:37 [PATCH v2 00/21] RISC-V Kendryte K210 support improvements Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 01/21] riscv: Fix kernel time_init() Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 02/21] riscv: Fix sifive serial driver Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 03/21] riscv: Enable interrupts during syscalls with M-Mode Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 04/21] riscv: Fix builtin DTB handling Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 05/21] riscv: Use vendor name for K210 SoC support Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 06/21] dt-bindings: Add Canaan vendor prefix Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 07/21] dt-binding: Document canaan,k210-clk bindings Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 08/21] dt-bindings: Document canaan,k210-rst bindings Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 09/21] dt-bindings: Document canaan,k210-fpioa bindings Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 9:48 ` Geert Uytterhoeven
2020-11-24 9:48 ` [PATCH v2 09/21] dt-bindings: Document canaan, k210-fpioa bindings Geert Uytterhoeven
2020-11-24 10:05 ` [PATCH v2 09/21] dt-bindings: Document canaan,k210-fpioa bindings Damien Le Moal
2020-11-24 10:05 ` [PATCH v2 09/21] dt-bindings: Document canaan, k210-fpioa bindings Damien Le Moal
2020-11-26 10:42 ` [PATCH v2 09/21] dt-bindings: Document canaan,k210-fpioa bindings Geert Uytterhoeven
2020-11-26 10:42 ` [PATCH v2 09/21] dt-bindings: Document canaan, k210-fpioa bindings Geert Uytterhoeven
2020-11-26 10:52 ` [PATCH v2 09/21] dt-bindings: Document canaan,k210-fpioa bindings Damien Le Moal
2020-11-26 10:52 ` [PATCH v2 09/21] dt-bindings: Document canaan, k210-fpioa bindings Damien Le Moal
2020-11-30 16:39 ` Rob Herring [this message]
2020-11-30 16:39 ` Rob Herring
2020-11-24 4:37 ` [PATCH v2 10/21] dt-binding: Document canaan,k210-sysctl bindings Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-30 16:40 ` Rob Herring
2020-11-30 16:40 ` [PATCH v2 10/21] dt-binding: Document canaan, k210-sysctl bindings Rob Herring
2020-11-24 4:37 ` [PATCH v2 11/21] riscv: Add Canaan Kendryte K210 clock driver Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 12/21] riscv: Add Canaan Kendryte K210 FPIOA driver Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 13/21] riscv: Add Canaan Kendryte K210 reset controller Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 14/21] riscv: Update Kendryte K210 device tree Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 15/21] riscv: Add SiPeed MAIX BiT board " Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 16/21] riscv: Add SiPeed MAIX DOCK " Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 17/21] riscv: Add SiPeed MAIX GO " Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 18/21] riscv: Add SiPeed MAIXDUINO " Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 19/21] riscv: Add Kendryte KD233 " Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 20/21] riscv: Update Canaan Kendryte K210 defconfig Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 4:37 ` [PATCH v2 21/21] riscv: Add Canaan Kendryte K210 SD card defconfig Damien Le Moal
2020-11-24 4:37 ` Damien Le Moal
2020-11-24 18:51 ` Geert Uytterhoeven
2020-11-24 18:51 ` Geert Uytterhoeven
2020-11-25 0:05 ` Damien Le Moal
2020-11-25 0:05 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130163915.GA2593105@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=damien.lemoal@wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=seanga2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.