Re: [PATCH] hwmon: (applesmc) Add DMI product matches for Intel-based Xserves (non-RackMac*)

Re: [PATCH] hwmon: (applesmc) Add DMI product matches for Intel-based Xserves (non-RackMac*)

[Guenter Roeck]

On Sat, Nov 28, 2020 at 10:54:03AM -0600, Joe Jamison wrote:
> This patch adds the DMI Product ID for Intel-based Xserve machines.
> They use the same SMC accessible from the same data ports.
> 
> The 'Xserve' product ID only resolves to SMC-containing
> Intel-based Xserves, as the PowerPC machines are identified
> by the 'RackMac' identifier.
> 
> Tested on: Xserve3,1
> 
> Tested-by: Joe Jamison <joe@smaklab.com> # Xserve3,1
> Signed-off-by: Joe Jamison <joe@smaklab.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/applesmc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c
> index 79b498f816fe..89207af81c48 100644
> --- a/drivers/hwmon/applesmc.c
> +++ b/drivers/hwmon/applesmc.c
> @@ -1299,6 +1299,10 @@ static const struct dmi_system_id applesmc_whitelist[] __initconst = {
>  	  DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
>  	  DMI_MATCH(DMI_PRODUCT_NAME, "iMac") },
>  	},
> +	{ applesmc_dmi_match, "Apple Xserve", {
> +	  DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
> +	  DMI_MATCH(DMI_PRODUCT_NAME, "Xserve") },
> +	},
>  	{ .ident = NULL }
>  };
>  
> -- 
> 2.20.1
> 

[PATCH] hwmon: (applesmc) Add DMI product matches for Intel-based Xserves (non-RackMac*)

[Joe Jamison]

This patch adds the DMI Product ID for Intel-based Xserve machines.
They use the same SMC accessible from the same data ports.

The 'Xserve' product ID only resolves to SMC-containing
Intel-based Xserves, as the PowerPC machines are identified
by the 'RackMac' identifier.

Tested on: Xserve3,1

Tested-by: Joe Jamison <joe@smaklab.com> # Xserve3,1
Signed-off-by: Joe Jamison <joe@smaklab.com>
---
 drivers/hwmon/applesmc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c
index 79b498f816fe..89207af81c48 100644
--- a/drivers/hwmon/applesmc.c
+++ b/drivers/hwmon/applesmc.c
@@ -1299,6 +1299,10 @@ static const struct dmi_system_id applesmc_whitelist[] __initconst = {
 	  DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
 	  DMI_MATCH(DMI_PRODUCT_NAME, "iMac") },
 	},
+	{ applesmc_dmi_match, "Apple Xserve", {
+	  DMI_MATCH(DMI_BOARD_VENDOR, "Apple"),
+	  DMI_MATCH(DMI_PRODUCT_NAME, "Xserve") },
+	},
 	{ .ident = NULL }
 };
 
-- 
2.20.1