Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings

From: Lee Jones <lee.jones@linaro.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
	linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Vaibhav Gupta <vaibhavgupta40@gmail.com>,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Jiri Slaby <jirislaby@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	Evgeny Novikov <novikov@ispras.ru>,
	Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Thomas Winischhofer <thomas@winischhofer.net>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Jani Nikula <jani.nikula@intel.com>,
	Aditya Pakki <pakki001@umn.edu>,
	Xiaofei Tan <tanxiaofei@huawei.com>,
	Nathan Chancellor <natechancellor@gmail.com>,
	Alex Dewar <alex.dewar90@gmail.com>,
	Jason Yan <yanaijie@huawei.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Qilong Zhang <zhangqilong3@huawei.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Gustavo Silva <gustavoars@kernel.org>,
	Peter Rosin <peda@axentia.se>,
	George Kennedy <george.kennedy@oracle.com>,
	Kristoffer Ericson <kristoffer.ericson@gmail.com>,
	Alexander Klimov <grandmaster@al2klimov.de>,
	Jingoo Han <jingoohan1@gmail.com>, Joe Perches <joe@perches.com>,
	Peilin Ye <yepeilin.cs@gmail.com>,
	Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH v2 13/28] video: fbdev: riva: Fix kernel-doc and set but not used warnings
Date: Tue, 1 Dec 2020 08:47:18 +0000	[thread overview]
Message-ID: <20201201084718.GF4801@dell> (raw)
In-Reply-To: <20201130183549.GA1498572@ravnborg.org>

On Mon, 30 Nov 2020, Sam Ravnborg wrote:

> On Mon, Nov 30, 2020 at 01:14:52PM +0100, Thomas Zimmermann wrote:
> > 
> > 
> > Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
> > > Fix W=1 warnings:
> > > - Fix kernel-doc
> > > - Drop unused variables/code
> > > 
> > > v2:
> > >    - Updated subject (Lee)
> > > 
> > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > > Cc: Antonino Daplas <adaplas@gmail.com>
> > > Cc: linux-fbdev@vger.kernel.org
> > > Cc: Lee Jones <lee.jones@linaro.org>
> > > ---
> > >   drivers/video/fbdev/riva/fbdev.c   |  9 ++++-----
> > >   drivers/video/fbdev/riva/riva_hw.c | 28 ++++++++--------------------
> > >   2 files changed, 12 insertions(+), 25 deletions(-)
> > > 
> > > diff --git a/drivers/video/fbdev/riva/fbdev.c b/drivers/video/fbdev/riva/fbdev.c
> > > index ce55b9d2e862..55554b0433cb 100644
> > > --- a/drivers/video/fbdev/riva/fbdev.c
> > > +++ b/drivers/video/fbdev/riva/fbdev.c
> > > @@ -464,7 +464,7 @@ static inline void reverse_order(u32 *l)
> > >   /**
> > >    * rivafb_load_cursor_image - load cursor image to hardware
> > > - * @data: address to monochrome bitmap (1 = foreground color, 0 = background)
> > > + * @data8: address to monochrome bitmap (1 = foreground color, 0 = background)
> > >    * @par:  pointer to private data
> > >    * @w:    width of cursor image in pixels
> > >    * @h:    height of cursor image in scanlines
> > > @@ -843,9 +843,9 @@ static void riva_update_var(struct fb_var_screeninfo *var,
> > >   /**
> > >    * rivafb_do_maximize -
> > >    * @info: pointer to fb_info object containing info for current riva board
> > > - * @var:
> > > - * @nom:
> > > - * @den:
> > > + * @var: standard kernel fb changeable data
> > > + * @nom: nom
> > > + * @den: den

Cop-out!

Do what I do and make something up (joke)! :'D

> > Well, it fixes the warning ;)
> 
> Yeah, I could not dig up anything useful to say here.
> Was tempted to just drop all the kernel-doc syntax but that
> was a larger change.

Did you trace it from it's origin down to it's final use?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog