From: Minwoo Im <minwoo.im.dev@gmail.com>
To: javier@javigon.com
Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
hch@lst.de, kbusch@kernel.org, sagi@grimberg.me,
"Javier González" <javier.gonz@samsung.com>
Subject: Re: [PATCH 2/4] nvme: rename controller base dev_t char device
Date: Tue, 1 Dec 2020 23:05:39 +0900 [thread overview]
Message-ID: <20201201140539.GC5138@localhost.localdomain> (raw)
In-Reply-To: <20201201125610.17138-3-javier.gonz@samsung.com>
Hello,
On 20-12-01 13:56:08, javier@javigon.com wrote:
> From: Javier González <javier.gonz@samsung.com>
>
> Rename controller base dev_t char device in preparation for adding a
> namespace char device.
>
> Signed-off-by: Javier González <javier.gonz@samsung.com>
I think it would be better to describe things about following patches
which represent why this kind of renaming is needed in this patch.
Anyway, looks good to me.
Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Minwoo Im <minwoo.im.dev@gmail.com>
To: javier@javigon.com
Cc: sagi@grimberg.me, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, kbusch@kernel.org,
"Javier González" <javier.gonz@samsung.com>,
hch@lst.de
Subject: Re: [PATCH 2/4] nvme: rename controller base dev_t char device
Date: Tue, 1 Dec 2020 23:05:39 +0900 [thread overview]
Message-ID: <20201201140539.GC5138@localhost.localdomain> (raw)
In-Reply-To: <20201201125610.17138-3-javier.gonz@samsung.com>
Hello,
On 20-12-01 13:56:08, javier@javigon.com wrote:
> From: Javier González <javier.gonz@samsung.com>
>
> Rename controller base dev_t char device in preparation for adding a
> namespace char device.
>
> Signed-off-by: Javier González <javier.gonz@samsung.com>
I think it would be better to describe things about following patches
which represent why this kind of renaming is needed in this patch.
Anyway, looks good to me.
Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-12-01 14:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 12:56 [PATCH 0/4] nvme: enable per-namespace char device javier
2020-12-01 12:56 ` javier
2020-12-01 12:56 ` [PATCH 1/4] nvme: remove unnecessary return values javier
2020-12-01 12:56 ` javier
2020-12-01 14:04 ` Minwoo Im
2020-12-01 14:04 ` Minwoo Im
2020-12-01 12:56 ` [PATCH 2/4] nvme: rename controller base dev_t char device javier
2020-12-01 12:56 ` javier
2020-12-01 14:05 ` Minwoo Im [this message]
2020-12-01 14:05 ` Minwoo Im
2020-12-01 12:56 ` [PATCH 3/4] nvme: rename bdev operations javier
2020-12-01 12:56 ` javier
2020-12-01 14:06 ` Minwoo Im
2020-12-01 14:06 ` Minwoo Im
2020-12-01 12:56 ` [PATCH 4/4] nvme: enable char device per namespace javier
2020-12-01 12:56 ` javier
2020-12-01 14:03 ` Minwoo Im
2020-12-01 14:03 ` Minwoo Im
2020-12-01 18:57 ` Javier González
2020-12-01 18:57 ` Javier González
2020-12-01 19:30 ` Keith Busch
2020-12-01 19:30 ` Keith Busch
2020-12-01 19:38 ` Christoph Hellwig
2020-12-01 19:38 ` Christoph Hellwig
2020-12-01 20:44 ` Javier González
2020-12-01 20:44 ` Javier González
2020-12-07 14:06 ` Christoph Hellwig
2020-12-07 14:06 ` Christoph Hellwig
2020-12-02 3:00 ` Minwoo Im
2020-12-02 3:00 ` Minwoo Im
2020-12-01 19:35 ` [PATCH 0/4] nvme: enable per-namespace char device Christoph Hellwig
2020-12-01 19:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201140539.GC5138@localhost.localdomain \
--to=minwoo.im.dev@gmail.com \
--cc=hch@lst.de \
--cc=javier.gonz@samsung.com \
--cc=javier@javigon.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.