From: Borislav Petkov <bp@alien8.de>
To: Rongwei Wang <rongwei.wang@linux.alibaba.com>
Cc: gshan@redhat.com, Anson.Huang@nxp.com, geert+renesas@glider.be,
catalin.marinas@arm.com, masahiroy@kernel.org,
linux-kernel@vger.kernel.org, michael@walle.cc, krzk@kernel.org,
bjorn.andersson@linaro.org, vkoul@kernel.org, olof@lixom.net,
shawnguo@kernel.org, vincenzo.frascino@arm.com,
Will Deacon <will@kernel.org>,
ardb@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/3] arm64:msr: Add MSR driver
Date: Tue, 1 Dec 2020 16:25:52 +0100 [thread overview]
Message-ID: <20201201152552.GD22927@zn.tnic> (raw)
In-Reply-To: <8ED75067-DB02-4502-BA03-45B3519E408A@linux.alibaba.com>
On Tue, Dec 01, 2020 at 11:17:39PM +0800, Rongwei Wang wrote:
> In ARM, the system registers can only be accessed through msr and mrs,
> so the problem created by MSR driver (depend on rdmsr and wrmsr) in
> x86 is not necessarily present in ARM, which is very different from
> x86.
No, the point I'm making is that it doesn't matter what the architecture
does or does not, register *writes* from userspace are a bad bad idea
for the reasons I described.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Rongwei Wang <rongwei.wang@linux.alibaba.com>
Cc: catalin.marinas@arm.com, Will Deacon <will@kernel.org>,
bjorn.andersson@linaro.org, shawnguo@kernel.org,
vkoul@kernel.org, geert+renesas@glider.be, Anson.Huang@nxp.com,
michael@walle.cc, krzk@kernel.org, olof@lixom.net,
vincenzo.frascino@arm.com, ardb@kernel.org, masahiroy@kernel.org,
gshan@redhat.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] arm64:msr: Add MSR driver
Date: Tue, 1 Dec 2020 16:25:52 +0100 [thread overview]
Message-ID: <20201201152552.GD22927@zn.tnic> (raw)
In-Reply-To: <8ED75067-DB02-4502-BA03-45B3519E408A@linux.alibaba.com>
On Tue, Dec 01, 2020 at 11:17:39PM +0800, Rongwei Wang wrote:
> In ARM, the system registers can only be accessed through msr and mrs,
> so the problem created by MSR driver (depend on rdmsr and wrmsr) in
> x86 is not necessarily present in ARM, which is very different from
> x86.
No, the point I'm making is that it doesn't matter what the architecture
does or does not, register *writes* from userspace are a bad bad idea
for the reasons I described.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-12-01 15:27 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 17:48 [PATCH 0/3] arm64:msr: Add MSR driver Rongwei Wang
2020-11-30 17:48 ` Rongwei Wang
2020-11-30 17:48 ` [PATCH 1/3] arm64:insn: Export symbols for MSR ARM driver Rongwei Wang
2020-11-30 17:48 ` Rongwei Wang
2020-11-30 17:48 ` [PATCH 2/3] arm64:msr: Introduce " Rongwei Wang
2020-11-30 17:48 ` Rongwei Wang
2020-11-30 23:14 ` kernel test robot
2020-11-30 17:48 ` [PATCH 3/3] arm64:msr: Enable " Rongwei Wang
2020-11-30 17:48 ` Rongwei Wang
2020-11-30 17:57 ` [PATCH 0/3] arm64:msr: Add MSR driver Will Deacon
2020-11-30 17:57 ` Will Deacon
2020-12-01 2:55 ` wangrongwei
2020-12-01 2:55 ` wangrongwei
2020-12-01 5:44 ` wangrongwei
2020-12-01 5:44 ` wangrongwei
2020-11-30 18:05 ` Marc Zyngier
2020-11-30 18:05 ` Marc Zyngier
2020-11-30 18:20 ` Randy Dunlap
2020-11-30 18:20 ` Randy Dunlap
2020-12-01 3:09 ` wangrongwei
2020-12-01 3:09 ` wangrongwei
2020-12-01 8:12 ` Marc Zyngier
2020-12-01 8:12 ` Marc Zyngier
2020-12-01 14:25 ` wangrongwei
2020-12-01 14:25 ` wangrongwei
2020-12-01 15:37 ` Marc Zyngier
2020-12-01 15:37 ` Marc Zyngier
2020-12-03 5:45 ` Rongwei Wang
2020-12-03 5:45 ` Rongwei Wang
2020-12-03 8:35 ` Marc Zyngier
2020-12-03 8:35 ` Marc Zyngier
2020-12-03 11:25 ` Rongwei Wang
2020-12-03 11:25 ` Rongwei Wang
2020-12-03 11:45 ` Marc Zyngier
2020-12-03 11:45 ` Marc Zyngier
2020-12-03 12:22 ` Rongwei Wang
2020-12-03 12:22 ` Rongwei Wang
2020-12-03 11:50 ` Mark Rutland
2020-12-03 11:50 ` Mark Rutland
2020-11-30 19:03 ` Borislav Petkov
2020-11-30 19:03 ` Borislav Petkov
2020-12-01 3:44 ` wangrongwei
2020-12-01 3:44 ` wangrongwei
2020-12-01 11:26 ` Borislav Petkov
2020-12-01 11:26 ` Borislav Petkov
2020-12-01 14:33 ` wangrongwei
2020-12-01 14:33 ` wangrongwei
2020-12-01 14:54 ` Borislav Petkov
2020-12-01 14:54 ` Borislav Petkov
2020-12-01 15:17 ` Rongwei Wang
2020-12-01 15:17 ` Rongwei Wang
2020-12-01 15:25 ` Borislav Petkov [this message]
2020-12-01 15:25 ` Borislav Petkov
2020-12-03 2:09 ` Rongwei Wang
2020-12-03 2:09 ` Rongwei Wang
2020-12-01 15:26 ` Ard Biesheuvel
2020-12-01 15:26 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201152552.GD22927@zn.tnic \
--to=bp@alien8.de \
--cc=Anson.Huang@nxp.com \
--cc=ardb@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=geert+renesas@glider.be \
--cc=gshan@redhat.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michael@walle.cc \
--cc=olof@lixom.net \
--cc=rongwei.wang@linux.alibaba.com \
--cc=shawnguo@kernel.org \
--cc=vincenzo.frascino@arm.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.