Re: [PATCH v4 2/7] drm/bridge: tfp410: Set input_bus_flags in atomic_check

From: kernel test robot <lkp@intel.com>
To: Nikhil Devshatwar <nikhil.nd@ti.com>,
	dri-devel@lists.freedesktop.org,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Boris Brezillon <bbrezillon@kernel.org>
Cc: clang-built-linux@googlegroups.com, kbuild-all@lists.01.org,
	Yuti Amonkar <yamonkar@cadence.com>, Sekhar Nori <nsekhar@ti.com>,
	Swapnil Jakhade <sjakhade@cadence.com>
Subject: Re: [PATCH v4 2/7] drm/bridge: tfp410: Set input_bus_flags in atomic_check
Date: Tue, 1 Dec 2020 22:29:42 +0800	[thread overview]
Message-ID: <202012012203.4dSXqdJG-lkp@intel.com> (raw)
In-Reply-To: <20201201121830.29704-3-nikhil.nd@ti.com>

[-- Attachment #1: Type: text/plain, Size: 3043 bytes --]

Hi Nikhil,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next drm-tip/drm-tip linus/master v5.10-rc6 next-20201201]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nikhil-Devshatwar/drm-tidss-Use-new-connector-model-for-tidss/20201201-202125
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: mips-randconfig-r023-20201201 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ac40a2d8f16b8a8c68fc811d67f647740e965cb8)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://github.com/0day-ci/linux/commit/936e9f4e0dd9ad362b11e4cb6a240cdaec2b8b28
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Nikhil-Devshatwar/drm-tidss-Use-new-connector-model-for-tidss/20201201-202125
        git checkout 936e9f4e0dd9ad362b11e4cb6a240cdaec2b8b28
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/bridge/ti-tfp410.c:236:5: warning: no previous prototype for function 'tfp410_atomic_check' [-Wmissing-prototypes]
   int tfp410_atomic_check(struct drm_bridge *bridge,
       ^
   drivers/gpu/drm/bridge/ti-tfp410.c:236:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int tfp410_atomic_check(struct drm_bridge *bridge,
   ^
   static 
   drivers/gpu/drm/bridge/ti-tfp410.c:248:1: error: non-void function does not return a value [-Werror,-Wreturn-type]
   }
   ^
   1 warning and 1 error generated.

vim +/tfp410_atomic_check +236 drivers/gpu/drm/bridge/ti-tfp410.c

   235	
 > 236	int tfp410_atomic_check(struct drm_bridge *bridge,
   237			    struct drm_bridge_state *bridge_state,
   238			    struct drm_crtc_state *crtc_state,
   239			    struct drm_connector_state *conn_state)
   240	{
   241		struct tfp410 *dvi = drm_bridge_to_tfp410(bridge);
   242	
   243		/*
   244		 * There might be flags negotiation supported in future
   245		 * Set the bus flags in atomic_check statically for now
   246		 */
   247		bridge_state->input_bus_cfg.flags = dvi->timings.input_bus_flags;
   248	}
   249	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 24386 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel