From: Krzysztof Kozlowski <krzk@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: robh@kernel.org, shawnguo@kernel.org, festevam@gmail.com,
catalin.marinas@arm.com, will@kernel.org,
georgi.djakov@linaro.org, cdleonard@gmail.com,
kernel@pengutronix.de, linux-imx@nxp.com, kernel@puri.sm,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Leonard Crestez <leonard.crestez@nxp.com>
Subject: Re: [PATCH v2 1/7] arm64: dts: imx8m: Add NOC nodes
Date: Wed, 2 Dec 2020 10:14:07 +0200 [thread overview]
Message-ID: <20201202081407.GA7157@kozik-lap> (raw)
In-Reply-To: <20201201123932.12312-2-martin.kepplinger@puri.sm>
On Tue, Dec 01, 2020 at 01:39:26PM +0100, Martin Kepplinger wrote:
> From: Leonard Crestez <leonard.crestez@nxp.com>
>
> Add initial support for dynamic frequency scaling of main NOC.
>
> Make DDRC the parent of the NOC (using passive governor) so that the
> main NOC is automatically scaled together with DDRC by default.
>
> Support for proactive scaling via interconnect will come on top.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> Tested-by: Martin Kepplinger <martin.kepplinger@puri.sm> (imx8mq)
> ---
> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 22 ++++++++++++++++++++++
> arch/arm64/boot/dts/freescale/imx8mn.dtsi | 22 ++++++++++++++++++++++
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
> 3 files changed, 66 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index c824f2615fe8..835b19f0ea42 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -921,6 +921,28 @@
>
> };
>
> + noc: interconnect@32700000 {
> + compatible = "fsl,imx8mm-noc", "fsl,imx8m-noc";
> + reg = <0x32700000 0x100000>;
> + clocks = <&clk IMX8MM_CLK_NOC>;
> + devfreq = <&ddrc>;
This does not pass the dtschema checks. Are you missing here any
dependencies?
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: interconnect@32700000: 'devfreq' does not match any of the regexes: 'pinctrl-[0-9]+'
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: robh@kernel.org, kernel@pengutronix.de, cdleonard@gmail.com,
devicetree@vger.kernel.org, shawnguo@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-imx@nxp.com, festevam@gmail.com, catalin.marinas@arm.com,
Leonard Crestez <leonard.crestez@nxp.com>,
will@kernel.org, georgi.djakov@linaro.org,
linux-arm-kernel@lists.infradead.org, kernel@puri.sm
Subject: Re: [PATCH v2 1/7] arm64: dts: imx8m: Add NOC nodes
Date: Wed, 2 Dec 2020 10:14:07 +0200 [thread overview]
Message-ID: <20201202081407.GA7157@kozik-lap> (raw)
In-Reply-To: <20201201123932.12312-2-martin.kepplinger@puri.sm>
On Tue, Dec 01, 2020 at 01:39:26PM +0100, Martin Kepplinger wrote:
> From: Leonard Crestez <leonard.crestez@nxp.com>
>
> Add initial support for dynamic frequency scaling of main NOC.
>
> Make DDRC the parent of the NOC (using passive governor) so that the
> main NOC is automatically scaled together with DDRC by default.
>
> Support for proactive scaling via interconnect will come on top.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> Tested-by: Martin Kepplinger <martin.kepplinger@puri.sm> (imx8mq)
> ---
> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 22 ++++++++++++++++++++++
> arch/arm64/boot/dts/freescale/imx8mn.dtsi | 22 ++++++++++++++++++++++
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
> 3 files changed, 66 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index c824f2615fe8..835b19f0ea42 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -921,6 +921,28 @@
>
> };
>
> + noc: interconnect@32700000 {
> + compatible = "fsl,imx8mm-noc", "fsl,imx8m-noc";
> + reg = <0x32700000 0x100000>;
> + clocks = <&clk IMX8MM_CLK_NOC>;
> + devfreq = <&ddrc>;
This does not pass the dtschema checks. Are you missing here any
dependencies?
arch/arm64/boot/dts/freescale/imx8mm-evk.dt.yaml: interconnect@32700000: 'devfreq' does not match any of the regexes: 'pinctrl-[0-9]+'
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-02 8:15 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 12:39 [PATCH v2 0/7] imx8mq: updates for the interconnect fabric Martin Kepplinger
2020-12-01 12:39 ` Martin Kepplinger
2020-12-01 12:39 ` [PATCH v2 1/7] arm64: dts: imx8m: Add NOC nodes Martin Kepplinger
2020-12-01 12:39 ` Martin Kepplinger
2020-12-01 12:56 ` Georgi Djakov
2020-12-01 12:56 ` Georgi Djakov
2020-12-02 8:14 ` Krzysztof Kozlowski [this message]
2020-12-02 8:14 ` Krzysztof Kozlowski
2020-12-01 12:39 ` [PATCH v2 2/7] arm64: dts: imx8mq: Add interconnect provider property Martin Kepplinger
2020-12-01 12:39 ` Martin Kepplinger
2020-12-01 12:39 ` [PATCH v2 3/7] arm64: dts: imx8mq: Add interconnect for lcdif Martin Kepplinger
2020-12-01 12:39 ` Martin Kepplinger
2020-12-01 12:39 ` [PATCH v2 4/7] dt-bindings: mxsfb: Add interconnect bindings for LCDIF path Martin Kepplinger
2020-12-01 12:39 ` Martin Kepplinger
2020-12-01 13:46 ` Guido Günther
2020-12-01 13:46 ` Guido Günther
2020-12-01 12:39 ` [PATCH v2 5/7] interconnect: imx8mq: Use icc_sync_state Martin Kepplinger
2020-12-01 12:39 ` Martin Kepplinger
2020-12-01 12:39 ` [PATCH v2 6/7] arm64: defconfig: updates for 5.10 Martin Kepplinger
2020-12-01 12:39 ` Martin Kepplinger
2020-12-02 8:30 ` Georgi Djakov
2020-12-02 8:30 ` Georgi Djakov
2020-12-01 12:39 ` [PATCH v2 7/7] arm64: defconfig: Enable interconnect for imx8mq Martin Kepplinger
2020-12-01 12:39 ` Martin Kepplinger
2020-12-01 13:10 ` Georgi Djakov
2020-12-01 13:10 ` Georgi Djakov
2020-12-01 13:15 ` Martin Kepplinger
2020-12-01 13:15 ` Martin Kepplinger
2020-12-02 8:03 ` Krzysztof Kozlowski
2020-12-02 8:03 ` Krzysztof Kozlowski
2020-12-02 8:05 ` Krzysztof Kozlowski
2020-12-02 8:05 ` Krzysztof Kozlowski
2020-12-02 11:27 ` Martin Kepplinger
2020-12-02 11:27 ` Martin Kepplinger
2020-12-02 12:23 ` Krzysztof Kozlowski
2020-12-02 12:23 ` Krzysztof Kozlowski
2020-12-02 8:02 ` Krzysztof Kozlowski
2020-12-02 8:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202081407.GA7157@kozik-lap \
--to=krzk@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=cdleonard@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=georgi.djakov@linaro.org \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.