All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wolfram Sang <wsa@kernel.org>,
	Seth Heasley <seth.heasley@intel.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	linux-i2c@vger.kernel.org,
	Mario Alejandro Posso Escobar <mario.posso.escobar@intel.com>
Subject: Re: [PATCH v1] i2c: ismt: Adding support for I2C_SMBUS_BLOCK_PROC_CALL
Date: Wed, 2 Dec 2020 18:23:22 +0200	[thread overview]
Message-ID: <20201202162322.GJ4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201202154501.GB13425@kunai>

On Wed, Dec 02, 2020 at 04:45:01PM +0100, Wolfram Sang wrote:
> On Mon, Nov 16, 2020 at 05:32:45PM +0200, Andy Shevchenko wrote:
> > From: Mario Alejandro Posso Escobar <mario.posso.escobar@intel.com>
> > 
> > Expand the driver to support I2C_SMBUS_BLOCK_PROC_CALL since
> > HW supports it already.
> > 
> > Co-developed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> I removed that. Andy's SoB should do.

It's against documentation, please return it back as a must by documentation [1].

> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Signed-off-by: Mario Alejandro Posso Escobar <mario.posso.escobar@intel.com>
> 
> Applied to for-next, thanks!

Thanks, but see above.

[1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

"..., every Co-developed-by: must be immediately followed by a Signed-off-by: of the associated co-author."

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2020-12-02 16:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-16 15:32 [PATCH v1] i2c: ismt: Adding support for I2C_SMBUS_BLOCK_PROC_CALL Andy Shevchenko
2020-12-02 15:45 ` Wolfram Sang
2020-12-02 16:00   ` Wolfram Sang
2020-12-02 16:24     ` Andy Shevchenko
2020-12-02 16:23   ` Andy Shevchenko [this message]
2020-12-02 16:25     ` Wolfram Sang
     [not found] <20201116153245.24083-1-andriy.shevchenko () linux ! intel ! com>
2020-12-03  8:51 ` Seth Heasley
2020-12-03 20:21   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201202162322.GJ4077@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=mario.posso.escobar@intel.com \
    --cc=nhorman@tuxdriver.com \
    --cc=seth.heasley@intel.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.