All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aditya Srivastava <yashsri421@gmail.com>
To: joe@perches.com
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
	linux-kernel@vger.kernel.org, yashsri421@gmail.com
Subject: [Linux-kernel-mentees] [PATCH -mmots] checkpatch: add fix for non-standard signature - co-authored-by
Date: Thu,  3 Dec 2020 00:00:45 +0530	[thread overview]
Message-ID: <20201202183045.9309-1-yashsri421@gmail.com> (raw)
In-Reply-To: <280235acc0e91365f3fd3b5be5a5244eced1ff61.camel@perches.com>

Currently, checkpatch.pl warns us for BAD_SIGN_OFF on the usage of
non-standard signatures.

An evaluation on v4.13..v5.8 showed that out of 539 warnings due to
non-standard signatures, 43 are due to the use of 'Co-authored-by'
tag, which may seem correct, but is not standard.

The standard signature equivalent for 'Co-authored-by' is
'Co-developed-by'.

Provide a fix by suggesting users with this signature alternative and
replacing.

Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
---
 scripts/checkpatch.pl | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4a026926139f..fc036d545d2d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2832,6 +2832,9 @@ sub process {
 
 			if ($sign_off !~ /$signature_tags/) {
 				my $suggested_signature = find_standard_signature($sign_off);
+				if ($sign_off =~ /co-authored-by:/i) {
+					$suggested_signature = "Co-developed-by:";
+				}
 				if ($suggested_signature eq "") {
 					WARN("BAD_SIGN_OFF",
 					     "Non-standard signature: $sign_off\n" . $herecurr);
-- 
2.17.1

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

WARNING: multiple messages have this Message-ID (diff)
From: Aditya Srivastava <yashsri421@gmail.com>
To: joe@perches.com
Cc: yashsri421@gmail.com, lukas.bulwahn@gmail.com,
	linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: [PATCH -mmots] checkpatch: add fix for non-standard signature - co-authored-by
Date: Thu,  3 Dec 2020 00:00:45 +0530	[thread overview]
Message-ID: <20201202183045.9309-1-yashsri421@gmail.com> (raw)
In-Reply-To: <280235acc0e91365f3fd3b5be5a5244eced1ff61.camel@perches.com>

Currently, checkpatch.pl warns us for BAD_SIGN_OFF on the usage of
non-standard signatures.

An evaluation on v4.13..v5.8 showed that out of 539 warnings due to
non-standard signatures, 43 are due to the use of 'Co-authored-by'
tag, which may seem correct, but is not standard.

The standard signature equivalent for 'Co-authored-by' is
'Co-developed-by'.

Provide a fix by suggesting users with this signature alternative and
replacing.

Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
---
 scripts/checkpatch.pl | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4a026926139f..fc036d545d2d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2832,6 +2832,9 @@ sub process {
 
 			if ($sign_off !~ /$signature_tags/) {
 				my $suggested_signature = find_standard_signature($sign_off);
+				if ($sign_off =~ /co-authored-by:/i) {
+					$suggested_signature = "Co-developed-by:";
+				}
 				if ($suggested_signature eq "") {
 					WARN("BAD_SIGN_OFF",
 					     "Non-standard signature: $sign_off\n" . $herecurr);
-- 
2.17.1


  reply	other threads:[~2020-12-02 18:31 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01 11:29 [Linux-kernel-mentees] [PATCH v5] checkpatch: add fix and improve warning msg for Non-standard signature Aditya Srivastava
2020-12-01 11:29 ` Aditya Srivastava
2020-12-01 17:24 ` [Linux-kernel-mentees] " Joe Perches
2020-12-01 17:24   ` Joe Perches
2020-12-01 18:21   ` [Linux-kernel-mentees] " Lukas Bulwahn
2020-12-01 18:21     ` Lukas Bulwahn
2020-12-01 18:39     ` [Linux-kernel-mentees] " Joe Perches
2020-12-01 18:39       ` Joe Perches
2020-12-02  9:08       ` [Linux-kernel-mentees] [PATCH] checkpatch: add fix for non-standard signature - co-authored-by Aditya Srivastava
2020-12-02  9:08         ` Aditya Srivastava
2020-12-02 17:16         ` [Linux-kernel-mentees] " Joe Perches
2020-12-02 17:16           ` Joe Perches
2020-12-02 18:30           ` Aditya Srivastava [this message]
2020-12-02 18:30             ` [PATCH -mmots] " Aditya Srivastava
2020-12-02 18:56             ` [Linux-kernel-mentees] " Joe Perches
2020-12-02 18:56               ` Joe Perches
2020-12-03  9:59               ` [Linux-kernel-mentees] " Aditya
2020-12-03  9:59                 ` Aditya
2020-12-03 10:59                 ` [Linux-kernel-mentees] " Lukas Bulwahn
2020-12-03 10:59                   ` Lukas Bulwahn
2020-12-03 12:23                   ` [Linux-kernel-mentees] " Aditya
2020-12-03 12:23                     ` Aditya
2020-12-03 18:57                   ` [Linux-kernel-mentees] " Greg KH
2020-12-03 18:57                     ` Greg KH
2020-12-03 19:00                     ` Lukas Bulwahn
2020-12-03 19:00                       ` Lukas Bulwahn
2020-12-03 19:25                       ` Greg KH
2020-12-03 19:25                         ` Greg KH
2020-12-03 19:31                         ` Joe Perches
2020-12-03 19:31                           ` Joe Perches
2020-12-04 17:10                   ` Aditya
2020-12-04 14:40                 ` [Linux-kernel-mentees] [PATCH v6] " Aditya Srivastava
2020-12-04 14:40                   ` Aditya Srivastava
2020-12-04 15:59                   ` [Linux-kernel-mentees] " Joe Perches
2020-12-04 15:59                     ` Joe Perches
2020-12-05 10:22                   ` Aditya
2020-12-05 12:03                     ` Joe Perches
2020-12-05 12:55                       ` [Linux-kernel-mentees] " Aditya
2020-12-05 12:55                         ` Aditya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201202183045.9309-1-yashsri421@gmail.com \
    --to=yashsri421@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.