From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: kernel test robot <lkp@intel.com>
Cc: linuxppc-dev@lists.ozlabs.org, kbuild-all@lists.01.org,
Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [powerpc:next-test 121/184] arch/powerpc/kernel/firmware.c:31:9-10: WARNING: return of 0/1 in function 'check_kvm_guest' with return type bool
Date: Thu, 3 Dec 2020 11:42:46 +0530 [thread overview]
Message-ID: <20201203061246.GG528281@linux.vnet.ibm.com> (raw)
In-Reply-To: <202012030759.zuEULDQ3-lkp@intel.com>
Hi,
Thanks for the report.
* kernel test robot <lkp@intel.com> [2020-12-03 07:25:06]:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next-test
> head: fb003959777a635dea8910cf71109b612c7f940c
> commit: 77354ecf8473208a5cc5f20a501760f7d6d631cd [121/184] powerpc: Rename is_kvm_guest() to check_kvm_guest()
Sorry for the nit pick, but the commit should have been
Commit 107c55005fbd ("powerpc/pseries: Add KVM guest doorbell restrictions")
because thats the patch that introduced is_kvm_guest.
my patch was just renaming is_kvm_guest to check_kvm_guest.
> config: powerpc-randconfig-c003-20201202 (attached as .config)
> compiler: powerpc64le-linux-gcc (GCC) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
>
> "coccinelle warnings: (new ones prefixed by >>)"
> >> arch/powerpc/kernel/firmware.c:31:9-10: WARNING: return of 0/1 in function 'check_kvm_guest' with return type bool
>
> Please review and possibly fold the followup patch.
>
But I agree we can still fold this the followup patch into the
Rename is_kvm_guest() to check_kvm_guest().
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
--
Thanks and Regards
Srikar Dronamraju
WARNING: multiple messages have this Message-ID (diff)
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: kbuild-all@lists.01.org
Subject: Re: [powerpc:next-test 121/184] arch/powerpc/kernel/firmware.c:31:9-10: WARNING: return of 0/1 in function 'check_kvm_guest' with return type bool
Date: Thu, 03 Dec 2020 11:42:46 +0530 [thread overview]
Message-ID: <20201203061246.GG528281@linux.vnet.ibm.com> (raw)
In-Reply-To: <202012030759.zuEULDQ3-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]
Hi,
Thanks for the report.
* kernel test robot <lkp@intel.com> [2020-12-03 07:25:06]:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next-test
> head: fb003959777a635dea8910cf71109b612c7f940c
> commit: 77354ecf8473208a5cc5f20a501760f7d6d631cd [121/184] powerpc: Rename is_kvm_guest() to check_kvm_guest()
Sorry for the nit pick, but the commit should have been
Commit 107c55005fbd ("powerpc/pseries: Add KVM guest doorbell restrictions")
because thats the patch that introduced is_kvm_guest.
my patch was just renaming is_kvm_guest to check_kvm_guest.
> config: powerpc-randconfig-c003-20201202 (attached as .config)
> compiler: powerpc64le-linux-gcc (GCC) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
>
> "coccinelle warnings: (new ones prefixed by >>)"
> >> arch/powerpc/kernel/firmware.c:31:9-10: WARNING: return of 0/1 in function 'check_kvm_guest' with return type bool
>
> Please review and possibly fold the followup patch.
>
But I agree we can still fold this the followup patch into the
Rename is_kvm_guest() to check_kvm_guest().
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2020-12-03 6:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 23:25 [powerpc:next-test 121/184] arch/powerpc/kernel/firmware.c:31:9-10: WARNING: return of 0/1 in function 'check_kvm_guest' with return type bool kernel test robot
2020-12-02 23:25 ` kernel test robot
2020-12-02 23:25 ` [PATCH] powerpc: fix boolreturn.cocci warnings kernel test robot
2020-12-02 23:25 ` kernel test robot
2020-12-03 6:12 ` Srikar Dronamraju [this message]
2020-12-03 6:12 ` [powerpc:next-test 121/184] arch/powerpc/kernel/firmware.c:31:9-10: WARNING: return of 0/1 in function 'check_kvm_guest' with return type bool Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203061246.GG528281@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=kbuild-all@lists.01.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.