All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org,
	Himadri Pandya <himadrispandya@gmail.com>,
	Johan Hovold <johan@kernel.org>
Subject: [PATCH 2/3] USB: core: drop short-transfer check from usb_control_msg_send()
Date: Fri,  4 Dec 2020 09:51:09 +0100	[thread overview]
Message-ID: <20201204085110.20055-3-johan@kernel.org> (raw)
In-Reply-To: <20201204085110.20055-1-johan@kernel.org>

A failure to send a complete control message is always an error so
there's no need to check for short transfers in usb_control_msg_send().

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/core/message.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
index a04b01247117..b08de9571f7a 100644
--- a/drivers/usb/core/message.c
+++ b/drivers/usb/core/message.c
@@ -216,9 +216,8 @@ int usb_control_msg_send(struct usb_device *dev, __u8 endpoint, __u8 request,
 
 	if (ret < 0)
 		return ret;
-	if (ret == size)
-		return 0;
-	return -EINVAL;
+
+	return 0;
 }
 EXPORT_SYMBOL_GPL(usb_control_msg_send);
 
-- 
2.26.2


  parent reply	other threads:[~2020-12-04  8:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04  8:51 [PATCH 0/3] USB: tweak the new control-message helpers Johan Hovold
2020-12-04  8:51 ` [PATCH 1/3] USB: core: drop pipe-type check from " Johan Hovold
2020-12-04 15:14   ` Greg Kroah-Hartman
2020-12-04 15:50     ` Johan Hovold
2020-12-06 11:20       ` Greg Kroah-Hartman
2020-12-06 16:25         ` Alan Stern
2020-12-07  9:46         ` Johan Hovold
2020-12-07 14:24           ` Greg Kroah-Hartman
2020-12-04  8:51 ` Johan Hovold [this message]
2020-12-04 15:17   ` [PATCH 2/3] USB: core: drop short-transfer check from usb_control_msg_send() Greg Kroah-Hartman
2020-12-04  8:51 ` [PATCH 3/3] USB: core: return -EREMOTEIO on short usb_control_msg_recv() Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201204085110.20055-3-johan@kernel.org \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=himadrispandya@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.