From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org,
Himadri Pandya <himadrispandya@gmail.com>,
Johan Hovold <johan@kernel.org>
Subject: [PATCH 3/3] USB: core: return -EREMOTEIO on short usb_control_msg_recv()
Date: Fri, 4 Dec 2020 09:51:10 +0100 [thread overview]
Message-ID: <20201204085110.20055-4-johan@kernel.org> (raw)
In-Reply-To: <20201204085110.20055-1-johan@kernel.org>
Return -EREMOTEIO instead of -EINVAL on short control transfers when
using the new usb_control_msg_recv() helper.
EINVAL is used to report invalid arguments (e.g. to the helper) and
should not be used for unrelated errors.
Many driver currently return -EIO on short control transfers but since
host-controller drivers already use -EREMOTEIO for short transfers
whenever the URB_SHORT_NOT_OK flag is set, let's use that here as well.
This also allows usb_control_msg_recv() to eventually use
URB_SHORT_NOT_OK without changing the return value again.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/core/message.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
index b08de9571f7a..30e9e680c74c 100644
--- a/drivers/usb/core/message.c
+++ b/drivers/usb/core/message.c
@@ -286,7 +286,7 @@ int usb_control_msg_recv(struct usb_device *dev, __u8 endpoint, __u8 request,
memcpy(driver_data, data, size);
ret = 0;
} else {
- ret = -EINVAL;
+ ret = -EREMOTEIO;
}
exit:
--
2.26.2
prev parent reply other threads:[~2020-12-04 8:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 8:51 [PATCH 0/3] USB: tweak the new control-message helpers Johan Hovold
2020-12-04 8:51 ` [PATCH 1/3] USB: core: drop pipe-type check from " Johan Hovold
2020-12-04 15:14 ` Greg Kroah-Hartman
2020-12-04 15:50 ` Johan Hovold
2020-12-06 11:20 ` Greg Kroah-Hartman
2020-12-06 16:25 ` Alan Stern
2020-12-07 9:46 ` Johan Hovold
2020-12-07 14:24 ` Greg Kroah-Hartman
2020-12-04 8:51 ` [PATCH 2/3] USB: core: drop short-transfer check from usb_control_msg_send() Johan Hovold
2020-12-04 15:17 ` Greg Kroah-Hartman
2020-12-04 8:51 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204085110.20055-4-johan@kernel.org \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=himadrispandya@gmail.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.