All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Snitselaar <jsnitsel@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	Matthew Garrett <mjg59@google.com>,
	Peter Huewe <peterhuewe@gmx.de>,
	linux-integrity@vger.kernel.org
Subject: [Intel-gfx] [PATCH v3 4/4] tpm_tis: Disable Interrupts on the ThinkPad L490
Date: Fri,  4 Dec 2020 18:43:40 -0700	[thread overview]
Message-ID: <20201205014340.148235-5-jsnitsel@redhat.com> (raw)
In-Reply-To: <20201205014340.148235-1-jsnitsel@redhat.com>

The interrupt storm detection code detects the issue on the ThinkPad
T490s, but the L490 still hangs at initialization. So swap out the
T490s for the L490 in the dmi check.

Cc: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Peter Huewe <peterhuewe@gmx.de>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Matthew Garrett <mjg59@google.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
---
 drivers/char/tpm/tpm_tis.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 4ed6e660273a..7322e0986a83 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -77,10 +77,10 @@ static int tpm_tis_disable_irq(const struct dmi_system_id *d)
 static const struct dmi_system_id tpm_tis_dmi_table[] = {
 	{
 		.callback = tpm_tis_disable_irq,
-		.ident = "ThinkPad T490s",
+		.ident = "ThinkPad L490",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-			DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T490s"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L490"),
 		},
 	},
 	{}
-- 
2.27.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jerry Snitselaar <jsnitsel@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-integrity@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	Jarkko Sakkinen <jarkko@kernel.org>,
	Jason Gunthorpe <jgg@ziepe.ca>, Peter Huewe <peterhuewe@gmx.de>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Matthew Garrett <mjg59@google.com>,
	Hans de Goede <hdegoede@redhat.com>
Subject: [PATCH v3 4/4] tpm_tis: Disable Interrupts on the ThinkPad L490
Date: Fri,  4 Dec 2020 18:43:40 -0700	[thread overview]
Message-ID: <20201205014340.148235-5-jsnitsel@redhat.com> (raw)
In-Reply-To: <20201205014340.148235-1-jsnitsel@redhat.com>

The interrupt storm detection code detects the issue on the ThinkPad
T490s, but the L490 still hangs at initialization. So swap out the
T490s for the L490 in the dmi check.

Cc: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Peter Huewe <peterhuewe@gmx.de>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Matthew Garrett <mjg59@google.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
---
 drivers/char/tpm/tpm_tis.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 4ed6e660273a..7322e0986a83 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -77,10 +77,10 @@ static int tpm_tis_disable_irq(const struct dmi_system_id *d)
 static const struct dmi_system_id tpm_tis_dmi_table[] = {
 	{
 		.callback = tpm_tis_disable_irq,
-		.ident = "ThinkPad T490s",
+		.ident = "ThinkPad L490",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-			DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T490s"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L490"),
 		},
 	},
 	{}
-- 
2.27.0


WARNING: multiple messages have this Message-ID (diff)
From: Jerry Snitselaar <jsnitsel@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Hans de Goede <hdegoede@redhat.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	Matthew Garrett <mjg59@google.com>,
	Peter Huewe <peterhuewe@gmx.de>,
	linux-integrity@vger.kernel.org
Subject: [PATCH v3 4/4] tpm_tis: Disable Interrupts on the ThinkPad L490
Date: Fri,  4 Dec 2020 18:43:40 -0700	[thread overview]
Message-ID: <20201205014340.148235-5-jsnitsel@redhat.com> (raw)
In-Reply-To: <20201205014340.148235-1-jsnitsel@redhat.com>

The interrupt storm detection code detects the issue on the ThinkPad
T490s, but the L490 still hangs at initialization. So swap out the
T490s for the L490 in the dmi check.

Cc: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Peter Huewe <peterhuewe@gmx.de>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Matthew Garrett <mjg59@google.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
---
 drivers/char/tpm/tpm_tis.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 4ed6e660273a..7322e0986a83 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -77,10 +77,10 @@ static int tpm_tis_disable_irq(const struct dmi_system_id *d)
 static const struct dmi_system_id tpm_tis_dmi_table[] = {
 	{
 		.callback = tpm_tis_disable_irq,
-		.ident = "ThinkPad T490s",
+		.ident = "ThinkPad L490",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-			DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T490s"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L490"),
 		},
 	},
 	{}
-- 
2.27.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-12-05  1:44 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-05  1:43 [Intel-gfx] [PATCH v3 0/4] tpm_tis: Detect interrupt storms Jerry Snitselaar
2020-12-05  1:43 ` Jerry Snitselaar
2020-12-05  1:43 ` Jerry Snitselaar
2020-12-05  1:43 ` [Intel-gfx] [PATCH v3 1/4] irq: export kstat_irqs Jerry Snitselaar
2020-12-05  1:43   ` Jerry Snitselaar
2020-12-05  1:43   ` Jerry Snitselaar
2020-12-05 10:39   ` [Intel-gfx] " Jarkko Sakkinen
2020-12-05 10:39     ` Jarkko Sakkinen
2020-12-05 10:39     ` Jarkko Sakkinen
2020-12-06 16:40     ` [Intel-gfx] " Thomas Gleixner
2020-12-06 16:40       ` Thomas Gleixner
2020-12-06 16:40       ` Thomas Gleixner
2020-12-06 17:40       ` [Intel-gfx] " James Bottomley
2020-12-06 17:40         ` James Bottomley
2020-12-06 17:40         ` James Bottomley
2020-12-06 19:29         ` [Intel-gfx] " Thomas Gleixner
2020-12-06 19:29           ` Thomas Gleixner
2020-12-06 19:29           ` Thomas Gleixner
2020-12-06 17:54   ` [Intel-gfx] " Thomas Gleixner
2020-12-06 17:54     ` Thomas Gleixner
2020-12-06 17:54     ` Thomas Gleixner
2020-12-06 21:46     ` [Intel-gfx] " Jerry Snitselaar
2020-12-06 21:46       ` Jerry Snitselaar
2020-12-06 21:46       ` Jerry Snitselaar
2020-12-05  1:43 ` [Intel-gfx] [PATCH v3 2/4] drm/i915/pmu: Use kstat_irqs to get interrupt count Jerry Snitselaar
2020-12-05  1:43   ` Jerry Snitselaar
2020-12-05  1:43   ` Jerry Snitselaar
2020-12-06 16:38   ` [Intel-gfx] " Thomas Gleixner
2020-12-06 16:38     ` Thomas Gleixner
2020-12-06 16:38     ` Thomas Gleixner
2020-12-06 21:33     ` [Intel-gfx] " Thomas Gleixner
2020-12-06 21:33       ` Thomas Gleixner
2020-12-06 21:33       ` Thomas Gleixner
2020-12-08  9:54       ` [Intel-gfx] " Jarkko Sakkinen
2020-12-08  9:54         ` Jarkko Sakkinen
2020-12-08  9:54         ` Jarkko Sakkinen
2020-12-06 21:47     ` [Intel-gfx] " Jerry Snitselaar
2020-12-06 21:47       ` Jerry Snitselaar
2020-12-06 21:47       ` Jerry Snitselaar
2020-12-06 23:38       ` [Intel-gfx] " Thomas Gleixner
2020-12-06 23:38         ` Thomas Gleixner
2020-12-06 23:38         ` Thomas Gleixner
2020-12-10  7:53     ` [Intel-gfx] " Joonas Lahtinen
2020-12-10  7:53       ` Joonas Lahtinen
2020-12-10  7:53       ` Joonas Lahtinen
2020-12-10 10:45       ` Tvrtko Ursulin
2020-12-10 10:45         ` Tvrtko Ursulin
2020-12-10 10:45         ` Tvrtko Ursulin
2020-12-10 16:35         ` Thomas Gleixner
2020-12-10 16:35           ` Thomas Gleixner
2020-12-10 16:35           ` Thomas Gleixner
2020-12-10 17:09           ` Tvrtko Ursulin
2020-12-10 17:09             ` Tvrtko Ursulin
2020-12-10 17:09             ` Tvrtko Ursulin
2020-12-10 17:44             ` Thomas Gleixner
2020-12-10 17:44               ` Thomas Gleixner
2020-12-10 17:44               ` Thomas Gleixner
2020-12-10 17:51               ` Tvrtko Ursulin
2020-12-10 17:51                 ` Tvrtko Ursulin
2020-12-10 17:51                 ` Tvrtko Ursulin
2020-12-05  1:43 ` [Intel-gfx] [PATCH v3 3/4] tpm_tis: Disable interrupts if interrupt storm detected Jerry Snitselaar
2020-12-05  1:43   ` Jerry Snitselaar
2020-12-05  1:43   ` Jerry Snitselaar
2020-12-06 19:26   ` [Intel-gfx] " Thomas Gleixner
2020-12-06 19:26     ` Thomas Gleixner
2020-12-06 19:26     ` Thomas Gleixner
2020-12-07 19:28     ` Jason Gunthorpe
2020-12-07 19:28       ` Jason Gunthorpe
2020-12-07 19:58       ` [Intel-gfx] " James Bottomley
2020-12-07 19:58         ` James Bottomley
2020-12-07 19:58         ` James Bottomley
2020-12-08 17:43         ` [Intel-gfx] " Jarkko Sakkinen
2020-12-08 17:43           ` Jarkko Sakkinen
2020-12-08 17:43           ` Jarkko Sakkinen
2020-12-08 17:42       ` [Intel-gfx] " Jarkko Sakkinen
2020-12-08 17:42         ` Jarkko Sakkinen
2020-12-08 17:42         ` Jarkko Sakkinen
2020-12-05  1:43 ` Jerry Snitselaar [this message]
2020-12-05  1:43   ` [PATCH v3 4/4] tpm_tis: Disable Interrupts on the ThinkPad L490 Jerry Snitselaar
2020-12-05  1:43   ` Jerry Snitselaar
2020-12-05  1:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for tpm_tis: Detect interrupt storms Patchwork
2020-12-05  2:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-12-05  5:32 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-12-06 19:50 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for tpm_tis: Detect interrupt storms (rev2) Patchwork
2020-12-06 19:51 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-12-06 20:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-12-06 21:59 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201205014340.148235-5-jsnitsel@redhat.com \
    --to=jsnitsel@redhat.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@google.com \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.