All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: herbert@gondor.apana.org.au, mripard@kernel.org, wens@csie.org,
	linux-arm-kernel@lists.infradead.org,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jens Axboe <axboe@kernel.dk>,
	linux-mm@kvack.org, Andrew Morton <akpm@linuxfoundation.org>,
	Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: crypto: sun4i-ss: error with kmap
Date: Sun, 6 Dec 2020 22:40:53 +0100	[thread overview]
Message-ID: <20201206214053.GA8458@Red> (raw)
In-Reply-To: <87mtys8268.fsf@nanos.tec.linutronix.de>

On Sat, Dec 05, 2020 at 08:48:15PM +0100, Thomas Gleixner wrote:
> Corentin,
> 
> On Sat, Dec 05 2020 at 19:43, Corentin Labbe wrote:
> > On Fri, Dec 04, 2020 at 09:58:21PM +0100, Thomas Gleixner wrote:
> >> Can you please replace the debug patch with the one below and try again?
> >> That stops the trace right on the condition.
> >
> > Hello, the result could be found at http://kernel.montjoie.ovh/130739.log
> 
> Thanks for providing this. This is clearly showing where stuff goes
> wrong. It starts here at 729.550001. I removed the uninteresting parts:
> 
> 0d..2 147103293us : __kmap_local_page_prot <-sg_miter_next
> 0d..3 147103308us :__kmap_local_pfn_prot: kmap_local_pfn: 1 ffefd000
> 
> 0d..3 147103311us : __kmap_local_page_prot <-sg_miter_next
> 0d..4 147103325us : __kmap_local_pfn_prot: kmap_local_pfn: 3 ffefb000
> 
> 0d..3 147103429us : kunmap_local_indexed <-sg_miter_stop
> 0d..4 147103433us : kunmap_local_indexed: kunmap_local: 3 ffefd000
> 
> So this maps two pages and unmaps the first one. That's all called from
> sun4i_ss_opti_poll() and the bug is clearly visible there:
> 
> 	sg_miter_next(&mi);
> 	sg_miter_next(&mo);
> 
> release_ss:
> 	sg_miter_stop(&mi);
> 	sg_miter_stop(&mo);
> 
> Written by yourself :) Same issue in sun4i_ss_cipher_poll()
> 
> Fix below.
> 

Unfortunatly, the crash still happen with the fix.
See http://kernel.montjoie.ovh/131321.log

WARNING: multiple messages have this Message-ID (diff)
From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	herbert@gondor.apana.org.au, Julia Lawall <julia.lawall@lip6.fr>,
	linux-kernel@vger.kernel.org, mripard@kernel.org,
	linux-mm@kvack.org, wens@csie.org, linux-crypto@vger.kernel.org,
	Andrew Morton <akpm@linuxfoundation.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: crypto: sun4i-ss: error with kmap
Date: Sun, 6 Dec 2020 22:40:53 +0100	[thread overview]
Message-ID: <20201206214053.GA8458@Red> (raw)
In-Reply-To: <87mtys8268.fsf@nanos.tec.linutronix.de>

On Sat, Dec 05, 2020 at 08:48:15PM +0100, Thomas Gleixner wrote:
> Corentin,
> 
> On Sat, Dec 05 2020 at 19:43, Corentin Labbe wrote:
> > On Fri, Dec 04, 2020 at 09:58:21PM +0100, Thomas Gleixner wrote:
> >> Can you please replace the debug patch with the one below and try again?
> >> That stops the trace right on the condition.
> >
> > Hello, the result could be found at http://kernel.montjoie.ovh/130739.log
> 
> Thanks for providing this. This is clearly showing where stuff goes
> wrong. It starts here at 729.550001. I removed the uninteresting parts:
> 
> 0d..2 147103293us : __kmap_local_page_prot <-sg_miter_next
> 0d..3 147103308us :__kmap_local_pfn_prot: kmap_local_pfn: 1 ffefd000
> 
> 0d..3 147103311us : __kmap_local_page_prot <-sg_miter_next
> 0d..4 147103325us : __kmap_local_pfn_prot: kmap_local_pfn: 3 ffefb000
> 
> 0d..3 147103429us : kunmap_local_indexed <-sg_miter_stop
> 0d..4 147103433us : kunmap_local_indexed: kunmap_local: 3 ffefd000
> 
> So this maps two pages and unmaps the first one. That's all called from
> sun4i_ss_opti_poll() and the bug is clearly visible there:
> 
> 	sg_miter_next(&mi);
> 	sg_miter_next(&mo);
> 
> release_ss:
> 	sg_miter_stop(&mi);
> 	sg_miter_stop(&mo);
> 
> Written by yourself :) Same issue in sun4i_ss_cipher_poll()
> 
> Fix below.
> 

Unfortunatly, the crash still happen with the fix.
See http://kernel.montjoie.ovh/131321.log

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-12-06 21:42 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01 13:01 crypto: sun4i-ss: error with kmap Corentin Labbe
2020-12-01 13:01 ` Corentin Labbe
2020-12-01 13:28 ` Thomas Gleixner
2020-12-01 13:28   ` Thomas Gleixner
2020-12-01 13:52   ` Corentin Labbe
2020-12-01 13:52     ` Corentin Labbe
2020-12-01 14:16     ` Thomas Gleixner
2020-12-01 14:16       ` Thomas Gleixner
2020-12-01 14:45       ` Corentin Labbe
2020-12-01 14:45         ` Corentin Labbe
2020-12-01 15:15         ` Thomas Gleixner
2020-12-01 15:15           ` Thomas Gleixner
2020-12-02 19:55           ` Corentin Labbe
2020-12-02 19:55             ` Corentin Labbe
2020-12-02 20:59             ` Thomas Gleixner
2020-12-02 20:59               ` Thomas Gleixner
2020-12-03 17:38               ` Corentin Labbe
2020-12-03 17:38                 ` Corentin Labbe
2020-12-03 23:34                 ` Thomas Gleixner
2020-12-03 23:34                   ` Thomas Gleixner
2020-12-03 23:34                   ` Thomas Gleixner
2020-12-04 13:26                   ` Corentin Labbe
2020-12-04 13:26                     ` Corentin Labbe
2020-12-04 15:08                     ` Thomas Gleixner
2020-12-04 15:08                       ` Thomas Gleixner
2020-12-04 19:27                       ` Corentin Labbe
2020-12-04 19:27                         ` Corentin Labbe
2020-12-04 20:58                         ` Thomas Gleixner
2020-12-04 20:58                           ` Thomas Gleixner
2020-12-05 18:43                           ` Corentin Labbe
2020-12-05 18:43                             ` Corentin Labbe
2020-12-05 19:48                             ` Thomas Gleixner
2020-12-05 19:48                               ` Thomas Gleixner
2020-12-05 19:48                               ` Thomas Gleixner
2020-12-05 20:16                               ` Julia Lawall
2020-12-05 20:16                                 ` Julia Lawall
2020-12-06 21:40                               ` Corentin Labbe [this message]
2020-12-06 21:40                                 ` Corentin Labbe
2020-12-07  0:15                                 ` Thomas Gleixner
2020-12-07  0:15                                   ` Thomas Gleixner
2020-12-07  0:15                                   ` Thomas Gleixner
2020-12-07 12:18                                   ` Corentin Labbe
2020-12-07 12:18                                     ` Corentin Labbe
2020-12-07 15:53                                     ` Thomas Gleixner
2020-12-07 15:53                                       ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201206214053.GA8458@Red \
    --to=clabbe.montjoie@gmail.com \
    --cc=akpm@linuxfoundation.org \
    --cc=axboe@kernel.dk \
    --cc=herbert@gondor.apana.org.au \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mripard@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.