From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: [intel-tdx:guest 49/60] drivers/acpi/svkl.c:165 acpi_svkl_init() warn: '&acpi_svkl_dev' not released on lines: 158.
Date: Mon, 07 Dec 2020 12:37:11 +0300 [thread overview]
Message-ID: <20201207093711.GT2767@kadam> (raw)
[-- Attachment #1: Type: text/plain, Size: 2953 bytes --]
tree: https://github.com/intel/tdx.git guest
head: f421c3155e99854fdd23334c21f62240448c4dfc
commit: 894a86dd4b8d4b2e851493155ac53071bf821611 [49/60] ACPI: Add SVKL table support
config: i386-randconfig-m021-20201204 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/acpi/svkl.c:165 acpi_svkl_init() warn: '&acpi_svkl_dev' not released on lines: 158.
vim +165 drivers/acpi/svkl.c
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 141 static int __init acpi_svkl_init(void)
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 142 {
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 143 acpi_status status = AE_OK;
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 144 int ret;
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 145
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 146 ret = misc_register(&acpi_svkl_dev);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 147 if (ret) {
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 148 pr_err("SVKL: can't misc_register on minor=%d\n",
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 149 MISC_DYNAMIC_MINOR);
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 150 return ret;
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 151 }
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 152
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 153 mutex_init(&svkl_lock);
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 154
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 155 status = acpi_get_table(ACPI_SIG_SVKL, 0, &svkl_tbl_hdr);
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 156 if (ACPI_FAILURE(status) || !svkl_tbl_hdr) {
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 157 pr_err("get table failed\n");
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 158 return -ENODEV;
misc_deregister(&acpi_svkl_dev); before returning.
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 159 }
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 160
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 161 dump_svkl_header();
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 162
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 163 pr_info("ACPI: SVKL module loaded\n");
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 164
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 @165 return 0;
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 166 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32766 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: [intel-tdx:guest 49/60] drivers/acpi/svkl.c:165 acpi_svkl_init() warn: '&acpi_svkl_dev' not released on lines: 158.
Date: Mon, 07 Dec 2020 12:37:11 +0300 [thread overview]
Message-ID: <20201207093711.GT2767@kadam> (raw)
[-- Attachment #1: Type: text/plain, Size: 2953 bytes --]
tree: https://github.com/intel/tdx.git guest
head: f421c3155e99854fdd23334c21f62240448c4dfc
commit: 894a86dd4b8d4b2e851493155ac53071bf821611 [49/60] ACPI: Add SVKL table support
config: i386-randconfig-m021-20201204 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/acpi/svkl.c:165 acpi_svkl_init() warn: '&acpi_svkl_dev' not released on lines: 158.
vim +165 drivers/acpi/svkl.c
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 141 static int __init acpi_svkl_init(void)
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 142 {
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 143 acpi_status status = AE_OK;
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 144 int ret;
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 145
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 146 ret = misc_register(&acpi_svkl_dev);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 147 if (ret) {
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 148 pr_err("SVKL: can't misc_register on minor=%d\n",
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 149 MISC_DYNAMIC_MINOR);
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 150 return ret;
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 151 }
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 152
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 153 mutex_init(&svkl_lock);
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 154
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 155 status = acpi_get_table(ACPI_SIG_SVKL, 0, &svkl_tbl_hdr);
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 156 if (ACPI_FAILURE(status) || !svkl_tbl_hdr) {
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 157 pr_err("get table failed\n");
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 158 return -ENODEV;
misc_deregister(&acpi_svkl_dev); before returning.
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 159 }
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 160
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 161 dump_svkl_header();
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 162
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 163 pr_info("ACPI: SVKL module loaded\n");
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 164
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 @165 return 0;
894a86dd4b8d4b2 Kuppuswamy Sathyanarayanan 2020-06-19 166 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32766 bytes --]
next reply other threads:[~2020-12-07 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 9:37 Dan Carpenter [this message]
2020-12-07 9:37 ` [intel-tdx:guest 49/60] drivers/acpi/svkl.c:165 acpi_svkl_init() warn: '&acpi_svkl_dev' not released on lines: 158 Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2020-12-05 8:37 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207093711.GT2767@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.