From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH net-next 06/13] net_failover: hold the netdev lists lock when retrieving device statistics
Date: Mon, 07 Dec 2020 10:22:24 +0800 [thread overview]
Message-ID: <202012071007.94pMN5y4-lkp@intel.com> (raw)
In-Reply-To: <20201206235919.393158-7-vladimir.oltean@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 3352 bytes --]
Hi Vladimir,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/Make-ndo_get_stats64-sleepable/20201207-080606
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 4054eebf0fb07b010098adcdea1e1d3978490b9a
config: i386-randconfig-s001-20201207 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-179-ga00755aa-dirty
# https://github.com/0day-ci/linux/commit/6ffc75ea1bd719ef7329193f8e3bd056ae0cc9ab
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Vladimir-Oltean/Make-ndo_get_stats64-sleepable/20201207-080606
git checkout 6ffc75ea1bd719ef7329193f8e3bd056ae0cc9ab
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
"sparse warnings: (new ones prefixed by >>)"
>> drivers/net/net_failover.c:195:19: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct net_device *slave_dev @@ got struct net_device [noderef] __rcu *primary_dev @@
drivers/net/net_failover.c:195:19: sparse: expected struct net_device *slave_dev
drivers/net/net_failover.c:195:19: sparse: got struct net_device [noderef] __rcu *primary_dev
>> drivers/net/net_failover.c:202:19: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct net_device *slave_dev @@ got struct net_device [noderef] __rcu *standby_dev @@
drivers/net/net_failover.c:202:19: sparse: expected struct net_device *slave_dev
drivers/net/net_failover.c:202:19: sparse: got struct net_device [noderef] __rcu *standby_dev
vim +195 drivers/net/net_failover.c
181
182 static void net_failover_get_stats(struct net_device *dev,
183 struct rtnl_link_stats64 *stats)
184 {
185 struct net_failover_info *nfo_info = netdev_priv(dev);
186 const struct rtnl_link_stats64 *new;
187 struct net *net = dev_net(dev);
188 struct rtnl_link_stats64 temp;
189 struct net_device *slave_dev;
190
191 mutex_lock(&net->netdev_lists_lock);
192
193 memcpy(stats, &nfo_info->failover_stats, sizeof(*stats));
194
> 195 slave_dev = nfo_info->primary_dev;
196 if (slave_dev) {
197 new = dev_get_stats(slave_dev, &temp);
198 net_failover_fold_stats(stats, new, &nfo_info->primary_stats);
199 memcpy(&nfo_info->primary_stats, new, sizeof(*new));
200 }
201
> 202 slave_dev = nfo_info->standby_dev;
203 if (slave_dev) {
204 new = dev_get_stats(slave_dev, &temp);
205 net_failover_fold_stats(stats, new, &nfo_info->standby_stats);
206 memcpy(&nfo_info->standby_stats, new, sizeof(*new));
207 }
208
209 memcpy(&nfo_info->failover_stats, stats, sizeof(*stats));
210
211 mutex_unlock(&net->netdev_lists_lock);
212 }
213
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38615 bytes --]
next prev parent reply other threads:[~2020-12-07 2:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 23:59 [RFC PATCH net-next 00/13] Make .ndo_get_stats64 sleepable Vladimir Oltean
2020-12-06 23:59 ` [RFC PATCH net-next 01/13] RDMA/mlx4: remove bogus dev_base_lock usage Vladimir Oltean
2020-12-08 6:43 ` Leon Romanovsky
2020-12-06 23:59 ` [RFC PATCH net-next 02/13] net: mark dev_base_lock for deprecation Vladimir Oltean
2020-12-06 23:59 ` [RFC PATCH net-next 03/13] net: introduce a mutex for the netns interface lists Vladimir Oltean
2020-12-06 23:59 ` [RFC PATCH net-next 04/13] s390/appldata_net_sum: hold the netdev lists lock when retrieving device statistics Vladimir Oltean
2020-12-06 23:59 ` [RFC PATCH net-next 05/13] net: bonding: " Vladimir Oltean
2020-12-07 1:00 ` Vladimir Oltean
2020-12-07 15:22 ` Vladimir Oltean
2020-12-08 23:57 ` Jakub Kicinski
2020-12-09 0:03 ` Vladimir Oltean
2020-12-09 0:17 ` Jakub Kicinski
2020-12-09 1:14 ` Vladimir Oltean
2020-12-09 1:28 ` Vladimir Oltean
2020-12-06 23:59 ` [RFC PATCH net-next 06/13] net_failover: " Vladimir Oltean
2020-12-07 2:22 ` kernel test robot [this message]
2020-12-06 23:59 ` [RFC PATCH net-next 07/13] parisc/led: remove trailing whitespaces Vladimir Oltean
2020-12-06 23:59 ` [RFC PATCH net-next 08/13] parisc/led: reindent the code that gathers device statistics Vladimir Oltean
2020-12-06 23:59 ` [RFC PATCH net-next 09/13] parisc/led: hold the netdev lists lock when retrieving " Vladimir Oltean
2020-12-07 6:14 ` kernel test robot
2020-12-06 23:59 ` [RFC PATCH net-next 10/13] net: procfs: " Vladimir Oltean
2020-12-06 23:59 ` [RFC PATCH net-next 11/13] net: sysfs: don't hold dev_base_lock while " Vladimir Oltean
2020-12-06 23:59 ` [RFC PATCH net-next 12/13] net: mark ndo_get_stats64 as being able to sleep Vladimir Oltean
2020-12-06 23:59 ` [RFC PATCH net-next 13/13] net: remove obsolete comments about ndo_get_stats64 context from eth drivers Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012071007.94pMN5y4-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.