Re: [RFC PATCH net-next 09/13] parisc/led: hold the netdev lists lock when retrieving device statistics

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3518 bytes --]

Hi Vladimir,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Vladimir-Oltean/Make-ndo_get_stats64-sleepable/20201207-080606
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 4054eebf0fb07b010098adcdea1e1d3978490b9a
config: parisc-randconfig-c004-20201207 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4c4eb38dca7fc52d77a0b9f2866090f780a6bc2d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Vladimir-Oltean/Make-ndo_get_stats64-sleepable/20201207-080606
        git checkout 4c4eb38dca7fc52d77a0b9f2866090f780a6bc2d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/parisc/led.c: In function 'led_get_net_activity':
>> drivers/parisc/led.c:359:22: error: invalid type argument of '->' (have 'struct net')
     359 |  mutex_lock(&init_net->netdev_lists_lock);
         |                      ^~
   drivers/parisc/led.c:379:24: error: invalid type argument of '->' (have 'struct net')
     379 |  mutex_unlock(&init_net->netdev_lists_lock);
         |                        ^~

vim +359 drivers/parisc/led.c

   336	
   337	
   338	/*
   339	   **
   340	   ** led_get_net_activity()
   341	   **
   342	   ** calculate if there was TX- or RX-throughput on the network interfaces
   343	   ** (analog to dev_get_info() from net/core/dev.c)
   344	   **
   345	 */
   346	static __inline__ int led_get_net_activity(void)
   347	{
   348	#ifndef CONFIG_NET
   349		return 0;
   350	#else
   351		static u64 rx_total_last, tx_total_last;
   352		u64 rx_total, tx_total;
   353		struct net_device *dev;
   354		int retval;
   355	
   356		rx_total = tx_total = 0;
   357	
   358		/* we are running as a workqueue task, so we can sleep */
 > 359		mutex_lock(&init_net->netdev_lists_lock);
   360	
   361		for_each_netdev(&init_net, dev) {
   362			struct in_device *in_dev = in_dev_get(dev);
   363			const struct rtnl_link_stats64 *stats;
   364			struct rtnl_link_stats64 temp;
   365	
   366			if (!in_dev || !in_dev->ifa_list ||
   367			    ipv4_is_loopback(in_dev->ifa_list->ifa_local)) {
   368				in_dev_put(in_dev);
   369				continue;
   370			}
   371	
   372			in_dev_put(in_dev);
   373	
   374			stats = dev_get_stats(dev, &temp);
   375			rx_total += stats->rx_packets;
   376			tx_total += stats->tx_packets;
   377		}
   378	
   379		mutex_unlock(&init_net->netdev_lists_lock);
   380	
   381		retval = 0;
   382	
   383		if (rx_total != rx_total_last) {
   384			rx_total_last = rx_total;
   385			retval |= LED_LAN_RCV;
   386		}
   387	
   388		if (tx_total != tx_total_last) {
   389			tx_total_last = tx_total;
   390			retval |= LED_LAN_TX;
   391		}
   392	
   393		return retval;
   394	#endif
   395	}
   396	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26870 bytes --]