From: Steven Rostedt <rostedt@goodmis.org>
To: Avri Altman <Avri.Altman@wdc.com>
Cc: Bean Huo <huobean@gmail.com>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"tomas.winkler@intel.com" <tomas.winkler@intel.com>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM
Date: Mon, 7 Dec 2020 10:37:08 -0500 [thread overview]
Message-ID: <20201207103708.66897ef3@gandalf.local.home> (raw)
In-Reply-To: <DM6PR04MB6575197B8626D3F91C9231C4FCCE0@DM6PR04MB6575.namprd04.prod.outlook.com>
On Mon, 7 Dec 2020 07:57:27 +0000
Avri Altman <Avri.Altman@wdc.com> wrote:
> >
> > TP_printk(
> > - "%s: %s: HDR:%s, CDB:%s",
> > + "%s: %s: HDR:%s, %s:%s",
> > __get_str(str), __get_str(dev_name),
> > __print_hex(__entry->hdr, sizeof(__entry->hdr)),
> > + __get_str(tsf_type),
> This breaks what current parsers expects.
> Why str is not enough to distinguish between the command?
Hopefully it shouldn't. Reading from user space should use the
libtraceevent library, that reads the format files and extracts the raw
data to find the fields. As long as the field exists, it should not break
user space parsers. If it does, please let me know, and I'll gladly help
change the user space code to use libtraceevent :-)
-- Steve
next prev parent reply other threads:[~2020-12-07 15:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 16:42 [PATCH v1 0/3] Three fixes for the UPIU trace Bean Huo
2020-12-06 16:42 ` [PATCH v1 1/3] scsi: ufs: Distinguish between query REQ and query RSP in query trace Bean Huo
2020-12-06 18:51 ` Bart Van Assche
2020-12-07 7:45 ` Avri Altman
2020-12-07 15:21 ` Steven Rostedt
2020-12-08 21:30 ` Bean Huo
2020-12-06 16:42 ` [PATCH v1 2/3] scsi: ufs: Distinguish between TM request UPIU and response UPIU in TM UPIU trace Bean Huo
2020-12-06 18:52 ` Bart Van Assche
2020-12-07 7:49 ` Avri Altman
2020-12-06 16:42 ` [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM Bean Huo
2020-12-07 7:57 ` Avri Altman
2020-12-07 11:14 ` Bean Huo
2020-12-08 8:35 ` Avri Altman
2020-12-08 21:42 ` Bean Huo
2020-12-07 15:37 ` Steven Rostedt [this message]
2020-12-07 16:40 ` Avri Altman
2020-12-07 17:27 ` Steven Rostedt
2020-12-08 8:03 ` Avri Altman
2020-12-07 15:34 ` Steven Rostedt
2020-12-08 21:36 ` Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207103708.66897ef3@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=Avri.Altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=huobean@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.