From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Sargun Dhillon <sargun@sargun.me>,
linux-unionfs@vger.kernel.org, miklos@szeredi.hu,
Alexander Viro <viro@zeniv.linux.org.uk>,
Amir Goldstein <amir73il@gmail.com>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
Sargun Dhillon <sargun@sargun.me>,
Giuseppe Scrivano <gscrivan@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
Daniel J Walsh <dwalsh@redhat.com>,
linux-fsdevel@vger.kernel.org,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH v2 3/4] overlay: Add the ability to remount volatile directories when safe
Date: Mon, 7 Dec 2020 14:39:54 +0300 [thread overview]
Message-ID: <20201207113954.GW2767@kadam> (raw)
In-Reply-To: <20201127092058.15117-4-sargun@sargun.me>
[-- Attachment #1: Type: text/plain, Size: 2555 bytes --]
Hi Sargun,
url: https://github.com/0day-ci/linux/commits/Sargun-Dhillon/Make-overlayfs-volatile-mounts-reusable/20201127-172416
base: be4df0cea08a8b59eb38d73de988b7ba8022df41
config: x86_64-randconfig-m001-20201127 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
fs/overlayfs/readdir.c:1149 ovl_check_incompat() error: uninitialized symbol 'd'.
vim +/d +1149 fs/overlayfs/readdir.c
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1129 static int ovl_check_incompat(struct ovl_fs *ofs, struct ovl_cache_entry *p,
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1130 struct path *path)
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1131 {
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1132 int err = -EINVAL;
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1133 struct dentry *d;
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1134
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1135 if (!strcmp(p->name, OVL_VOLATILEDIR_NAME)) {
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1136 d = lookup_one_len(p->name, path->dentry, p->len);
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1137 if (IS_ERR(d))
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1138 return PTR_ERR(d);
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1139
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1140 err = ovl_verify_volatile_info(ofs, d);
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1141 dput(d);
^^^^^^^
dput() d here.
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1142 }
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1143
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1144 if (err == -EINVAL)
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1145 pr_err("incompat feature '%s' cannot be mounted\n", p->name);
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1146 else
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1147 pr_debug("incompat '%s' handled: %d\n", p->name, err);
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1148
a9871ab1de6c660 Sargun Dhillon 2020-11-27 @1149 dput(d);
^^^^^^
"d" is uninitialized and this is probably a double free.
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1150 return err;
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1151 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32026 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v2 3/4] overlay: Add the ability to remount volatile directories when safe
Date: Mon, 07 Dec 2020 14:39:54 +0300 [thread overview]
Message-ID: <20201207113954.GW2767@kadam> (raw)
In-Reply-To: <20201127092058.15117-4-sargun@sargun.me>
[-- Attachment #1: Type: text/plain, Size: 2606 bytes --]
Hi Sargun,
url: https://github.com/0day-ci/linux/commits/Sargun-Dhillon/Make-overlayfs-volatile-mounts-reusable/20201127-172416
base: be4df0cea08a8b59eb38d73de988b7ba8022df41
config: x86_64-randconfig-m001-20201127 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
fs/overlayfs/readdir.c:1149 ovl_check_incompat() error: uninitialized symbol 'd'.
vim +/d +1149 fs/overlayfs/readdir.c
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1129 static int ovl_check_incompat(struct ovl_fs *ofs, struct ovl_cache_entry *p,
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1130 struct path *path)
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1131 {
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1132 int err = -EINVAL;
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1133 struct dentry *d;
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1134
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1135 if (!strcmp(p->name, OVL_VOLATILEDIR_NAME)) {
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1136 d = lookup_one_len(p->name, path->dentry, p->len);
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1137 if (IS_ERR(d))
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1138 return PTR_ERR(d);
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1139
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1140 err = ovl_verify_volatile_info(ofs, d);
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1141 dput(d);
^^^^^^^
dput() d here.
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1142 }
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1143
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1144 if (err == -EINVAL)
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1145 pr_err("incompat feature '%s' cannot be mounted\n", p->name);
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1146 else
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1147 pr_debug("incompat '%s' handled: %d\n", p->name, err);
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1148
a9871ab1de6c660 Sargun Dhillon 2020-11-27 @1149 dput(d);
^^^^^^
"d" is uninitialized and this is probably a double free.
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1150 return err;
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1151 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32026 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 3/4] overlay: Add the ability to remount volatile directories when safe
Date: Mon, 07 Dec 2020 14:39:54 +0300 [thread overview]
Message-ID: <20201207113954.GW2767@kadam> (raw)
In-Reply-To: <20201127092058.15117-4-sargun@sargun.me>
[-- Attachment #1: Type: text/plain, Size: 2606 bytes --]
Hi Sargun,
url: https://github.com/0day-ci/linux/commits/Sargun-Dhillon/Make-overlayfs-volatile-mounts-reusable/20201127-172416
base: be4df0cea08a8b59eb38d73de988b7ba8022df41
config: x86_64-randconfig-m001-20201127 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
fs/overlayfs/readdir.c:1149 ovl_check_incompat() error: uninitialized symbol 'd'.
vim +/d +1149 fs/overlayfs/readdir.c
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1129 static int ovl_check_incompat(struct ovl_fs *ofs, struct ovl_cache_entry *p,
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1130 struct path *path)
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1131 {
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1132 int err = -EINVAL;
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1133 struct dentry *d;
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1134
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1135 if (!strcmp(p->name, OVL_VOLATILEDIR_NAME)) {
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1136 d = lookup_one_len(p->name, path->dentry, p->len);
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1137 if (IS_ERR(d))
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1138 return PTR_ERR(d);
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1139
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1140 err = ovl_verify_volatile_info(ofs, d);
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1141 dput(d);
^^^^^^^
dput() d here.
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1142 }
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1143
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1144 if (err == -EINVAL)
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1145 pr_err("incompat feature '%s' cannot be mounted\n", p->name);
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1146 else
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1147 pr_debug("incompat '%s' handled: %d\n", p->name, err);
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1148
a9871ab1de6c660 Sargun Dhillon 2020-11-27 @1149 dput(d);
^^^^^^
"d" is uninitialized and this is probably a double free.
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1150 return err;
a9871ab1de6c660 Sargun Dhillon 2020-11-27 1151 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32026 bytes --]
next prev parent reply other threads:[~2020-12-07 11:41 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 9:20 [PATCH v2 0/4] Make overlayfs volatile mounts reusable Sargun Dhillon
2020-11-27 9:20 ` [PATCH v2 1/4] fs: Add s_instance_id field to superblock for unique identification Sargun Dhillon
2020-11-27 9:20 ` [PATCH v2 2/4] overlay: Document current outstanding shortcoming of volatile Sargun Dhillon
2020-11-27 12:52 ` Amir Goldstein
2020-11-27 22:11 ` Sargun Dhillon
2020-11-28 2:01 ` Jeff Layton
2020-11-28 4:45 ` Sargun Dhillon
2020-11-28 7:12 ` Amir Goldstein
2020-11-28 8:52 ` Sargun Dhillon
2020-11-28 9:04 ` Amir Goldstein
2020-12-01 11:09 ` Sargun Dhillon
2020-12-01 11:29 ` Amir Goldstein
2020-12-01 13:01 ` Jeff Layton
2020-12-01 15:24 ` Vivek Goyal
2020-12-01 16:10 ` Jeff Layton
2020-11-28 12:04 ` Jeff Layton
2020-11-28 8:56 ` Amir Goldstein
2020-11-28 9:06 ` Amir Goldstein
2020-11-27 9:20 ` [PATCH v2 3/4] overlay: Add the ability to remount volatile directories when safe Sargun Dhillon
2020-11-27 11:09 ` kernel test robot
2020-11-27 11:09 ` kernel test robot
2020-11-27 13:04 ` Amir Goldstein
2020-12-07 11:39 ` Dan Carpenter [this message]
2020-12-07 11:39 ` Dan Carpenter
2020-12-07 11:39 ` Dan Carpenter
2020-11-27 9:20 ` [PATCH v2 4/4] overlay: Add rudimentary checking of writeback errseq on volatile remount Sargun Dhillon
2020-11-30 18:43 ` Vivek Goyal
2020-11-30 19:15 ` Vivek Goyal
2020-12-05 9:13 ` Amir Goldstein
2020-12-05 13:51 ` Jeff Layton
2020-12-05 14:51 ` Amir Goldstein
2020-11-30 19:33 ` Vivek Goyal
2020-12-01 11:56 ` Sargun Dhillon
2020-12-01 12:45 ` Jeff Layton
-- strict thread matches above, loose matches on Subject: below --
2020-11-27 15:32 [PATCH v2 3/4] overlay: Add the ability to remount volatile directories when safe kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207113954.GW2767@kadam \
--to=dan.carpenter@oracle.com \
--cc=amir73il@gmail.com \
--cc=dhowells@redhat.com \
--cc=dwalsh@redhat.com \
--cc=gscrivan@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=lkp@intel.com \
--cc=miklos@szeredi.hu \
--cc=sargun@sargun.me \
--cc=vgoyal@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.