From: Krzysztof Kozlowski <krzk@kernel.org>
To: Teresa Remmet <t.remmet@phytec.de>
Cc: devicetree@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] arm64: defconfig: Enable rv3028 i2c rtc driver
Date: Mon, 7 Dec 2020 14:50:04 +0100 [thread overview]
Message-ID: <20201207135004.GA34599@kozik-lap> (raw)
In-Reply-To: <5b8617e4b6abe19750cec17f4d6e501fe957f193.camel@phytec.de>
On Mon, Dec 07, 2020 at 02:38:51PM +0100, Teresa Remmet wrote:
> Am Montag, den 07.12.2020, 13:10 +0100 schrieb Krzysztof Kozlowski:
> > On Fri, Dec 04, 2020 at 09:32:59PM +0100, Teresa Remmet wrote:
> > > Enable rv3028 i2c rtc driver populated on phyBOARD-Pollux-i.MX8M
> > > Plus.
> > >
> > > Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> > > ---
> > > arch/arm64/configs/defconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/configs/defconfig
> > > b/arch/arm64/configs/defconfig
> > > index 5cfe3cf6f2ac..2034fefb3f44 100644
> > > --- a/arch/arm64/configs/defconfig
> > > +++ b/arch/arm64/configs/defconfig
> > > @@ -818,6 +818,7 @@ CONFIG_RTC_DRV_MAX77686=y
> > > CONFIG_RTC_DRV_RK808=m
> > > CONFIG_RTC_DRV_PCF85363=m
> > > CONFIG_RTC_DRV_RX8581=m
> > > +CONFIG_RTC_DRV_RV3028=y
> >
> > This should be a module.
>
> with having this build in the clock out of this rtc will be disabled as
> not using during boot up. The clock out is enabled as default and has
> to be disabled explicit. But I guess the correct way would be to find a
> solution in the rtc driver itself?
Regardless whether it is built-in or module, the driver will behave the
same. So either the driver disables the clock, or not. The only
difference will be *when* the action happens.
Choosing it as built-in for the purpose of disabling some clock is not a
proper approach.
The defconfig here serves only a development/debugging/reference purpose.
It's not for production so anyway the effect on disabling some parts is
not that important.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Teresa Remmet <t.remmet@phytec.de>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH 1/4] arm64: defconfig: Enable rv3028 i2c rtc driver
Date: Mon, 7 Dec 2020 14:50:04 +0100 [thread overview]
Message-ID: <20201207135004.GA34599@kozik-lap> (raw)
In-Reply-To: <5b8617e4b6abe19750cec17f4d6e501fe957f193.camel@phytec.de>
On Mon, Dec 07, 2020 at 02:38:51PM +0100, Teresa Remmet wrote:
> Am Montag, den 07.12.2020, 13:10 +0100 schrieb Krzysztof Kozlowski:
> > On Fri, Dec 04, 2020 at 09:32:59PM +0100, Teresa Remmet wrote:
> > > Enable rv3028 i2c rtc driver populated on phyBOARD-Pollux-i.MX8M
> > > Plus.
> > >
> > > Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> > > ---
> > > arch/arm64/configs/defconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/configs/defconfig
> > > b/arch/arm64/configs/defconfig
> > > index 5cfe3cf6f2ac..2034fefb3f44 100644
> > > --- a/arch/arm64/configs/defconfig
> > > +++ b/arch/arm64/configs/defconfig
> > > @@ -818,6 +818,7 @@ CONFIG_RTC_DRV_MAX77686=y
> > > CONFIG_RTC_DRV_RK808=m
> > > CONFIG_RTC_DRV_PCF85363=m
> > > CONFIG_RTC_DRV_RX8581=m
> > > +CONFIG_RTC_DRV_RV3028=y
> >
> > This should be a module.
>
> with having this build in the clock out of this rtc will be disabled as
> not using during boot up. The clock out is enabled as default and has
> to be disabled explicit. But I guess the correct way would be to find a
> solution in the rtc driver itself?
Regardless whether it is built-in or module, the driver will behave the
same. So either the driver disables the clock, or not. The only
difference will be *when* the action happens.
Choosing it as built-in for the purpose of disabling some clock is not a
proper approach.
The defconfig here serves only a development/debugging/reference purpose.
It's not for production so anyway the effect on disabling some parts is
not that important.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-12-07 13:51 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 20:32 [PATCH 0/4] Initial support for phyBOARD-Pollux i.MX8MP Teresa Remmet
2020-12-04 20:32 ` Teresa Remmet
2020-12-04 20:32 ` [PATCH 1/4] arm64: defconfig: Enable rv3028 i2c rtc driver Teresa Remmet
2020-12-04 20:32 ` Teresa Remmet
2020-12-07 12:10 ` Krzysztof Kozlowski
2020-12-07 12:10 ` Krzysztof Kozlowski
2020-12-07 13:38 ` Teresa Remmet
2020-12-07 13:38 ` Teresa Remmet
2020-12-07 13:50 ` Krzysztof Kozlowski [this message]
2020-12-07 13:50 ` Krzysztof Kozlowski
2020-12-08 11:33 ` Teresa Remmet
2020-12-08 11:33 ` Teresa Remmet
2020-12-04 20:33 ` [PATCH 2/4] arm64: defconfig: Enable PCA9532 support Teresa Remmet
2020-12-04 20:33 ` Teresa Remmet
2020-12-07 12:11 ` Krzysztof Kozlowski
2020-12-07 12:11 ` Krzysztof Kozlowski
2020-12-04 20:33 ` [PATCH 3/4] bindings: arm: fsl: Add PHYTEC i.MX8MP devicetree bindings Teresa Remmet
2020-12-04 20:33 ` Teresa Remmet
2020-12-07 11:59 ` Krzysztof Kozlowski
2020-12-07 11:59 ` Krzysztof Kozlowski
2020-12-07 12:37 ` Teresa Remmet
2020-12-07 12:37 ` Teresa Remmet
2020-12-04 20:33 ` [PATCH 4/4] arm64: dts: freescale: Add support for phyBOARD-Pollux-i.MX8MP Teresa Remmet
2020-12-04 20:33 ` Teresa Remmet
2020-12-07 12:09 ` Krzysztof Kozlowski
2020-12-07 12:09 ` Krzysztof Kozlowski
2020-12-07 13:35 ` Teresa Remmet
2020-12-07 13:35 ` Teresa Remmet
2020-12-07 13:46 ` Krzysztof Kozlowski
2020-12-07 13:46 ` Krzysztof Kozlowski
2020-12-08 11:53 ` Teresa Remmet
2020-12-08 11:53 ` Teresa Remmet
2020-12-08 12:00 ` Krzysztof Kozlowski
2020-12-08 12:00 ` Krzysztof Kozlowski
2020-12-08 12:23 ` Teresa Remmet
2020-12-08 12:23 ` Teresa Remmet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207135004.GA34599@kozik-lap \
--to=krzk@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=t.remmet@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.