From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jinpu Wang <jinpu.wang@cloud.ionos.com>
Cc: Danil Kipnis <danil.kipnis@cloud.ionos.com>,
Md Haris Iqbal <haris.iqbal@cloud.ionos.com>,
Jens Axboe <axboe@kernel.dk>,
Lutz Pogrell <lutz.pogrell@cloud.ionos.com>,
linux-block <linux-block@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] block/rnbd-clt: Fix error code in rnbd_clt_add_dev_symlink()
Date: Wed, 09 Dec 2020 08:03:23 +0000 [thread overview]
Message-ID: <20201209080323.GE2767@kadam> (raw)
In-Reply-To: <CAMGffEn6a92UDBgzkR2L6wutNBpxY_xNf3cakvbivkaGRnk_uQ@mail.gmail.com>
On Wed, Dec 09, 2020 at 08:36:31AM +0100, Jinpu Wang wrote:
> Hi Dan,
>
>
>
> On Wed, Dec 9, 2020 at 7:52 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > The "ret" variable should be set to -ENOMEM but it returns uninitialized
> > stack data.
> >
> > Fixes: 64e8a6ece1a5 ("block/rnbd-clt: Dynamically alloc buffer for pathname & blk_symlink_name")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Thanks for the patch. But there is already a fix from Colin merged in
> block tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-5.11/drivers&ids3c15bd3a944b8eeaacdddf061759b6a83dd3f4
>
> There is still other problem through with commit 64e8a6ece1a5
> ("block/rnbd-clt: Dynamically alloc buffer for pathname &
> blk_symlink_name")
>
> I will send the fix today together with other changes.
Ah... Haha... Sorry about that. We already discussed this yesterday.
What happens is that when I write a patch, I normally save it in my
postponed messages until the next day. But then I decided to not fix it
but instead to just report it. Unfortunately, I forgot to delete it and
I also forgot about yesterday's discussion because I have the memory of
a gnat. :P
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jinpu Wang <jinpu.wang@cloud.ionos.com>
Cc: Danil Kipnis <danil.kipnis@cloud.ionos.com>,
Md Haris Iqbal <haris.iqbal@cloud.ionos.com>,
Jens Axboe <axboe@kernel.dk>,
Lutz Pogrell <lutz.pogrell@cloud.ionos.com>,
linux-block <linux-block@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] block/rnbd-clt: Fix error code in rnbd_clt_add_dev_symlink()
Date: Wed, 9 Dec 2020 11:03:23 +0300 [thread overview]
Message-ID: <20201209080323.GE2767@kadam> (raw)
In-Reply-To: <CAMGffEn6a92UDBgzkR2L6wutNBpxY_xNf3cakvbivkaGRnk_uQ@mail.gmail.com>
On Wed, Dec 09, 2020 at 08:36:31AM +0100, Jinpu Wang wrote:
> Hi Dan,
>
>
>
> On Wed, Dec 9, 2020 at 7:52 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > The "ret" variable should be set to -ENOMEM but it returns uninitialized
> > stack data.
> >
> > Fixes: 64e8a6ece1a5 ("block/rnbd-clt: Dynamically alloc buffer for pathname & blk_symlink_name")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Thanks for the patch. But there is already a fix from Colin merged in
> block tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-5.11/drivers&id=733c15bd3a944b8eeaacdddf061759b6a83dd3f4
>
> There is still other problem through with commit 64e8a6ece1a5
> ("block/rnbd-clt: Dynamically alloc buffer for pathname &
> blk_symlink_name")
>
> I will send the fix today together with other changes.
Ah... Haha... Sorry about that. We already discussed this yesterday.
What happens is that when I write a patch, I normally save it in my
postponed messages until the next day. But then I decided to not fix it
but instead to just report it. Unfortunately, I forgot to delete it and
I also forgot about yesterday's discussion because I have the memory of
a gnat. :P
regards,
dan carpenter
next prev parent reply other threads:[~2020-12-09 8:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 6:52 [PATCH] block/rnbd-clt: Fix error code in rnbd_clt_add_dev_symlink() Dan Carpenter
2020-12-09 6:52 ` Dan Carpenter
2020-12-09 7:28 ` Chaitanya Kulkarni
2020-12-09 7:28 ` Chaitanya Kulkarni
2020-12-09 7:36 ` Jinpu Wang
2020-12-09 7:36 ` Jinpu Wang
2020-12-09 8:03 ` Dan Carpenter [this message]
2020-12-09 8:03 ` Dan Carpenter
2020-12-09 8:05 ` Jinpu Wang
2020-12-09 8:05 ` Jinpu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209080323.GE2767@kadam \
--to=dan.carpenter@oracle.com \
--cc=axboe@kernel.dk \
--cc=danil.kipnis@cloud.ionos.com \
--cc=haris.iqbal@cloud.ionos.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=lutz.pogrell@cloud.ionos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.