All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@techsingularity.net>
To: "Li, Aubrey" <aubrey.li@linux.intel.com>
Cc: Barry Song <song.bao.hua@hisilicon.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Peter Ziljstra <peterz@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Valentin Schneider <valentin.schneider@arm.com>,
	Linux-ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/4] sched/fair: Move avg_scan_cost calculations under SIS_PROP
Date: Wed, 9 Dec 2020 09:05:07 +0000	[thread overview]
Message-ID: <20201209090507.GM3371@techsingularity.net> (raw)
In-Reply-To: <3255625e-fa92-dc09-9fab-5621122f4af0@linux.intel.com>

On Wed, Dec 09, 2020 at 01:28:11PM +0800, Li, Aubrey wrote:
> >>                         nr = div_u64(span_avg, avg_cost);
> >>                 else
> >>                         nr = 4;
> >> -       }
> >> -
> >> -       time = cpu_clock(this);
> >>
> >> -       cpumask_and(cpus, sched_domain_span(sd), p->cpus_ptr);
> >> +               time = cpu_clock(this);
> >> +       }
> >>
> >>         for_each_cpu_wrap(cpu, cpus, target) {
> >>                 if (!--nr)
> 
> nr is the key of this throttling mechanism, need to be placed under sched_feat(SIS_PROP) as well.
> 

It isn't necessary as nr in initialised to INT_MAX if !SIS_PROP.

-- 
Mel Gorman
SUSE Labs

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@techsingularity.net>
To: "Li, Aubrey" <aubrey.li@linux.intel.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
	Peter Ziljstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Barry Song <song.bao.hua@hisilicon.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Valentin Schneider <valentin.schneider@arm.com>,
	Linux-ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/4] sched/fair: Move avg_scan_cost calculations under SIS_PROP
Date: Wed, 9 Dec 2020 09:05:07 +0000	[thread overview]
Message-ID: <20201209090507.GM3371@techsingularity.net> (raw)
In-Reply-To: <3255625e-fa92-dc09-9fab-5621122f4af0@linux.intel.com>

On Wed, Dec 09, 2020 at 01:28:11PM +0800, Li, Aubrey wrote:
> >>                         nr = div_u64(span_avg, avg_cost);
> >>                 else
> >>                         nr = 4;
> >> -       }
> >> -
> >> -       time = cpu_clock(this);
> >>
> >> -       cpumask_and(cpus, sched_domain_span(sd), p->cpus_ptr);
> >> +               time = cpu_clock(this);
> >> +       }
> >>
> >>         for_each_cpu_wrap(cpu, cpus, target) {
> >>                 if (!--nr)
> 
> nr is the key of this throttling mechanism, need to be placed under sched_feat(SIS_PROP) as well.
> 

It isn't necessary as nr in initialised to INT_MAX if !SIS_PROP.

-- 
Mel Gorman
SUSE Labs

  reply	other threads:[~2020-12-09  9:06 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 15:34 [PATCH 0/4] Reduce scanning of runqueues in select_idle_sibling Mel Gorman
2020-12-08 15:34 ` Mel Gorman
2020-12-08 15:34 ` [PATCH 1/4] sched/fair: Remove SIS_AVG_CPU Mel Gorman
2020-12-08 15:34   ` Mel Gorman
2020-12-08 16:13   ` Vincent Guittot
2020-12-08 16:13     ` Vincent Guittot
2020-12-08 15:34 ` [PATCH 2/4] sched/fair: Move avg_scan_cost calculations under SIS_PROP Mel Gorman
2020-12-08 15:34   ` Mel Gorman
2020-12-08 16:03   ` Vincent Guittot
2020-12-08 16:03     ` Vincent Guittot
2020-12-08 16:30     ` Mel Gorman
2020-12-08 16:30       ` Mel Gorman
2020-12-09  5:28     ` Li, Aubrey
2020-12-09  5:28       ` Li, Aubrey
2020-12-09  9:05       ` Mel Gorman [this message]
2020-12-09  9:05         ` Mel Gorman
2020-12-09 11:07         ` Li, Aubrey
2020-12-09 11:07           ` Li, Aubrey
2020-12-09 11:33           ` Mel Gorman
2020-12-09 11:33             ` Mel Gorman
2020-12-10  5:18   ` Li, Aubrey
2020-12-10  5:18     ` Li, Aubrey
2020-12-10  9:32     ` Mel Gorman
2020-12-10  9:32       ` Mel Gorman
2020-12-08 15:35 ` [PATCH 3/4] sched/fair: Do not replace recent_used_cpu with the new target Mel Gorman
2020-12-08 15:35   ` Mel Gorman
2020-12-08 16:14   ` Vincent Guittot
2020-12-08 16:14     ` Vincent Guittot
2020-12-10  9:40     ` Vincent Guittot
2020-12-10  9:40       ` Vincent Guittot
2020-12-11  6:25   ` Hillf Danton
2020-12-11  9:02     ` Mel Gorman
2020-12-11  9:02       ` Mel Gorman
2020-12-11  9:34       ` Hillf Danton
2020-12-11  9:45         ` Mel Gorman
2020-12-11  9:45           ` Mel Gorman
2020-12-08 15:35 ` [PATCH 4/4] sched/fair: Return an idle cpu if one is found after a failed search for an idle core Mel Gorman
2020-12-08 15:35   ` Mel Gorman
2020-12-08 16:15   ` Vincent Guittot
2020-12-08 16:15     ` Vincent Guittot
2020-12-09 14:37 ` [PATCH 0/4] Reduce scanning of runqueues in select_idle_sibling Mel Gorman
2020-12-09 14:37   ` Mel Gorman
2020-12-10  8:00   ` Vincent Guittot
2020-12-10  8:00     ` Vincent Guittot
2020-12-10  9:38     ` Vincent Guittot
2020-12-10  9:38       ` Vincent Guittot
2020-12-10 11:04       ` Mel Gorman
2020-12-10 11:04         ` Mel Gorman
2020-12-11  9:51         ` Vincent Guittot
2020-12-11  9:51           ` Vincent Guittot
2020-12-11 10:23           ` Mel Gorman
2020-12-11 10:23             ` Mel Gorman
2020-12-12 10:02             ` Vincent Guittot
2020-12-12 10:02               ` Vincent Guittot
  -- strict thread matches above, loose matches on Subject: below --
2021-01-25  8:59 [PATCH v4 0/4] Scan for an idle sibling in a single pass Mel Gorman
2021-01-25  8:59 ` [PATCH 2/4] sched/fair: Move avg_scan_cost calculations under SIS_PROP Mel Gorman
2021-01-27 10:39   ` Vincent Guittot
2021-01-27 13:51 [PATCH v5 0/4] Scan for an idle sibling in a single pass Mel Gorman
2021-01-27 13:52 ` [PATCH 2/4] sched/fair: Move avg_scan_cost calculations under SIS_PROP Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201209090507.GM3371@techsingularity.net \
    --to=mgorman@techsingularity.net \
    --cc=aubrey.li@linux.intel.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=song.bao.hua@hisilicon.com \
    --cc=valentin.schneider@arm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.