From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH net-next 3/4] sch_htb: Stats for offloaded HTB
Date: Thu, 10 Dec 2020 11:28:51 +0300 [thread overview]
Message-ID: <20201210082851.GL2767@kadam> (raw)
In-Reply-To: <20201209160251.19054-4-maximmi@mellanox.com>
[-- Attachment #1: Type: text/plain, Size: 4228 bytes --]
Hi Maxim,
url: https://github.com/0day-ci/linux/commits/Maxim-Mikityanskiy/HTB-offload/20201210-000703
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git afae3cc2da100ead3cd6ef4bb1fb8bc9d4b817c5
config: i386-randconfig-m021-20201209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
net/sched/sch_htb.c:1310 htb_dump_class_stats() error: we previously assumed 'cl->leaf.q' could be null (see line 1300)
vim +1310 net/sched/sch_htb.c
^1da177e4c3f415 Linus Torvalds 2005-04-16 1289 static int
87990467d387f92 Stephen Hemminger 2006-08-10 1290 htb_dump_class_stats(struct Qdisc *sch, unsigned long arg, struct gnet_dump *d)
^1da177e4c3f415 Linus Torvalds 2005-04-16 1291 {
^1da177e4c3f415 Linus Torvalds 2005-04-16 1292 struct htb_class *cl = (struct htb_class *)arg;
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1293 struct htb_sched *q = qdisc_priv(sch);
338ed9b4de57c4b Eric Dumazet 2016-06-21 1294 struct gnet_stats_queue qs = {
338ed9b4de57c4b Eric Dumazet 2016-06-21 1295 .drops = cl->drops,
3c75f6ee139d464 Eric Dumazet 2017-09-18 1296 .overlimits = cl->overlimits,
338ed9b4de57c4b Eric Dumazet 2016-06-21 1297 };
6401585366326fc John Fastabend 2014-09-28 1298 __u32 qlen = 0;
^1da177e4c3f415 Linus Torvalds 2005-04-16 1299
5dd431b6b92c0db Paolo Abeni 2019-03-28 @1300 if (!cl->level && cl->leaf.q)
^^^^^^^^^^
Check for NULL
5dd431b6b92c0db Paolo Abeni 2019-03-28 1301 qdisc_qstats_qlen_backlog(cl->leaf.q, &qlen, &qs.backlog);
5dd431b6b92c0db Paolo Abeni 2019-03-28 1302
0564bf0afae443d Konstantin Khlebnikov 2016-07-16 1303 cl->xstats.tokens = clamp_t(s64, PSCHED_NS2TICKS(cl->tokens),
0564bf0afae443d Konstantin Khlebnikov 2016-07-16 1304 INT_MIN, INT_MAX);
0564bf0afae443d Konstantin Khlebnikov 2016-07-16 1305 cl->xstats.ctokens = clamp_t(s64, PSCHED_NS2TICKS(cl->ctokens),
0564bf0afae443d Konstantin Khlebnikov 2016-07-16 1306 INT_MIN, INT_MAX);
^1da177e4c3f415 Linus Torvalds 2005-04-16 1307
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1308 if (q->offload) {
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1309 if (!cl->level) {
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 @1310 cl->bstats = cl->leaf.q->bstats;
^^^^^^^^^^^^
Unchecked dereference
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1311 cl->bstats.bytes += cl->bstats_bias.bytes;
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1312 cl->bstats.packets += cl->bstats_bias.packets;
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1313 } else {
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1314 htb_offload_aggregate_stats(q, cl);
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1315 }
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1316 }
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1317
edb09eb17ed89ea Eric Dumazet 2016-06-06 1318 if (gnet_stats_copy_basic(qdisc_root_sleeping_running(sch),
edb09eb17ed89ea Eric Dumazet 2016-06-06 1319 d, NULL, &cl->bstats) < 0 ||
1c0d32fde5bdf11 Eric Dumazet 2016-12-04 1320 gnet_stats_copy_rate_est(d, &cl->rate_est) < 0 ||
338ed9b4de57c4b Eric Dumazet 2016-06-21 1321 gnet_stats_copy_queue(d, NULL, &qs, qlen) < 0)
^1da177e4c3f415 Linus Torvalds 2005-04-16 1322 return -1;
^1da177e4c3f415 Linus Torvalds 2005-04-16 1323
^1da177e4c3f415 Linus Torvalds 2005-04-16 1324 return gnet_stats_copy_app(d, &cl->xstats, sizeof(cl->xstats));
^1da177e4c3f415 Linus Torvalds 2005-04-16 1325 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36211 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH net-next 3/4] sch_htb: Stats for offloaded HTB
Date: Thu, 10 Dec 2020 11:28:51 +0300 [thread overview]
Message-ID: <20201210082851.GL2767@kadam> (raw)
In-Reply-To: <20201209160251.19054-4-maximmi@mellanox.com>
[-- Attachment #1: Type: text/plain, Size: 4228 bytes --]
Hi Maxim,
url: https://github.com/0day-ci/linux/commits/Maxim-Mikityanskiy/HTB-offload/20201210-000703
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git afae3cc2da100ead3cd6ef4bb1fb8bc9d4b817c5
config: i386-randconfig-m021-20201209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
net/sched/sch_htb.c:1310 htb_dump_class_stats() error: we previously assumed 'cl->leaf.q' could be null (see line 1300)
vim +1310 net/sched/sch_htb.c
^1da177e4c3f415 Linus Torvalds 2005-04-16 1289 static int
87990467d387f92 Stephen Hemminger 2006-08-10 1290 htb_dump_class_stats(struct Qdisc *sch, unsigned long arg, struct gnet_dump *d)
^1da177e4c3f415 Linus Torvalds 2005-04-16 1291 {
^1da177e4c3f415 Linus Torvalds 2005-04-16 1292 struct htb_class *cl = (struct htb_class *)arg;
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1293 struct htb_sched *q = qdisc_priv(sch);
338ed9b4de57c4b Eric Dumazet 2016-06-21 1294 struct gnet_stats_queue qs = {
338ed9b4de57c4b Eric Dumazet 2016-06-21 1295 .drops = cl->drops,
3c75f6ee139d464 Eric Dumazet 2017-09-18 1296 .overlimits = cl->overlimits,
338ed9b4de57c4b Eric Dumazet 2016-06-21 1297 };
6401585366326fc John Fastabend 2014-09-28 1298 __u32 qlen = 0;
^1da177e4c3f415 Linus Torvalds 2005-04-16 1299
5dd431b6b92c0db Paolo Abeni 2019-03-28 @1300 if (!cl->level && cl->leaf.q)
^^^^^^^^^^
Check for NULL
5dd431b6b92c0db Paolo Abeni 2019-03-28 1301 qdisc_qstats_qlen_backlog(cl->leaf.q, &qlen, &qs.backlog);
5dd431b6b92c0db Paolo Abeni 2019-03-28 1302
0564bf0afae443d Konstantin Khlebnikov 2016-07-16 1303 cl->xstats.tokens = clamp_t(s64, PSCHED_NS2TICKS(cl->tokens),
0564bf0afae443d Konstantin Khlebnikov 2016-07-16 1304 INT_MIN, INT_MAX);
0564bf0afae443d Konstantin Khlebnikov 2016-07-16 1305 cl->xstats.ctokens = clamp_t(s64, PSCHED_NS2TICKS(cl->ctokens),
0564bf0afae443d Konstantin Khlebnikov 2016-07-16 1306 INT_MIN, INT_MAX);
^1da177e4c3f415 Linus Torvalds 2005-04-16 1307
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1308 if (q->offload) {
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1309 if (!cl->level) {
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 @1310 cl->bstats = cl->leaf.q->bstats;
^^^^^^^^^^^^
Unchecked dereference
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1311 cl->bstats.bytes += cl->bstats_bias.bytes;
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1312 cl->bstats.packets += cl->bstats_bias.packets;
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1313 } else {
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1314 htb_offload_aggregate_stats(q, cl);
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1315 }
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1316 }
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1317
edb09eb17ed89ea Eric Dumazet 2016-06-06 1318 if (gnet_stats_copy_basic(qdisc_root_sleeping_running(sch),
edb09eb17ed89ea Eric Dumazet 2016-06-06 1319 d, NULL, &cl->bstats) < 0 ||
1c0d32fde5bdf11 Eric Dumazet 2016-12-04 1320 gnet_stats_copy_rate_est(d, &cl->rate_est) < 0 ||
338ed9b4de57c4b Eric Dumazet 2016-06-21 1321 gnet_stats_copy_queue(d, NULL, &qs, qlen) < 0)
^1da177e4c3f415 Linus Torvalds 2005-04-16 1322 return -1;
^1da177e4c3f415 Linus Torvalds 2005-04-16 1323
^1da177e4c3f415 Linus Torvalds 2005-04-16 1324 return gnet_stats_copy_app(d, &cl->xstats, sizeof(cl->xstats));
^1da177e4c3f415 Linus Torvalds 2005-04-16 1325 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36211 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Maxim Mikityanskiy <maximmi@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>
Cc: lkp@intel.com, kbuild-all@lists.01.org, netdev@vger.kernel.org,
Saeed Mahameed <saeedm@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>,
Tariq Toukan <tariqt@mellanox.com>,
Maxim Mikityanskiy <maximmi@nvidia.com>
Subject: Re: [PATCH net-next 3/4] sch_htb: Stats for offloaded HTB
Date: Thu, 10 Dec 2020 11:28:51 +0300 [thread overview]
Message-ID: <20201210082851.GL2767@kadam> (raw)
In-Reply-To: <20201209160251.19054-4-maximmi@mellanox.com>
[-- Attachment #1: Type: text/plain, Size: 4162 bytes --]
Hi Maxim,
url: https://github.com/0day-ci/linux/commits/Maxim-Mikityanskiy/HTB-offload/20201210-000703
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git afae3cc2da100ead3cd6ef4bb1fb8bc9d4b817c5
config: i386-randconfig-m021-20201209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
net/sched/sch_htb.c:1310 htb_dump_class_stats() error: we previously assumed 'cl->leaf.q' could be null (see line 1300)
vim +1310 net/sched/sch_htb.c
^1da177e4c3f415 Linus Torvalds 2005-04-16 1289 static int
87990467d387f92 Stephen Hemminger 2006-08-10 1290 htb_dump_class_stats(struct Qdisc *sch, unsigned long arg, struct gnet_dump *d)
^1da177e4c3f415 Linus Torvalds 2005-04-16 1291 {
^1da177e4c3f415 Linus Torvalds 2005-04-16 1292 struct htb_class *cl = (struct htb_class *)arg;
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1293 struct htb_sched *q = qdisc_priv(sch);
338ed9b4de57c4b Eric Dumazet 2016-06-21 1294 struct gnet_stats_queue qs = {
338ed9b4de57c4b Eric Dumazet 2016-06-21 1295 .drops = cl->drops,
3c75f6ee139d464 Eric Dumazet 2017-09-18 1296 .overlimits = cl->overlimits,
338ed9b4de57c4b Eric Dumazet 2016-06-21 1297 };
6401585366326fc John Fastabend 2014-09-28 1298 __u32 qlen = 0;
^1da177e4c3f415 Linus Torvalds 2005-04-16 1299
5dd431b6b92c0db Paolo Abeni 2019-03-28 @1300 if (!cl->level && cl->leaf.q)
^^^^^^^^^^
Check for NULL
5dd431b6b92c0db Paolo Abeni 2019-03-28 1301 qdisc_qstats_qlen_backlog(cl->leaf.q, &qlen, &qs.backlog);
5dd431b6b92c0db Paolo Abeni 2019-03-28 1302
0564bf0afae443d Konstantin Khlebnikov 2016-07-16 1303 cl->xstats.tokens = clamp_t(s64, PSCHED_NS2TICKS(cl->tokens),
0564bf0afae443d Konstantin Khlebnikov 2016-07-16 1304 INT_MIN, INT_MAX);
0564bf0afae443d Konstantin Khlebnikov 2016-07-16 1305 cl->xstats.ctokens = clamp_t(s64, PSCHED_NS2TICKS(cl->ctokens),
0564bf0afae443d Konstantin Khlebnikov 2016-07-16 1306 INT_MIN, INT_MAX);
^1da177e4c3f415 Linus Torvalds 2005-04-16 1307
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1308 if (q->offload) {
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1309 if (!cl->level) {
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 @1310 cl->bstats = cl->leaf.q->bstats;
^^^^^^^^^^^^
Unchecked dereference
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1311 cl->bstats.bytes += cl->bstats_bias.bytes;
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1312 cl->bstats.packets += cl->bstats_bias.packets;
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1313 } else {
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1314 htb_offload_aggregate_stats(q, cl);
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1315 }
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1316 }
1e0ac0107df684e Maxim Mikityanskiy 2020-12-09 1317
edb09eb17ed89ea Eric Dumazet 2016-06-06 1318 if (gnet_stats_copy_basic(qdisc_root_sleeping_running(sch),
edb09eb17ed89ea Eric Dumazet 2016-06-06 1319 d, NULL, &cl->bstats) < 0 ||
1c0d32fde5bdf11 Eric Dumazet 2016-12-04 1320 gnet_stats_copy_rate_est(d, &cl->rate_est) < 0 ||
338ed9b4de57c4b Eric Dumazet 2016-06-21 1321 gnet_stats_copy_queue(d, NULL, &qs, qlen) < 0)
^1da177e4c3f415 Linus Torvalds 2005-04-16 1322 return -1;
^1da177e4c3f415 Linus Torvalds 2005-04-16 1323
^1da177e4c3f415 Linus Torvalds 2005-04-16 1324 return gnet_stats_copy_app(d, &cl->xstats, sizeof(cl->xstats));
^1da177e4c3f415 Linus Torvalds 2005-04-16 1325 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36211 bytes --]
next prev parent reply other threads:[~2020-12-10 8:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 16:02 [PATCH net-next 0/4] HTB offload Maxim Mikityanskiy
2020-12-09 16:02 ` [PATCH net-next 1/4] net: sched: Add multi-queue support to sch_tree_lock Maxim Mikityanskiy
2020-12-09 16:02 ` [PATCH net-next 2/4] sch_htb: Hierarchical QoS hardware offload Maxim Mikityanskiy
2020-12-09 16:02 ` [PATCH net-next 3/4] sch_htb: Stats for offloaded HTB Maxim Mikityanskiy
2020-12-10 8:28 ` Dan Carpenter [this message]
2020-12-10 8:28 ` Dan Carpenter
2020-12-10 8:28 ` Dan Carpenter
2020-12-10 15:07 ` Maxim Mikityanskiy
2020-12-10 15:07 ` Maxim Mikityanskiy
2020-12-11 8:41 ` Dan Carpenter
2020-12-11 8:41 ` Dan Carpenter
2020-12-11 8:41 ` Dan Carpenter
2020-12-11 15:25 ` Maxim Mikityanskiy
2020-12-11 15:25 ` Maxim Mikityanskiy
2020-12-09 16:02 ` [PATCH net-next 4/4] net/mlx5e: Support HTB offload Maxim Mikityanskiy
2020-12-09 23:54 ` kernel test robot
2020-12-09 23:54 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2020-12-10 3:38 [PATCH net-next 3/4] sch_htb: Stats for offloaded HTB kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210082851.GL2767@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.