Re: [PATCH v2 1/2] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3655 bytes --]

Hi Aleksander,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on net-next/master net/master linus/master sparc-next/master v5.10-rc7 next-20201209]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Aleksander-Jan-Bajkowski/net-dsa-lantiq-add-support-for-xRX300-and-xRX330/20201206-213318
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: parisc-randconfig-r033-20201209 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/3a3400f9d3cd41f2b72cd741f208a70fca7fe93f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Aleksander-Jan-Bajkowski/net-dsa-lantiq-add-support-for-xRX300-and-xRX330/20201206-213318
        git checkout 3a3400f9d3cd41f2b72cd741f208a70fca7fe93f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/kasan-checks.h:5,
                    from include/asm-generic/rwonce.h:26,
                    from ./arch/parisc/include/generated/asm/rwonce.h:1,
                    from include/linux/compiler.h:232,
                    from include/linux/err.h:5,
                    from include/linux/clk.h:12,
                    from drivers/net/dsa/lantiq_gswip.c:28:
   drivers/net/dsa/lantiq_gswip.c: In function 'gswip_xrx300_phylink_validate':
   drivers/net/dsa/lantiq_gswip.c:1495:35: warning: unused variable 'mask' [-Wunused-variable]
    1495 |  __ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, };
         |                                   ^~~~
   include/linux/types.h:11:16: note: in definition of macro 'DECLARE_BITMAP'
      11 |  unsigned long name[BITS_TO_LONGS(bits)]
         |                ^~~~
   drivers/net/dsa/lantiq_gswip.c:1495:2: note: in expansion of macro '__ETHTOOL_DECLARE_LINK_MODE_MASK'
    1495 |  __ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, };
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/dsa/lantiq_gswip.c: At top level:
>> drivers/net/dsa/lantiq_gswip.c:2068:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    2068 |  .ops = &gswip_xrx200_switch_ops,
         |         ^
   drivers/net/dsa/lantiq_gswip.c:2074:9: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    2074 |  .ops = &gswip_xrx300_switch_ops,
         |         ^
   drivers/net/dsa/lantiq_gswip.c:1741:34: warning: 'xway_gphy_match' defined but not used [-Wunused-const-variable=]
    1741 | static const struct of_device_id xway_gphy_match[] = {
         |                                  ^~~~~~~~~~~~~~~

vim +/const +2068 drivers/net/dsa/lantiq_gswip.c

  2064	
  2065	static const struct gswip_hw_info gswip_xrx200 = {
  2066		.max_ports = 7,
  2067		.cpu_port = 6,
> 2068		.ops = &gswip_xrx200_switch_ops,
  2069	};
  2070	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28862 bytes --]