From: Wolfram Sang <wsa@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-i2c@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel@pengutronix.de
Subject: Re: [PATCH 1/2] i2c: Warn when device removing fails
Date: Thu, 10 Dec 2020 21:10:44 +0100 [thread overview]
Message-ID: <20201210201044.GB11120@kunai> (raw)
In-Reply-To: <20201126072331.1737632-1-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On Thu, Nov 26, 2020 at 08:23:30AM +0100, Uwe Kleine-König wrote:
> The driver core ignores the return value of struct bus_type::remove. So
> warn if there is an error that went unnoticed before and return 0
> unconditionally in i2c_device_remove().
I wondered about the "return 0" part...
>
> This prepares changing struct bus_type::remove to return void.
... until I read this. You are working on that?
> if (driver->remove) {
> + int status = 0;
No need to initialize to 0, or?
> +
> dev_dbg(dev, "remove\n");
> +
> status = driver->remove(client);
> + if (status)
> + dev_warn(dev, "remove failed (%pe), will be ignored\n", ERR_PTR(status));
The rest and patch 2 look good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-12-10 20:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 7:23 [PATCH 1/2] i2c: Warn when device removing fails Uwe Kleine-König
2020-11-26 7:23 ` [PATCH 2/2] i2c: remove check that can never be true Uwe Kleine-König
2020-12-11 14:44 ` Wolfram Sang
2020-12-10 20:10 ` Wolfram Sang [this message]
2020-12-11 10:43 ` [PATCH 1/2] i2c: Warn when device removing fails Uwe Kleine-König
2020-12-11 14:00 ` Wolfram Sang
2020-12-11 14:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210201044.GB11120@kunai \
--to=wsa@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.