From: Wolfram Sang <wsa@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-i2c@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel@pengutronix.de
Subject: Re: [PATCH 2/2] i2c: remove check that can never be true
Date: Fri, 11 Dec 2020 15:44:42 +0100 [thread overview]
Message-ID: <20201211144442.GB1990@kunai> (raw)
In-Reply-To: <20201126072331.1737632-2-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
On Thu, Nov 26, 2020 at 08:23:31AM +0100, Uwe Kleine-König wrote:
> A driver remove callback is only called if the device was bound before.
> So it's sure that both dev and dev->driver are valid and dev is an i2c
> device. If the check fails something louder than "return 0" might be
> appropriate because the problem is grave (something like memory
> corruption), otherwise the check is useless.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-12-11 15:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 7:23 [PATCH 1/2] i2c: Warn when device removing fails Uwe Kleine-König
2020-11-26 7:23 ` [PATCH 2/2] i2c: remove check that can never be true Uwe Kleine-König
2020-12-11 14:44 ` Wolfram Sang [this message]
2020-12-10 20:10 ` [PATCH 1/2] i2c: Warn when device removing fails Wolfram Sang
2020-12-11 10:43 ` Uwe Kleine-König
2020-12-11 14:00 ` Wolfram Sang
2020-12-11 14:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211144442.GB1990@kunai \
--to=wsa@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.