* [Intel-gfx] [PATCH] drm/i915/display: Go softly softly on initial modeset failure
@ 2020-12-10 23:07 Chris Wilson
2020-12-10 23:13 ` Rodrigo Vivi
2020-12-11 1:08 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
0 siblings, 2 replies; 4+ messages in thread
From: Chris Wilson @ 2020-12-10 23:07 UTC (permalink / raw)
To: intel-gfx; +Cc: H . J . Lu, Dave Airlie, Chris Wilson
Reduce the module/device probe error into a mere debug to hide issues
where the initial modeset is failing (after lies told by hw probe) and
the system hangs with a livelock in cleaning up the failed commit.
Reported-by: H.J. Lu <hjl.tools@gmail.com>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=210619
Fixes: b3bf99daaee9 ("drm/i915/display: Defer initial modeset until after GGTT is initialised")
Fixes: ccc9e67ab26f ("drm/i915/display: Defer initial modeset until after GGTT is initialised")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: H.J. Lu <hjl.tools@gmail.com>
Cc: Dave Airlie <airlied@redhat.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index c567c0cada7e..761be8deaa9b 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -18755,7 +18755,7 @@ int intel_modeset_init(struct drm_i915_private *i915)
*/
ret = intel_initial_commit(&i915->drm);
if (ret)
- return ret;
+ drm_dbg_kms(&i915->drm, "Initial modeset failed, %d\n", ret);
intel_overlay_setup(i915);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/display: Go softly softly on initial modeset failure
2020-12-10 23:07 [Intel-gfx] [PATCH] drm/i915/display: Go softly softly on initial modeset failure Chris Wilson
@ 2020-12-10 23:13 ` Rodrigo Vivi
2020-12-10 23:38 ` H.J. Lu
2020-12-11 1:08 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
1 sibling, 1 reply; 4+ messages in thread
From: Rodrigo Vivi @ 2020-12-10 23:13 UTC (permalink / raw)
To: Chris Wilson; +Cc: H . J . Lu, intel-gfx, Dave Airlie
On Thu, Dec 10, 2020 at 11:07:41PM +0000, Chris Wilson wrote:
> Reduce the module/device probe error into a mere debug to hide issues
> where the initial modeset is failing (after lies told by hw probe) and
> the system hangs with a livelock in cleaning up the failed commit.
>
> Reported-by: H.J. Lu <hjl.tools@gmail.com>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=210619
> Fixes: b3bf99daaee9 ("drm/i915/display: Defer initial modeset until after GGTT is initialised")
> Fixes: ccc9e67ab26f ("drm/i915/display: Defer initial modeset until after GGTT is initialised")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: H.J. Lu <hjl.tools@gmail.com>
> Cc: Dave Airlie <airlied@redhat.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index c567c0cada7e..761be8deaa9b 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -18755,7 +18755,7 @@ int intel_modeset_init(struct drm_i915_private *i915)
> */
> ret = intel_initial_commit(&i915->drm);
> if (ret)
> - return ret;
> + drm_dbg_kms(&i915->drm, "Initial modeset failed, %d\n", ret);
>
> intel_overlay_setup(i915);
>
> --
> 2.20.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/display: Go softly softly on initial modeset failure
2020-12-10 23:13 ` Rodrigo Vivi
@ 2020-12-10 23:38 ` H.J. Lu
0 siblings, 0 replies; 4+ messages in thread
From: H.J. Lu @ 2020-12-10 23:38 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: Dave Airlie, Intel Graphics Development, Chris Wilson
On Thu, Dec 10, 2020 at 3:13 PM Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
>
> On Thu, Dec 10, 2020 at 11:07:41PM +0000, Chris Wilson wrote:
> > Reduce the module/device probe error into a mere debug to hide issues
> > where the initial modeset is failing (after lies told by hw probe) and
> > the system hangs with a livelock in cleaning up the failed commit.
> >
> > Reported-by: H.J. Lu <hjl.tools@gmail.com>
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=210619
> > Fixes: b3bf99daaee9 ("drm/i915/display: Defer initial modeset until after GGTT is initialised")
> > Fixes: ccc9e67ab26f ("drm/i915/display: Defer initial modeset until after GGTT is initialised")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: H.J. Lu <hjl.tools@gmail.com>
> > Cc: Dave Airlie <airlied@redhat.com>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_display.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> > index c567c0cada7e..761be8deaa9b 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -18755,7 +18755,7 @@ int intel_modeset_init(struct drm_i915_private *i915)
> > */
> > ret = intel_initial_commit(&i915->drm);
> > if (ret)
> > - return ret;
> > + drm_dbg_kms(&i915->drm, "Initial modeset failed, %d\n", ret);
Yes, it fixed the problem.
Thanks.
> > intel_overlay_setup(i915);
> >
> > --
> > 2.20.1
> >
--
H.J.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Go softly softly on initial modeset failure
2020-12-10 23:07 [Intel-gfx] [PATCH] drm/i915/display: Go softly softly on initial modeset failure Chris Wilson
2020-12-10 23:13 ` Rodrigo Vivi
@ 2020-12-11 1:08 ` Patchwork
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-12-11 1:08 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 434 bytes --]
== Series Details ==
Series: drm/i915/display: Go softly softly on initial modeset failure
URL : https://patchwork.freedesktop.org/series/84808/
State : failure
== Summary ==
Applying: drm/i915/display: Go softly softly on initial modeset failure
Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/display/intel_display.c
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
[-- Attachment #1.2: Type: text/html, Size: 928 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-11 1:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-10 23:07 [Intel-gfx] [PATCH] drm/i915/display: Go softly softly on initial modeset failure Chris Wilson
2020-12-10 23:13 ` Rodrigo Vivi
2020-12-10 23:38 ` H.J. Lu
2020-12-11 1:08 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.