All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs
Date: Fri, 11 Dec 2020 12:45:15 +0100	[thread overview]
Message-ID: <20201211114515.GF1781038@piout.net> (raw)
In-Reply-To: <20201211103143.1332302-1-sudeep.holla@arm.com>

Hello,

On 11/12/2020 10:31:43+0000, Sudeep Holla wrote:
> Since at91_soc_init is called unconditionally from atmel_soc_device_init,
> we get the following warning on all non AT91 SoCs:
> 	" AT91: Could not find identification node"
> 
> Fix the same by filtering with allowed AT91 SoC list.
> 
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  drivers/soc/atmel/soc.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
> index c4472b68b7c2..ba9fc07cd91c 100644
> --- a/drivers/soc/atmel/soc.c
> +++ b/drivers/soc/atmel/soc.c
> @@ -271,8 +271,19 @@ struct soc_device * __init at91_soc_init(const struct at91_soc *socs)
>  	return soc_dev;
>  }
>  
> +static const struct of_device_id at91_soc_allowed_list[] __initconst = {
> +	{ .compatible = "atmel,at91rm9200", },
> +	{ .compatible = "atmel,at91sam9260", },
> +	{ .compatible = "atmel,sama5d2", },

This is a very small subset of the supported SoCs. a proper list would
be:

atmel,at91rm9200
atmel,at91sam9
atmel,sama5
atmel,samv7


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>
Subject: Re: [PATCH] drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs
Date: Fri, 11 Dec 2020 12:45:15 +0100	[thread overview]
Message-ID: <20201211114515.GF1781038@piout.net> (raw)
In-Reply-To: <20201211103143.1332302-1-sudeep.holla@arm.com>

Hello,

On 11/12/2020 10:31:43+0000, Sudeep Holla wrote:
> Since at91_soc_init is called unconditionally from atmel_soc_device_init,
> we get the following warning on all non AT91 SoCs:
> 	" AT91: Could not find identification node"
> 
> Fix the same by filtering with allowed AT91 SoC list.
> 
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  drivers/soc/atmel/soc.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
> index c4472b68b7c2..ba9fc07cd91c 100644
> --- a/drivers/soc/atmel/soc.c
> +++ b/drivers/soc/atmel/soc.c
> @@ -271,8 +271,19 @@ struct soc_device * __init at91_soc_init(const struct at91_soc *socs)
>  	return soc_dev;
>  }
>  
> +static const struct of_device_id at91_soc_allowed_list[] __initconst = {
> +	{ .compatible = "atmel,at91rm9200", },
> +	{ .compatible = "atmel,at91sam9260", },
> +	{ .compatible = "atmel,sama5d2", },

This is a very small subset of the supported SoCs. a proper list would
be:

atmel,at91rm9200
atmel,at91sam9
atmel,sama5
atmel,samv7


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-12-11 11:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-11 10:31 [PATCH] drivers: soc: atmel: Avoid calling at91_soc_init on non AT91 SoCs Sudeep Holla
2020-12-11 10:31 ` Sudeep Holla
2020-12-11 11:45 ` Alexandre Belloni [this message]
2020-12-11 11:45   ` Alexandre Belloni
2020-12-11 11:50   ` Sudeep Holla
2020-12-11 11:50     ` Sudeep Holla
2020-12-11 11:58     ` Alexandre Belloni
2020-12-11 11:58       ` Alexandre Belloni
2020-12-11 12:14       ` Sudeep Holla
2020-12-11 12:14         ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201211114515.GF1781038@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.