From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Harshad Shirwadkar <harshadshirwadkar@gmail.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix an IS_ERR() vs NULL check
Date: Sun, 13 Dec 2020 16:25:25 +0000 [thread overview]
Message-ID: <20201213162525.GA835709@mit.edu> (raw)
In-Reply-To: <20201210160419.GA31725@quack2.suse.cz>
On Thu, Dec 10, 2020 at 05:04:19PM +0100, Jan Kara wrote:
> On Fri 23-10-20 14:22:32, Dan Carpenter wrote:
> > The ext4_find_extent() function never returns NULL, it returns error
> > pointers.
> >
> > Fixes: 44059e503b03 ("ext4: fast commit recovery path")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> I think this fix has fallen through the cracks? It looks good to me so feel
> free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
This had indeed slipped through the cracks. Thanks for pointing it
out; I've applied it.
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Harshad Shirwadkar <harshadshirwadkar@gmail.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix an IS_ERR() vs NULL check
Date: Sun, 13 Dec 2020 11:25:25 -0500 [thread overview]
Message-ID: <20201213162525.GA835709@mit.edu> (raw)
In-Reply-To: <20201210160419.GA31725@quack2.suse.cz>
On Thu, Dec 10, 2020 at 05:04:19PM +0100, Jan Kara wrote:
> On Fri 23-10-20 14:22:32, Dan Carpenter wrote:
> > The ext4_find_extent() function never returns NULL, it returns error
> > pointers.
> >
> > Fixes: 44059e503b03 ("ext4: fast commit recovery path")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> I think this fix has fallen through the cracks? It looks good to me so feel
> free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
This had indeed slipped through the cracks. Thanks for pointing it
out; I've applied it.
- Ted
next prev parent reply other threads:[~2020-12-13 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 11:22 [PATCH] ext4: Fix an IS_ERR() vs NULL check Dan Carpenter
2020-10-23 11:22 ` Dan Carpenter
2020-12-10 16:04 ` Jan Kara
2020-12-10 16:04 ` Jan Kara
2020-12-13 16:25 ` Theodore Y. Ts'o [this message]
2020-12-13 16:25 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201213162525.GA835709@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=dan.carpenter@oracle.com \
--cc=harshadshirwadkar@gmail.com \
--cc=jack@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.