* [linux-nfc] [PATCH net-next] nfc: s3fwrn5: Remove the delay for nfc sleep
@ 2020-12-13 10:12 ` Bongsu Jeon
0 siblings, 0 replies; 6+ messages in thread
From: Bongsu Jeon @ 2020-12-13 10:12 UTC (permalink / raw)
To: linux-nfc
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
From: Bongsu Jeon <bongsu.jeon@samsung.com>
remove the delay for nfc sleep because nfc doesn't need the sleep delay.
Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com>
---
drivers/nfc/s3fwrn5/phy_common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nfc/s3fwrn5/phy_common.c b/drivers/nfc/s3fwrn5/phy_common.c
index 497b02b30ae7..81318478d5fd 100644
--- a/drivers/nfc/s3fwrn5/phy_common.c
+++ b/drivers/nfc/s3fwrn5/phy_common.c
@@ -20,7 +20,8 @@ void s3fwrn5_phy_set_wake(void *phy_id, bool wake)
mutex_lock(&phy->mutex);
gpio_set_value(phy->gpio_fw_wake, wake);
- msleep(S3FWRN5_EN_WAIT_TIME);
+ if (wake)
+ msleep(S3FWRN5_EN_WAIT_TIME);
mutex_unlock(&phy->mutex);
}
EXPORT_SYMBOL(s3fwrn5_phy_set_wake);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH net-next] nfc: s3fwrn5: Remove the delay for nfc sleep
@ 2020-12-13 10:12 ` Bongsu Jeon
0 siblings, 0 replies; 6+ messages in thread
From: Bongsu Jeon @ 2020-12-13 10:12 UTC (permalink / raw)
To: linux-nfc
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
From: Bongsu Jeon <bongsu.jeon@samsung.com>
remove the delay for nfc sleep because nfc doesn't need the sleep delay.
Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com>
---
drivers/nfc/s3fwrn5/phy_common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nfc/s3fwrn5/phy_common.c b/drivers/nfc/s3fwrn5/phy_common.c
index 497b02b30ae7..81318478d5fd 100644
--- a/drivers/nfc/s3fwrn5/phy_common.c
+++ b/drivers/nfc/s3fwrn5/phy_common.c
@@ -20,7 +20,8 @@ void s3fwrn5_phy_set_wake(void *phy_id, bool wake)
mutex_lock(&phy->mutex);
gpio_set_value(phy->gpio_fw_wake, wake);
- msleep(S3FWRN5_EN_WAIT_TIME);
+ if (wake)
+ msleep(S3FWRN5_EN_WAIT_TIME);
mutex_unlock(&phy->mutex);
}
EXPORT_SYMBOL(s3fwrn5_phy_set_wake);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH net-next] nfc: s3fwrn5: Remove the delay for nfc sleep
@ 2020-12-13 10:12 ` Bongsu Jeon
0 siblings, 0 replies; 6+ messages in thread
From: Bongsu Jeon @ 2020-12-13 10:12 UTC (permalink / raw)
To: krzk; +Cc: linux-nfc, netdev, linux-kernel, Bongsu Jeon
From: Bongsu Jeon <bongsu.jeon@samsung.com>
remove the delay for nfc sleep because nfc doesn't need the sleep delay.
Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com>
---
drivers/nfc/s3fwrn5/phy_common.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/nfc/s3fwrn5/phy_common.c b/drivers/nfc/s3fwrn5/phy_common.c
index 497b02b30ae7..81318478d5fd 100644
--- a/drivers/nfc/s3fwrn5/phy_common.c
+++ b/drivers/nfc/s3fwrn5/phy_common.c
@@ -20,7 +20,8 @@ void s3fwrn5_phy_set_wake(void *phy_id, bool wake)
mutex_lock(&phy->mutex);
gpio_set_value(phy->gpio_fw_wake, wake);
- msleep(S3FWRN5_EN_WAIT_TIME);
+ if (wake)
+ msleep(S3FWRN5_EN_WAIT_TIME);
mutex_unlock(&phy->mutex);
}
EXPORT_SYMBOL(s3fwrn5_phy_set_wake);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [linux-nfc] Re: [PATCH net-next] nfc: s3fwrn5: Remove the delay for nfc sleep
2020-12-13 10:12 ` Bongsu Jeon
(?)
@ 2020-12-14 15:51 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-14 15:51 UTC (permalink / raw)
To: linux-nfc
[-- Attachment #1: Type: text/plain, Size: 350 bytes --]
On Sun, Dec 13, 2020@07:12:38PM +0900, Bongsu Jeon wrote:
> From: Bongsu Jeon <bongsu.jeon@samsung.com>
>
> remove the delay for nfc sleep because nfc doesn't need the sleep delay.
Please start sentences with capital letter.
s/nfc/NFC/ (here and in subject)
This explanation is very vague. Please rephrase it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] nfc: s3fwrn5: Remove the delay for nfc sleep
@ 2020-12-14 15:51 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-14 15:51 UTC (permalink / raw)
To: linux-nfc
[-- Attachment #1: Type: text/plain, Size: 353 bytes --]
On Sun, Dec 13, 2020 at 07:12:38PM +0900, Bongsu Jeon wrote:
> From: Bongsu Jeon <bongsu.jeon@samsung.com>
>
> remove the delay for nfc sleep because nfc doesn't need the sleep delay.
Please start sentences with capital letter.
s/nfc/NFC/ (here and in subject)
This explanation is very vague. Please rephrase it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] nfc: s3fwrn5: Remove the delay for nfc sleep
@ 2020-12-14 15:51 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-14 15:51 UTC (permalink / raw)
To: Bongsu Jeon; +Cc: linux-nfc, netdev, linux-kernel, Bongsu Jeon
On Sun, Dec 13, 2020 at 07:12:38PM +0900, Bongsu Jeon wrote:
> From: Bongsu Jeon <bongsu.jeon@samsung.com>
>
> remove the delay for nfc sleep because nfc doesn't need the sleep delay.
Please start sentences with capital letter.
s/nfc/NFC/ (here and in subject)
This explanation is very vague. Please rephrase it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-14 15:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-14 15:51 [linux-nfc] Re: [PATCH net-next] nfc: s3fwrn5: Remove the delay for nfc sleep Krzysztof Kozlowski
2020-12-14 15:51 ` Krzysztof Kozlowski
2020-12-14 15:51 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2020-12-13 10:12 [linux-nfc] " Bongsu Jeon
2020-12-13 10:12 ` Bongsu Jeon
2020-12-13 10:12 ` Bongsu Jeon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.