* [PATCH] virtio-blk: change default config-wce to false
@ 2020-12-14 16:51 Tom Yan
0 siblings, 0 replies; only message in thread
From: Tom Yan @ 2020-12-14 16:51 UTC (permalink / raw)
To: qemu-devel; +Cc: Tom Yan
This would allow `cache=` to be respected when `if=virtio` is used
(instead of `-device virtio-blk-pci`). Since `cache=writeback` is
the default, this does not cause a change in the default behavior.
Also, when `config-wce` is true, `cache.writeback` is still overriden.
Signed-off-by: Tom Yan <tom.ty89@gmail.com>
---
hw/block/virtio-blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index bac2d6fa2b..0c2ecd22bc 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -1284,7 +1284,7 @@ static Property virtio_blk_properties[] = {
DEFINE_BLOCK_CHS_PROPERTIES(VirtIOBlock, conf.conf),
DEFINE_PROP_STRING("serial", VirtIOBlock, conf.serial),
DEFINE_PROP_BIT64("config-wce", VirtIOBlock, host_features,
- VIRTIO_BLK_F_CONFIG_WCE, true),
+ VIRTIO_BLK_F_CONFIG_WCE, false),
#ifdef __linux__
DEFINE_PROP_BIT64("scsi", VirtIOBlock, host_features,
VIRTIO_BLK_F_SCSI, false),
--
2.29.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-12-14 16:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-14 16:51 [PATCH] virtio-blk: change default config-wce to false Tom Yan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.