From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
Cc: Nathan Lynch <nathanl@linux.ibm.com>,
Michael Neuling <mikey@neuling.org>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
linuxppc-dev@lists.ozlabs.org,
Valentin Schneider <valentin.schneider@arm.com>
Subject: Re: [PATCH v3 4/5] powerpc/smp: Add support detecting thread-groups sharing L2 cache
Date: Tue, 15 Dec 2020 14:13:42 +0530 [thread overview]
Message-ID: <20201215084342.GD1239129@linux.vnet.ibm.com> (raw)
In-Reply-To: <1607596739-32439-5-git-send-email-ego@linux.vnet.ibm.com>
* Gautham R. Shenoy <ego@linux.vnet.ibm.com> [2020-12-10 16:08:58]:
> From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
>
> On POWER systems, groups of threads within a core sharing the L2-cache
> can be indicated by the "ibm,thread-groups" property array with the
> identifier "2".
>
> This patch adds support for detecting this, and when present, populate
> the populating the cpu_l2_cache_mask of every CPU to the core-siblings
> which share L2 with the CPU as specified in the by the
> "ibm,thread-groups" property array.
>
> On a platform with the following "ibm,thread-group" configuration
> 00000001 00000002 00000004 00000000
> 00000002 00000004 00000006 00000001
> 00000003 00000005 00000007 00000002
> 00000002 00000004 00000000 00000002
> 00000004 00000006 00000001 00000003
> 00000005 00000007
>
Looks good to me.
Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
--
Thanks and Regards
Srikar Dronamraju
WARNING: multiple messages have this Message-ID (diff)
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
Cc: Anton Blanchard <anton@ozlabs.org>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Michael Neuling <mikey@neuling.org>,
Nicholas Piggin <npiggin@gmail.com>,
Nathan Lynch <nathanl@linux.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Valentin Schneider <valentin.schneider@arm.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/5] powerpc/smp: Add support detecting thread-groups sharing L2 cache
Date: Tue, 15 Dec 2020 14:13:42 +0530 [thread overview]
Message-ID: <20201215084342.GD1239129@linux.vnet.ibm.com> (raw)
In-Reply-To: <1607596739-32439-5-git-send-email-ego@linux.vnet.ibm.com>
* Gautham R. Shenoy <ego@linux.vnet.ibm.com> [2020-12-10 16:08:58]:
> From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com>
>
> On POWER systems, groups of threads within a core sharing the L2-cache
> can be indicated by the "ibm,thread-groups" property array with the
> identifier "2".
>
> This patch adds support for detecting this, and when present, populate
> the populating the cpu_l2_cache_mask of every CPU to the core-siblings
> which share L2 with the CPU as specified in the by the
> "ibm,thread-groups" property array.
>
> On a platform with the following "ibm,thread-group" configuration
> 00000001 00000002 00000004 00000000
> 00000002 00000004 00000006 00000001
> 00000003 00000005 00000007 00000002
> 00000002 00000004 00000000 00000002
> 00000004 00000006 00000001 00000003
> 00000005 00000007
>
Looks good to me.
Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2020-12-15 8:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 10:38 [PATCH v3 0/5] Extend Parsing "ibm, thread-groups" for Shared-L2 information Gautham R. Shenoy
2020-12-10 10:38 ` [PATCH v3 0/5] Extend Parsing "ibm,thread-groups" " Gautham R. Shenoy
2020-12-10 10:38 ` [PATCH v3 1/5] powerpc/smp: Parse ibm, thread-groups with multiple properties Gautham R. Shenoy
2020-12-10 10:38 ` [PATCH v3 1/5] powerpc/smp: Parse ibm,thread-groups " Gautham R. Shenoy
2020-12-15 8:42 ` Srikar Dronamraju
2020-12-15 8:42 ` Srikar Dronamraju
2020-12-10 10:38 ` [PATCH v3 2/5] powerpc/smp: Rename cpu_l1_cache_map as thread_group_l1_cache_map Gautham R. Shenoy
2020-12-10 10:38 ` Gautham R. Shenoy
2020-12-15 8:42 ` Srikar Dronamraju
2020-12-15 8:42 ` Srikar Dronamraju
2020-12-10 10:38 ` [PATCH v3 3/5] powerpc/smp: Rename init_thread_group_l1_cache_map() to make it generic Gautham R. Shenoy
2020-12-10 10:38 ` Gautham R. Shenoy
2020-12-15 8:43 ` Srikar Dronamraju
2020-12-15 8:43 ` Srikar Dronamraju
2020-12-10 10:38 ` [PATCH v3 4/5] powerpc/smp: Add support detecting thread-groups sharing L2 cache Gautham R. Shenoy
2020-12-10 10:38 ` Gautham R. Shenoy
2020-12-15 8:43 ` Srikar Dronamraju [this message]
2020-12-15 8:43 ` Srikar Dronamraju
2020-12-10 10:38 ` [PATCH v3 5/5] powerpc/cacheinfo: Print correct cache-sibling map/list for " Gautham R. Shenoy
2020-12-10 10:38 ` Gautham R. Shenoy
2020-12-15 8:44 ` Srikar Dronamraju
2020-12-15 8:44 ` Srikar Dronamraju
2020-12-15 10:49 ` [PATCH v3 0/5] Extend Parsing "ibm, thread-groups" for Shared-L2 information Michael Ellerman
2020-12-15 10:49 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215084342.GD1239129@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=nathanl@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=svaidy@linux.vnet.ibm.com \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.